From patchwork Thu May 4 17:36:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 90165 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp503918vqo; Thu, 4 May 2023 10:52:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7EsNthXH4Dd7MAPQZyWLdftn5QH8VqErrWhUnkzKPFpLQyhYQIPlvgaEH6HCAv6oQfT3iN X-Received: by 2002:a05:6a20:e617:b0:f3:a3b7:ae37 with SMTP id my23-20020a056a20e61700b000f3a3b7ae37mr2982373pzb.29.1683222770080; Thu, 04 May 2023 10:52:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683222770; cv=none; d=google.com; s=arc-20160816; b=uJ/29Ln1KvQCBM6WcMoaRSBlaZhVXnDhDOqGJeTg+RqoEN2O3kN5CRBTowuYKWhsdA vH3MgBpfI63jqc+XUWo5LAR1K81In0dCarlvf8X28ktKezZurmyI2mlboEKCcaXCFzAJ egDqabXIlhNfhG/13vChH4yvlDiAo5FxrE+KAtgkj0/LpSw4FgQ2vYDxdnbSKbkoWB/H I4d2IOwbR0aun0IR/I/PitLHxPyQSZm3hVk8a79d3jWEWSh8gP+6VSEj+3lbBS75cIHK 0TRW8QsZuZBGOLevUWuJ87pVrwgQ/HySSJz0cHy5F/cLKhajWwHcmET+zrdwnlPzJhRX eelA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yOx0khhJ9rSlovBxQnjfCnvSN60lTU2UdcbRUZ7BOtA=; b=LnpxGjX01k57OchsVg7ucscNG3rxSSLxi6M0lEbTyEf9+EK934BTch4S0BELjjytPh uolhxmyy7j4vpbr2a5ln9hQXlDvtWnezU/bxVfZIDTxHhe8T5vdqP/d7lvPZXGEtGEBl roe1zRwfBRSdPuZL2OuCOwwyoWCdBLF/HXcuCqx3EViY+CrEZZtgxfGOLz3ZEviRHL9k EVVpeUDpagqzOpnueOMYWOQydYqJSH8qQq/Jb8R6j28CxC2p2UEN9NHzP10p3XKEQURj 6dBRgIxQOUsR5MwFNz55L9ABXoExE7gZpnxsi6l/5Dm7iPDPV/tmQ2xi3WVXEQu1244O afaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=aTsA8AK3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x190-20020a6386c7000000b0050726756edesi17718pgd.76.2023.05.04.10.52.37; Thu, 04 May 2023 10:52:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=aTsA8AK3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230096AbjEDRgn (ORCPT + 99 others); Thu, 4 May 2023 13:36:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbjEDRg3 (ORCPT ); Thu, 4 May 2023 13:36:29 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64F084ECF; Thu, 4 May 2023 10:36:28 -0700 (PDT) Received: from jupiter.universe (dyndsl-091-248-211-176.ewe-ip-backbone.de [91.248.211.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 39637660570B; Thu, 4 May 2023 18:36:25 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1683221785; bh=BwNYqItpwXGrfyTuzvFjLuZMAbcaEb65/BiVmtlvYi4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aTsA8AK3eGEWfqeH18T6FZiZiHOL0medzyJP/Tv4bkOh/AVPJ0U0GI/aZz7cN47Le W7tCVUa2Xae67KCPdkOqybNQlu0aykfhOr9fCOCvuG+GZISLNRmnWQJiHuqfRHhMhu QdZthpiOW8/sb9c3RhKnp98mMtWAPjYAWIIec0E8f6KwpiX7POVD+6V6/npmZXuuj7 cBRaPq5xebLqB4cUUC2R99YLsk/tPk/VXrCof7DmgZVSKLnETLWDIr+7fKbMkRirMF LugpdT+C4sJi28x56xuX8sUEES74FqKEMdlZzfvWKtqLP9g/U5tlnMiaNOAnWh1Hnz oqkNKbo3aUG9A== Received: by jupiter.universe (Postfix, from userid 1000) id E5FD04807F6; Thu, 4 May 2023 19:36:20 +0200 (CEST) From: Sebastian Reichel To: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Lee Jones Cc: Michael Turquette , Stephen Boyd , Linus Walleij , Mark Brown , Liam Girdwood , Alexandre Belloni , Alessandro Zummo , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , kernel@collabora.com Subject: [PATCH v8 11/14] regulator: rk808: fix asynchronous probing Date: Thu, 4 May 2023 19:36:15 +0200 Message-Id: <20230504173618.142075-12-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230504173618.142075-1-sebastian.reichel@collabora.com> References: <20230504173618.142075-1-sebastian.reichel@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764986999325656057?= X-GMAIL-MSGID: =?utf-8?q?1764986999325656057?= If the probe routine fails with -EPROBE_DEFER after taking over the OF node from its parent driver, reprobing triggers pinctrl_bind_pins() and that will fail. Fix this by setting of_node_reused, so that the device does not try to setup pin muxing. For me this always happens once the driver is marked to prefer async probing and never happens without that flag. Fixes: 259b93b21a9f ("regulator: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in 4.14") Signed-off-by: Sebastian Reichel --- drivers/regulator/rk808-regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c index 3637e81654a8..80ba782d8923 100644 --- a/drivers/regulator/rk808-regulator.c +++ b/drivers/regulator/rk808-regulator.c @@ -1336,6 +1336,7 @@ static int rk808_regulator_probe(struct platform_device *pdev) config.dev = &pdev->dev; config.dev->of_node = pdev->dev.parent->of_node; + config.dev->of_node_reused = true; config.driver_data = pdata; config.regmap = regmap;