From patchwork Thu May 4 07:20:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiuxu Zhuo X-Patchwork-Id: 89935 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp118033vqo; Thu, 4 May 2023 00:29:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5xvzXoHMMYFJWK9w7ahZMTcwMyYQLB16lcXNya0pRWyxEvgRPGOEY0+4r96xcAjpTIpGSJ X-Received: by 2002:a05:6a20:389:b0:ef:c4f6:9122 with SMTP id 9-20020a056a20038900b000efc4f69122mr1314010pzt.24.1683185365021; Thu, 04 May 2023 00:29:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683185365; cv=none; d=google.com; s=arc-20160816; b=oL6V8lHkm83pVCBDlbbrVfBXdNbRtm7P7YKScFyv/pfIBgxVBaLo+E4H3olUCMNdDM nthDCRyzVsHSROwjr5P55SYwKTF+Cj8uAJztAPzRPSoH7PeGToIDZQ77odeTOPwlrTfv Z75jAwuoahVZHx6gK7ragsowKSNhmz/rNfyG6aPD4R8TdK5DDdbpXCKXMkS/4F+BeTVF JT6cOE0ZQ5JtPV11e+3huIsM4ie7FOcOdnYxE2M6koOsJZJpoXKCgghsLj3RRvFetpCK xZp6br5WGMmZcXuoSIuZhKNjNDR4DyHwxs5v7Gsi0LLC00LLIhNS6+f6wztaB4SHEMRv XWlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=Biutmz7k8mVc6O9ohIEbmYBmfC3Sx0h+OhA7ghAfctU=; b=N4mzoBTN6avdrHnPNcVuMcINXNsaVTGPdTHIYBbDKCF93qjHVd+cgkwXZUp+lCqJfq eCU4EvMT0+EON2Y63+dbO1eG8XTuN7LT3JYTYagCQB8Yf0gj/U30DSFfq8hCMSlsbFEU bDcBJ91sZjwHsk5CnvNnYPhD+SctI0o/+lhXF6andH7my3QF8eClmE9kEdsIGjTMHbKu A4ESKcTPbtO1Dq23HNarzWxYnwGKVYTphamcmuphCc//utF3ZqFWKaL7vXyz2kJZi/QY GhfKizOZQtk2LP0zwY7Is2lTVStyicq/V2CRJ1pHufcKaJQEEKdOGOpbrRvjniOb+sF9 8mQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WW2fbCiQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a6540cb000000b0051fb6ca1e69si33483176pgp.180.2023.05.04.00.29.12; Thu, 04 May 2023 00:29:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WW2fbCiQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229819AbjEDHVj (ORCPT + 99 others); Thu, 4 May 2023 03:21:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjEDHVh (ORCPT ); Thu, 4 May 2023 03:21:37 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90B572128 for ; Thu, 4 May 2023 00:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683184896; x=1714720896; h=from:to:cc:subject:date:message-id; bh=hl+FtDOwmA1lTmww4PEh2u/673uzerCHCGbZfck4WLY=; b=WW2fbCiQ6ws2uvTS7+Fj5K2aiI1CzZBrOwT+2bvdZPyfSwUiNk5+ISLM mE5BZYcQk7rnH8HKsziTA3eqdYmwmWgphF5dSIMAb3w+g0vejxHHYPqJz ZS3YK6AQ2aPQOv60+AW3yEI0oI2PcEoj1Mkkm2/iMjlq2Wbc5hIB0wJsA +yvtcXSimwFqCVaVKsNSAqWUlHvFn6HTZgktyMn3KSMYVYhUL7It5Y2Ai xYrYjCC7aohZz7pAEOxhAs1sJCTpmSZtt/ZVrppiz1gPExOI11n36glJO tnosr0MHNZSPy2nbmUG+N97tkyDfWW5a/Y1WxbZicL4HvguaUhkJHTPQ7 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10699"; a="414321662" X-IronPort-AV: E=Sophos;i="5.99,249,1677571200"; d="scan'208";a="414321662" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2023 00:21:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10699"; a="674432459" X-IronPort-AV: E=Sophos;i="5.99,249,1677571200"; d="scan'208";a="674432459" Received: from qiuxu-clx.sh.intel.com ([10.239.53.109]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2023 00:21:34 -0700 From: Qiuxu Zhuo To: Thomas Gleixner , Peter Zijlstra , Ingo Molnar Cc: Qiuxu Zhuo , linux-kernel@vger.kernel.org Subject: [PATCH 1/1] kernel/smp: Fix comments for smp_call_function{,_many}() Date: Thu, 4 May 2023 15:20:50 +0800 Message-Id: <20230504072051.80480-1-qiuxu.zhuo@intel.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764947777745798690?= X-GMAIL-MSGID: =?utf-8?q?1764947777745798690?= The parameter 'wait' of smp_call_function_many() is a bool, not a bitmask. smp_call_function() has no return value. Fix their function comments respectively. Signed-off-by: Qiuxu Zhuo --- kernel/smp.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/kernel/smp.c b/kernel/smp.c index 06a413987a14..ee4f3439b7d5 100644 --- a/kernel/smp.c +++ b/kernel/smp.c @@ -994,10 +994,8 @@ static void smp_call_function_many_cond(const struct cpumask *mask, * @mask: The set of cpus to run on (only runs on online subset). * @func: The function to run. This must be fast and non-blocking. * @info: An arbitrary pointer to pass to the function. - * @wait: Bitmask that controls the operation. If %SCF_WAIT is set, wait - * (atomically) until function has completed on other CPUs. If - * %SCF_RUN_LOCAL is set, the function will also be run locally - * if the local CPU is set in the @cpumask. + * @wait: If true, wait (atomically) until function has completed + * on other CPUs. * * If @wait is true, then returns once @func has returned. * @@ -1019,8 +1017,6 @@ EXPORT_SYMBOL(smp_call_function_many); * @wait: If true, wait (atomically) until function has completed * on other CPUs. * - * Returns 0. - * * If @wait is true, then returns once @func has returned; otherwise * it returns just before the target cpu calls @func. *