From patchwork Thu May 4 01:29:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Desnoyers X-Patchwork-Id: 89896 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1736343vqo; Wed, 3 May 2023 18:44:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7C/DgnslIDhkmBwNQjo8Z6MrDZ7dtta/wq4VMv+Bx2o+JKhN1KWBu1TWiM35S7Vx2YaMRT X-Received: by 2002:a17:903:2352:b0:1ab:109e:a553 with SMTP id c18-20020a170903235200b001ab109ea553mr2368592plh.62.1683164685078; Wed, 03 May 2023 18:44:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683164685; cv=none; d=google.com; s=arc-20160816; b=sc2H3LLqNff+fKo5ZwYjN8zxOXDwuUJTYG2NDl2hIrW6amy2yJM6JA4GwystG0S14K 3ESjhURglDMJlsyM4zO99d75n2RS3DvylcU3yRrH/PuAoMrRr3ZdgMepTsuhZTyd2BAv RCseI9Xei/USaEc1Lg0eC9C689gCsj7Ybo0O1WzC0CPrSGOsLAqUZobD+wLUPtiXChCF ZSSl2cqMQGjFjb1dQLQjKrwAnzz4ZKvfOlw3pJsPguxxvepXzP+cLLYap4EyJ3zHUR8t +Kq6XeqCfob4L/xet12zV/uh2ry7+c/yoBmaqOYpWeH35Okjltl2Wkb1mHioL2nPwKen CqXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mnR4vQgg+RwzAFnIUVvJaE+kou6tSnm7Sdnxo2/8WVs=; b=e2f9hBSXBPmGkCnkqjzWd4bkSUkzWKZjtF1CNjc3R04EOeWaFv5yy1M5TtX2/t6X8T OtyWfVEuNbYeVoBSUYiTzTnNpfGCc3zRObZw+GS3NtweEl3e1t/nEiVWMhs4eXBexw0p Z80RSZZbkxpaA6+xGymzz1RWa5Fh28N2UPVfAUg7Qlbqzlxu4o5r5ixjUOqjfpfwX3q6 uVhSHsznFJwoZPXvCHAWIKtBGTao/xZdZXs+NU5JBu06qhlCcVxSAitHK/OBwDI7gb5h 07CxvmlQjcsclso0yigisAGzcyU50sY/jrcxND26XP6KEI93ZHMs91aQ6zKtF2w5uL5o 8N3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@efficios.com header.s=smtpout1 header.b=xuygN5Uk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j9-20020a170903024900b001a63ba2c894si36268225plh.548.2023.05.03.18.44.20; Wed, 03 May 2023 18:44:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@efficios.com header.s=smtpout1 header.b=xuygN5Uk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbjEDB3g (ORCPT + 99 others); Wed, 3 May 2023 21:29:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbjEDB30 (ORCPT ); Wed, 3 May 2023 21:29:26 -0400 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BADD510F4 for ; Wed, 3 May 2023 18:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1683163763; bh=ChUVnmTcKYnskiJX03Msq+VaqE0BCYSG0uVoH9Ivm5k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xuygN5Uk+Hvtln/jqZyQY5taMTYykXzZu7+wCO+uCyRbm0ZIuMmTTsY20OVKDcLlr 7fbMY8KxL3WB1WB5t0XoAP1KqH8RHZ5SxcGGhliMmFNn3kNi9FhgbblkCKmHU3pJRC Gm/5Uwj5Jquo7VWNULpF5BoBXA0A87/18pKeg19+eujMsfwNCA0/1L1ftETPKCAz/D rcUu3Sx3wyV2j7molHKbwRfMP1RL9XksCsg9vCtwDNUzkZAfFvnMcUeZTKP4bbTIEa IoaMbjSuW/wHXNbJy523mfiqu4kky5EJ20UvlzlBgj/i1y/NMQ5zV0Y9OTymCeO6oV EFlybCFs2SS+A== Received: from localhost.localdomain (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4QBbnv61Kbz11fg; Wed, 3 May 2023 21:29:23 -0400 (EDT) From: Mathieu Desnoyers To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Huang Ying , Peter Zijlstra Subject: [RFC PATCH 4/4] llist.h: Fix parentheses around macro pointer parameter use Date: Wed, 3 May 2023 21:29:14 -0400 Message-Id: <20230504012914.1797355-4-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230504012914.1797355-1-mathieu.desnoyers@efficios.com> References: <20230504012914.1797355-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764926092550666915?= X-GMAIL-MSGID: =?utf-8?q?1764926092550666915?= Add missing parentheses around use of macro argument "pos" in those patterns to ensure operator precedence behaves as expected: - typeof(*pos) - pos->member The typeof(*pos) lack of parentheses around "pos" is not an issue per se in the specific macros modified here because "pos" is used as an lvalue, which should prevent use of any operator causing issue. Still add the extra parentheses for consistency. Remove useless parentheses around use of macro parameter (node) in the following pattern: llist_entry((node), typeof(*pos), member) Because comma is the lowest priority operator already, so the extra pair of parentheses is redundant. Signed-off-by: Mathieu Desnoyers Cc: Andrew Morton Cc: Huang Ying Cc: Peter Zijlstra --- include/linux/llist.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/llist.h b/include/linux/llist.h index 85bda2d02d65..45d358c15d0d 100644 --- a/include/linux/llist.h +++ b/include/linux/llist.h @@ -173,9 +173,9 @@ static inline void init_llist_head(struct llist_head *list) * reverse the order by yourself before traversing. */ #define llist_for_each_entry_safe(pos, n, node, member) \ - for (pos = llist_entry((node), typeof(*pos), member); \ + for (pos = llist_entry(node, typeof(*(pos)), member); \ member_address_is_nonnull(pos, member) && \ - (n = llist_entry(pos->member.next, typeof(*n), member), true); \ + (n = llist_entry((pos)->member.next, typeof(*(n)), member), true); \ pos = n) /**