From patchwork Wed May 3 23:14:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 89874 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1679415vqo; Wed, 3 May 2023 16:39:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Vgb/5M+BLgDkTb2xj4fdpRmRI99PagMHFf6JqXZtIucVrUp6cKJlLhOvjYuKgjhoFlhrg X-Received: by 2002:a17:903:41cc:b0:1a9:b8c7:bf9 with SMTP id u12-20020a17090341cc00b001a9b8c70bf9mr2161405ple.22.1683157185227; Wed, 03 May 2023 16:39:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683157185; cv=none; d=google.com; s=arc-20160816; b=DZrcGDk3Nt5EmB+YnpI4tQt2ftpzS8VKQ0BWi+BZe1Nbd8Pb0pp7vnmBh73zB4cv+A MA3rgxegUm0suN0PsiyVVdkfDbbTCm92RUMZFgk82AFRMSZPI/TJZ1jZNud4KlnH2RXx uN6ZBjmZ4Uf6MvM+rjeBlHzwhR+Z+UfHjRTzMta420Ykb/k9joBe/JYJfttq74jpKYM2 NMzCMnIufXa7AdDDNv+TdvJPqK1r8S86Tp261M3C948ZKxnxGcwUsjg0Fl9w06pF7uC0 /rqmR5NTX4i4XRzxhqyr/1WbS0wZCdayKYDrFkxGpoRbz4D4gSOrqtive09apZ4IeCiG nQbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=M/jV0fBeYzxNQljlpi5V0y67bU7QwIJy7qMMLL49clw=; b=Vw2/7/JQSpvYx1HOvVfoILbPy/KAmbXnqDVDqh26QpRU/wDddHu9EKYO1wBdp71vV/ SktKit/FlKNwpsyjBEizEVCpPId3bp326MP7D565TCSZsFY8OAsUe+1g4th4eREfhj/D VJTmZm7KaERrUZbCE5Yibx9VwjOOXG/sXcaK2SokD8CYhTkmwwF4A48WcH75F6XD3mLb nrDMHKlb4aeooqZ5cz/3NWmNl6dhaMdWKxEm2Hr+2cDI5D/bie+o00Jk9Pp5Jo5OcARO TaYTv6/umyWu3gL557OLCOjVP27X4iJqBlmldS+1K9QDOzG3Q9SzlGWkQZOntfoLVXaw Zvvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b17-20020a170902d51100b001a05a78f952si38092186plg.272.2023.05.03.16.39.22; Wed, 03 May 2023 16:39:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229598AbjECXPl (ORCPT + 99 others); Wed, 3 May 2023 19:15:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbjECXPg (ORCPT ); Wed, 3 May 2023 19:15:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE9457D80; Wed, 3 May 2023 16:15:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 78C4D63081; Wed, 3 May 2023 23:15:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB585C4339B; Wed, 3 May 2023 23:15:20 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1puLgr-000LKK-1l; Wed, 03 May 2023 19:15:17 -0400 Message-ID: <20230503231517.366033678@goodmis.org> User-Agent: quilt/0.66 Date: Wed, 03 May 2023 19:14:47 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , stable@vger.kernel.org, Ondrej Mosnacek Subject: [for-linus][PATCH 1/2] tracing: Fix permissions for the buffer_percent file References: <20230503231446.234385640@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764918228567970357?= X-GMAIL-MSGID: =?utf-8?q?1764918228567970357?= From: Ondrej Mosnacek This file defines both read and write operations, yet it is being created as read-only. This means that it can't be written to without the CAP_DAC_OVERRIDE capability. Fix the permissions to allow root to write to it without the need to override DAC perms. Link: https://lore.kernel.org/linux-trace-kernel/20230503140114.3280002-1-omosnace@redhat.com Cc: stable@vger.kernel.org Cc: Masami Hiramatsu Fixes: 03329f993978 ("tracing: Add tracefs file buffer_percentage") Signed-off-by: Ondrej Mosnacek Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 076d893d2965..b9be1af23a73 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -9660,7 +9660,7 @@ init_tracer_tracefs(struct trace_array *tr, struct dentry *d_tracer) tr->buffer_percent = 50; - trace_create_file("buffer_percent", TRACE_MODE_READ, d_tracer, + trace_create_file("buffer_percent", TRACE_MODE_WRITE, d_tracer, tr, &buffer_percent_fops); create_trace_options_dir(tr);