From patchwork Wed May 3 03:47:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luke Jones X-Patchwork-Id: 89554 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1056608vqo; Tue, 2 May 2023 20:51:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ50coth2F9ODCG9/PF01FEqY0o1cJgMQlet37FLxIx5QBVa6TYXV0JWEVoLcrrIBUSmto/4 X-Received: by 2002:a05:6a21:32a6:b0:f0:972e:e586 with SMTP id yt38-20020a056a2132a600b000f0972ee586mr25632267pzb.18.1683085874471; Tue, 02 May 2023 20:51:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683085874; cv=none; d=google.com; s=arc-20160816; b=L2pbIvvZSGCr5l5qDWpn0p5tSLGqRDDJ+MAJwFwORSU7LoR1svw+kvizUlI3OkKGVB Lcd5rcGaWkbhFs/RZamLQrmmdGaqB5Kru6ofUXZNLhECn9daGB0qL78HIaNUP9TwI6Ez fmivEMDsFGH8uyp8//P8LaV9b4AxE42PiQ4q4w9FaLqeyxzXB9DR18JR1AjQNYjwI1vB ZOYLwFlD6w3QlRQfOcL1ia/3Mp3iNA/Hz4DNs70u+x4eh/vEozcqw6j9pqM1eMlkMR6b QHiZLAmcpqAuy4nZqN1vi4qCDMkpPhIlM6rFt93gIvlVoCobUPJNuKV2j+K/lJLJtOb9 +aag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=GE4ZZwE36FI7n9XRr0c3ku1bZdvpZHi3wyNYWI2WMCQ=; b=IBbnrsXz23TUc6qGbud8pRfegsuGLtduKbsVfJrexT+CmmZbbmZ3zi9VnUis8dqVmU iwaR4C8C1tvfWvcQ5etrczBXcnekuDyHeXY5YIxfZUVieseLhzZb5rxbQgMwwBBwShDL X9UsFyh04+t2KWpaGZWMzZuxatZGufTyeDbc8ygs2t5amC5W/vio3pO8fD1ZJXbtpJvS wrfbBcwATBFYdD6UBWgR9NFkJIv3gVQDfGsJBxi4E2C3Vy4G7DJAqRmCGCJUn7vJ0mQE anT0j9agp6Pc2j+CysxXpGWdoWBJlrJYz+lw0haSApPHEvvIRe3duc1UlDvQqHPL+Nwi S2iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ljones.dev header.s=fm1 header.b=AFRFP6Bx; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=UnnF2LAh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q14-20020a63d60e000000b005032da21acasi32237356pgg.204.2023.05.02.20.51.01; Tue, 02 May 2023 20:51:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ljones.dev header.s=fm1 header.b=AFRFP6Bx; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=UnnF2LAh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229565AbjECDro (ORCPT + 99 others); Tue, 2 May 2023 23:47:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjECDrk (ORCPT ); Tue, 2 May 2023 23:47:40 -0400 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 441E22D69; Tue, 2 May 2023 20:47:39 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 5ABCF3200B89; Tue, 2 May 2023 23:47:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 02 May 2023 23:47:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1683085657; x= 1683172057; bh=GE4ZZwE36FI7n9XRr0c3ku1bZdvpZHi3wyNYWI2WMCQ=; b=A FRFP6BxEze6wYlk3J8FeRGTYFL8op0e4dFva7u2Sr/xhk0CBXtIW+0YL8NJ9l3Cl tOBlWdeM4H16kTrE55I+vNHzjwcLUDV5Mq61zDlzYNtsnNG/I2TtOufxj3sISNAe 4RYIiIBoAM0pFR07izAB+ff9I4+qcB1Sg5QDsPLF9lMR302dbQzVEU65vGMvaUdN PcDyVne7e0TbBcQbncpoSqZ2Kx4OWK+vVhTe0yPJle6yiuzch3Q7X51chtIFWX8c ZiNqW3kJ+DXs2GSIICt9Ox+gzM83Eexcg/KuxaCko8zGmgNI/LFlSJWuo1wbhMrI Iz8SUwPT9bYLPm0H24rbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1683085657; x= 1683172057; bh=GE4ZZwE36FI7n9XRr0c3ku1bZdvpZHi3wyNYWI2WMCQ=; b=U nnF2LAhzcWqFi/RWguKVR29vq6Vxd6svdqLPb5xLuPbJFVmpg1lyMXS+dycc5z+1 ZlYadwGgA3UnfVQ7UVkVvq0F3QXpmHYdkmBTEe1qzsUELD+/lQ7BsxSQS8cQyLac btTmxk1+V+dGVMFZ8XezgmVlppZMZgrlELxxl7GGPGMZowBYPaYAQ/41BG70q3qz fn6HmZV6kbAhwRNpkdMHem8vRe5sjCgNfbqGAGbbfEQMntUC8VDMbCvOaGwQhCkk 5IdFuk/2OVBsdbuMNOlZ+a6Er6CR6E28CdbowupITIMLUUVQpmkO+hjxqlqDJTaL M/vb+FEEg0FdZQXm/s/4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvjedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehl jhhonhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfetfedugfetudeuheetjefhue fggfelleetvdevtefhueeujeefvdegleevhefgnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 May 2023 23:47:35 -0400 (EDT) From: "Luke D. Jones" To: linux-input@vger.kernel.org Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, rydberg@bitmath.org, linux-kernel@vger.kernel.org, "Luke D. Jones" Subject: [PATCH 2/3] HID: asus: add keycodes for 0x6a, 0x4b, and 0xc7 Date: Wed, 3 May 2023 15:47:10 +1200 Message-Id: <20230503034711.253439-2-luke@ljones.dev> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230503034711.253439-1-luke@ljones.dev> References: <20230503034711.253439-1-luke@ljones.dev> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764843453844440653?= X-GMAIL-MSGID: =?utf-8?q?1764843453844440653?= These two keys are found on some models with dual display. - 0x6a is intended for controlling the secondary screen brightness. - 0x4b is intended for toggling the arrow keys between arrows and page up / page down. This key is found on a slightly modified keyboard layout. - 0xc7 is intended to cycle through keybvoard brightnesses (upwards) but there is not suitable existing code for this behaviour. Using `KEY_KBDILLUMTOGGLE` is different behaviour to Windows but at least is picked up by many desktops already. Signed-off-by: Luke D. Jones --- drivers/hid/hid-asus.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index ac93f987d822..918d0d05ca88 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -883,6 +883,7 @@ static int asus_input_mapping(struct hid_device *hdev, case 0xb5: asus_map_key_clear(KEY_CALC); break; case 0xc4: asus_map_key_clear(KEY_KBDILLUMUP); break; case 0xc5: asus_map_key_clear(KEY_KBDILLUMDOWN); break; + case 0xc7: asus_map_key_clear(KEY_KBDILLUMTOGGLE); break; /* ASUS touchpad toggle */ case 0x6b: asus_map_key_clear(KEY_F21); break; @@ -911,6 +912,12 @@ static int asus_input_mapping(struct hid_device *hdev, /* Fn+Right Aura mode next on N-Key keyboard */ case 0xb3: asus_map_key_clear(KEY_PROG3); break; + /* Screenpad toggle on N-Key keyboard */ + case 0x6a: asus_map_key_clear(KEY_F13); break; + + /* Arrows/Page-up/Down toggle on N-Key keyboard */ + case 0x4b: asus_map_key_clear(KEY_F14); break; + default: /* ASUS lazily declares 256 usages, ignore the rest, * as some make the keyboard appear as a pointer device. */