Message ID | 20230503034344.773568-1-mcgrof@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1055858vqo; Tue, 2 May 2023 20:48:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6A24kFzRA575RsT5KB4ncfG1/S8cddDm7fNMYJmsGwtigT0g8L/G7TihtBR0+QB0pQ26p2 X-Received: by 2002:a05:6a21:118f:b0:f0:b5d3:4feb with SMTP id oj15-20020a056a21118f00b000f0b5d34febmr16328252pzb.19.1683085716956; Tue, 02 May 2023 20:48:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683085716; cv=none; d=google.com; s=arc-20160816; b=u/4/iy3zkEbd5H+PXoa4M5K1meoMYPit5gnnd8s4iaheGtsrpdasEZWRP2UmUe263e BpG+0MCkC0f+EALrJmQY2iupR+tWP9hXTvIfLO+VDK+FIwlABR4A78FCK9BTqefFceWh YgTybyuvy6NP6VspUzkfH2pGaSame0Y0ZAUTBe2NrMGqnSTTPFBGzy3yCTq3YWACreXD bj5tFsl3w/bSB/MBEYFjHUsno4JGVu3YyvXew3FBGOXCmzrPwpBLq23WTVN3ZA5zjTg1 fHyiRfnltjxkfaucgsl9kzR3pvanSdZz/2+8zw0A1+XEQaIt7+9d4eGO4OqLFErqC/Jb sCDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ZIADMU0Kl928OS/WKfRbeOaDTqGObzNlyLZhin0OEhA=; b=iL2LcC6B5E25hacIFRTjM0pjFhL2XonvFJvW8kx/fgup/NnB7AFgVGu1zbj73nWMZ9 b78rFGZJTm2leT9FRXboaW+bKwjuAkY5TlKhlSziMY4hHtZYaC4qnoGTLDZbplTzfVnP 3Ti3RpivXT0aN3Y94VQJun0dUCOCneHpGAQf7lUSILKCblHGlqugl6WbkOtlqu7Phdst H/hBwT+kxhZNtgoMa9YE68+Cxmiofc02gcuWCCphFS79w0Bi2HmlA6UVn3CZiQv1HuYU 8RMI/pVuRrMHwa8dvHYTZ6yoeWiPmbIwNFpVrtl67+B8bJbD8e44S3aZSLAU73efXgS/ H2HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Z6LjI6NP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w191-20020a6382c8000000b0051b75d13052si31169236pgd.408.2023.05.02.20.48.24; Tue, 02 May 2023 20:48:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Z6LjI6NP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229506AbjECDnv (ORCPT <rfc822;heyuhang3455@gmail.com> + 99 others); Tue, 2 May 2023 23:43:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjECDnr (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 2 May 2023 23:43:47 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 793C21FEE; Tue, 2 May 2023 20:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=ZIADMU0Kl928OS/WKfRbeOaDTqGObzNlyLZhin0OEhA=; b=Z6LjI6NPKvxa7F9MQg2+mHEqf6 BatQJO2ZLt9WUOwD0Ti+q3lhN7BjZHsoBx4dRIe/3xl8XgC80Z1Yo0i7T9gbB6Uzb5tjBfYAfVccU 3e/bvgfRhNQ89Beg7Y24Y3xyTpChATHEmd+GBHxMmcO0x6/gWY3JnN2i+kodjBfWWUFPE8Y4AKB3a HdOCqzoFLE4a1o2xBnN9YqCH+fFKQBfEnyXgJcaABsWQw9XZN9Q5qI/67H4eG9t7S4YZEUJ32FZ8f CV/HasI9G/AuAsIC8o++ybW6z1AN3AtfY0BoalPBLMZh5os6sa0NAktiSfgNo+12PN26+vhourEfs b7oLqKag==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pu3P7-003FF8-11; Wed, 03 May 2023 03:43:45 +0000 From: Luis Chamberlain <mcgrof@kernel.org> To: torvalds@linux-foundation.org, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>, Luis Chamberlain <mcgrof@kernel.org> Subject: [PATCH] module: include internal.h in module/dups.c Date: Tue, 2 May 2023 20:43:44 -0700 Message-Id: <20230503034344.773568-1-mcgrof@kernel.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain <mcgrof@infradead.org> X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764843288410782072?= X-GMAIL-MSGID: =?utf-8?q?1764843288410782072?= |
Series |
module: include internal.h in module/dups.c
|
|
Commit Message
Luis Chamberlain
May 3, 2023, 3:43 a.m. UTC
From: Arnd Bergmann <arnd@arndb.de> Two newly introduced functions are declared in a header that is not included before the definition, causing a warning with sparse or 'make W=1': kernel/module/dups.c:118:6: error: no previous prototype for 'kmod_dup_request_exists_wait' [-Werror=missing-prototypes] 118 | bool kmod_dup_request_exists_wait(char *module_name, bool wait, int *dup_ret) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/module/dups.c:220:6: error: no previous prototype for 'kmod_dup_request_announce' [-Werror=missing-prototypes] 220 | void kmod_dup_request_announce(char *module_name, int ret) | ^~~~~~~~~~~~~~~~~~~~~~~~~ Add an explicit include to ensure the prototypes match. Fixes: 8660484ed1cf ("module: add debugging auto-load duplicate module support") Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/oe-kbuild-all/202304141440.DYO4NAzp-lkp@intel.com/ Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- kernel/module/dups.c | 2 ++ 1 file changed, 2 insertions(+) Linus, only one fix so far for modules so might as well send this as a patch.
diff --git a/kernel/module/dups.c b/kernel/module/dups.c index aa8e1361fdb5..f3d7ea1e96d8 100644 --- a/kernel/module/dups.c +++ b/kernel/module/dups.c @@ -32,6 +32,8 @@ #include <linux/async.h> #include <linux/uaccess.h> +#include "internal.h" + #undef MODULE_PARAM_PREFIX #define MODULE_PARAM_PREFIX "module." static bool enable_dups_trace = IS_ENABLED(CONFIG_MODULE_DEBUG_AUTOLOAD_DUPS_TRACE);