From patchwork Sat Apr 29 20:36:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 88892 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1803127vqo; Sat, 29 Apr 2023 14:28:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5rYQWXkGjgDyzL3KZ7iVUOCaq6+w5pV+8HM2Otw3itUECuBx3HzUEm4ZncGymex89HzJFJ X-Received: by 2002:a05:6a20:12c3:b0:f3:1b6:f468 with SMTP id v3-20020a056a2012c300b000f301b6f468mr12038581pzg.6.1682803714688; Sat, 29 Apr 2023 14:28:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682803714; cv=none; d=google.com; s=arc-20160816; b=lH/F5rMNB0NGGzjs7B3qvAxNp0Ib8HIKKgxWXqMEulVHkcLxo4dBykcmuxt7ZNy9ax YqLKW/IX/HDzEbivyzwTysUVOhib20mmaadDZoo5GVb4CS3FY/988HP5x30h4FQDcpre 0WmxpNXM5U0I/fJu2DiK+JnSPAP1t2S5s/o23Vx+Z22KpnUR2m9eDBIBafrYt/nHMik4 qBLenIx2R5dODRwTHhuF8Y5+ACQ+bydYEYPrG8rxK+DsLEGl4QK0K1RIVlsnWJzU+u2+ 4bi9N2D0GpqNEvuRUIHQUrNyodbxefxrFXeHzL7M0lc9q4bp3DvrCFK5tkZf9PMOxoNE u14g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=31G6Sb2EiP8yAzWRDNL7A6QBk2TM5zUFtPdf+vynu10=; b=0aGutKmxWe7sTKnkfqeSi3mXllwZDakzHmCegbjhDjz1CU3MDINQi0GdyWVABRW53F k/jH9aNMrKOADNuilwFG0F8A2WeV4xEXWOilckvN/ctgJ8QO3JIyTBRJC9lR8Q+yE1Jn +jfG//6l5mx37DB2q71Cb7wf/MwUOlSXCJv3+BOpv5jTiRgNjg7KGms91HK2Wq9UPOZN v5ECnzpGi0ZETQL1e+hJkAy/Ob/6oR2tCcTbotdt1A1P4EXtenbn+Npms4Tyc1arYjHQ pupD/Ii6U99HdtXWa2pD+d9wRthnJOYQg6AbkhlQVv5VkpbpYAeH1O93ef23ctCAKCWO lH/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F9+fg30Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i184-20020a6387c1000000b00525019d1f8bsi19467940pge.346.2023.04.29.14.28.20; Sat, 29 Apr 2023 14:28:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F9+fg30Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbjD2UgT (ORCPT + 99 others); Sat, 29 Apr 2023 16:36:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbjD2UgR (ORCPT ); Sat, 29 Apr 2023 16:36:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 309A81BFB; Sat, 29 Apr 2023 13:36:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF9B86104D; Sat, 29 Apr 2023 20:36:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBD17C433EF; Sat, 29 Apr 2023 20:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682800576; bh=sLExiy79GQPlw72Ktso4BjG7WRmQvPv8FjFLp2TADbo=; h=From:To:Cc:Subject:Date:From; b=F9+fg30ZoSKA4h3DNgFKnfrEKWWb4thtN+9IHO+qv2vF9lyqmAFDUqOV6gOgLc/Je asszhbCu3MyOLTFKBSR5/buoQ/h7nyRhM9hPFEEX2iOKUc9+yuv1PXj3P11uOly6PX b5WipRgxh2ZIRovbsmtgeO9ZXQty5YVGk8ylkG/Sgxe+FDYYUUf7+/hJNieoMovWN5 K7ig7/eonwAWxtPotEiCCPiONlSb2+ZRvBRpvNF1ZTpWpz2mF4AUoAhKQI15GIB7kN 1O45yKx5ZNzY8V+4XN82VF2d+TCIIkjT2tlqIJAOcBmd67aNAiHop8gMhfvceu3RR5 Xy2K5m5P7CRaw== From: Arnd Bergmann To: Luis Chamberlain Cc: Arnd Bergmann , kernel test robot , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] module: include internal.h in module/dups.c Date: Sat, 29 Apr 2023 22:36:04 +0200 Message-Id: <20230429203611.623812-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764547587838830433?= X-GMAIL-MSGID: =?utf-8?q?1764547587838830433?= From: Arnd Bergmann Two newly introduced functions are declared in a header that is not included before the definition, causing a warning with sparse or 'make W=1': kernel/module/dups.c:118:6: error: no previous prototype for 'kmod_dup_request_exists_wait' [-Werror=missing-prototypes] 118 | bool kmod_dup_request_exists_wait(char *module_name, bool wait, int *dup_ret) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/module/dups.c:220:6: error: no previous prototype for 'kmod_dup_request_announce' [-Werror=missing-prototypes] 220 | void kmod_dup_request_announce(char *module_name, int ret) | ^~~~~~~~~~~~~~~~~~~~~~~~~ Add an explicit include to ensure the prototypes match. Fixes: 8660484ed1cf ("module: add debugging auto-load duplicate module support") Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202304141440.DYO4NAzp-lkp@intel.com/ Signed-off-by: Arnd Bergmann --- kernel/module/dups.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/module/dups.c b/kernel/module/dups.c index aa8e1361fdb5..f3d7ea1e96d8 100644 --- a/kernel/module/dups.c +++ b/kernel/module/dups.c @@ -32,6 +32,8 @@ #include #include +#include "internal.h" + #undef MODULE_PARAM_PREFIX #define MODULE_PARAM_PREFIX "module." static bool enable_dups_trace = IS_ENABLED(CONFIG_MODULE_DEBUG_AUTOLOAD_DUPS_TRACE);