From patchwork Thu Apr 27 18:53:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 88370 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp484061vqo; Thu, 27 Apr 2023 12:24:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5DuIPqNYh3oe4MfPKupGhvlz9e0qeNOrLkRP52JEPPyBwcYHGp+vauzHzxvMK+JXPiB+CI X-Received: by 2002:a17:90a:dc18:b0:247:e54:2ca4 with SMTP id i24-20020a17090adc1800b002470e542ca4mr3537573pjv.19.1682623450884; Thu, 27 Apr 2023 12:24:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682623450; cv=none; d=google.com; s=arc-20160816; b=mfgLuHyfRn3Faf8WcWBNSRUASshDq/yKP8IOZueUkD1/D2vAYwmSzUG3YLe/zMp8/r OMR4RBtLvQdsDN9CDOCTpK46pGI0FgEy15uU0nOcP9CX3DJ7OUcQh0k1BEEXT9rNp6d4 wnAYg//CxnGForL7LCv4KqRIJ8HkY/mVNQ+nB/DymB9zLKCZAZVEvfLdjtdOBR5n8hWX bQNmNdXhqJlPj7GSRuN8XdA9flKUt+ALAApWB5o/TqVuhh9xRibPSYANnKVQEEZ8+ril JSFDhTyiZmcV0BDWGs5JpmOmZp1JJUHnzYBYYNNoHohrgqabERCz9qP93QwCOKFqrSVS cALQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=OJr2zQKRazVGDuo0VDWbMIu+MmSVthAv2wjF+NIApb8=; b=mHPwYptRxh9WWllF0TWVSC3xm6tgdB7xyrt4GNI+vrENwo1Uh75d5fRG4NI55IHkec ojZ2icZR8gzI6X6LrevtUfRKYhJFS8agX5R3dgsS8nwdMyq1i9Sr9QarBqD7y0TVXv2L Yh/VQyy9DCZ55ApcHbcyrCypyoxMr3Kocc8SQNCpgziiTnUiMt73I0ETs1hU/MciOcWh oPIr43SCU2Y4ggvURP25UwH0WcjUiq9f2ob3Gf25otWlFPfpmVCPtJFouTVExcWgxtY9 2taAZz62FanbPJ393fC7pxugQiw5gUcIQfZce2I+55tyOr4vsSRiHoXq2UFxHZUeM+OH hI1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l13-20020a63570d000000b0051f110fb97esi17855422pgb.82.2023.04.27.12.23.57; Thu, 27 Apr 2023 12:24:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244481AbjD0THn (ORCPT + 99 others); Thu, 27 Apr 2023 15:07:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244654AbjD0THl (ORCPT ); Thu, 27 Apr 2023 15:07:41 -0400 X-Greylist: delayed 787 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 27 Apr 2023 12:07:31 PDT Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF069124; Thu, 27 Apr 2023 12:07:31 -0700 (PDT) Received: from ipservice-092-217-081-249.092.217.pools.vodafone-ip.de ([92.217.81.249] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ps6l5-0003RX-Oc; Thu, 27 Apr 2023 20:54:23 +0200 From: Martin Kaiser To: Herbert Xu Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 2/3] hwrng: imx-rngc - use bitfield macros to read rng type Date: Thu, 27 Apr 2023 20:53:56 +0200 Message-Id: <20230427185357.923412-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230427185357.923412-1-martin@kaiser.cx> References: <20230427185357.923412-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764358567427078965?= X-GMAIL-MSGID: =?utf-8?q?1764358567427078965?= Use the mechanism from bitfield.h to read the rng type field in the version_id register. This makes the code a tiny bit simpler. Signed-off-by: Martin Kaiser --- drivers/char/hw_random/imx-rngc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c index 861a615ac7df..546dc3655e5b 100644 --- a/drivers/char/hw_random/imx-rngc.c +++ b/drivers/char/hw_random/imx-rngc.c @@ -27,7 +27,7 @@ #define RNGC_FIFO 0x0014 /* the fields in the ver id register */ -#define RNGC_TYPE_SHIFT 28 +#define RNG_TYPE GENMASK(31, 28) #define RNGC_VER_MAJ_SHIFT 8 /* the rng_type field */ @@ -254,7 +254,7 @@ static int imx_rngc_probe(struct platform_device *pdev) return irq; ver_id = readl(rngc->base + RNGC_VER_ID); - rng_type = ver_id >> RNGC_TYPE_SHIFT; + rng_type = FIELD_GET(RNG_TYPE, ver_id); /* * This driver supports only RNGC and RNGB. (There's a different * driver for RNGA.)