From patchwork Thu Apr 27 14:29:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88287 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp313191vqo; Thu, 27 Apr 2023 07:36:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4peFHxxuVU/m6rfI3P3G9Y1ggNgPiybZZLHUYLo7QkXMgfKPG040Lvrke6zfsRuE68Dao/ X-Received: by 2002:a17:903:283:b0:1a6:7b92:15ec with SMTP id j3-20020a170903028300b001a67b9215ecmr2304639plr.41.1682606167441; Thu, 27 Apr 2023 07:36:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682606167; cv=none; d=google.com; s=arc-20160816; b=0Ek7iQorcQuK4IdZZTkIYRiHnW4Qje5UhRQQsdwfii7aw0JoMIzZQfM+/z5wsoMAL2 xAWqIOidETVcYRprqIiCvMYW1nhwthmdVGYW7a6M1n5HQtr/Av0DBzRhHXsjWa4uhyYZ Vz84o6R1xM1tZGTfYmzLrYxjdSA6IATX5/4VcTkO2kErglZMyOEPAR2cp345nXNB6u54 r9cSbT443E0qXR1eqD6FVp/HaEls1aIfq9ap9cA7tPbBampc51uaGfUgGv6Sn+bhu2fr lpf7DjZ5UWMbq4N+MT/YY/qJ9yW3jil3c0RlU3WwqKRg90goxaNnGg3Yy/E1aS/cEvmg cbBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Hl7096BnkwEapAhbq31wcet5x7WYvlPHlve+gXUB/0c=; b=X72gdXbmlDNiGGHLjereAFbR0wYcEQcfoUPIa4Ap9HGPh2PMWp1+6CaKfrRi7nirKG stqsAOmtCBI6FVuNw7ixtsdUI/d4biQu/xNV/CWGTFTfwkBpOBH5Trf/d8ntiHr1v2y/ GwCzfkNsNS4vIwPiBlIMv2sRJGJ64c/LROhIxf0KIszGklyvtqNous4dQ3ZRJNueaX8k DkwyafNxh2cUKvrZ5wBtUnKC1BgHWxrbe9pgI9nRKjwNqzUqCGqMiCed5/40h3k7I7B7 jcg/l5eh635ONiEz79RNJC2jZD1A5Uvq9a461sYuy0B6BmdnRpyOssI2Yn7Hfl1fAqWp azUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e17-20020a170902cf5100b001a9785282f5si9338596plg.287.2023.04.27.07.35.51; Thu, 27 Apr 2023 07:36:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243956AbjD0ObC (ORCPT + 99 others); Thu, 27 Apr 2023 10:31:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244114AbjD0Oa1 (ORCPT ); Thu, 27 Apr 2023 10:30:27 -0400 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E970A449D for ; Thu, 27 Apr 2023 07:30:19 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 3F96D20B59; Thu, 27 Apr 2023 16:29:42 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 6/9] drm/bridge: tc358768: fix THS_ZEROCNT computation Date: Thu, 27 Apr 2023 16:29:31 +0200 Message-Id: <20230427142934.55435-7-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764340444687645410?= X-GMAIL-MSGID: =?utf-8?q?1764340444687645410?= From: Francesco Dolcini Correct computation of THS_ZEROCNT register. This register must be set to a value that ensure that THS_PREPARE + THS_ZERO > 145ns + 10*UI with the actual value of (THS_PREPARE + THS_ZERO) being ((1 to 2) + 1 + (TCLK_ZEROCNT + 1) + (3 to 4)) x ByteClk cycle + + HSByteClk x (2 + (1 to 2)) + (PHY delay) with PHY delay being about (8 + (5 to 6)) x MIPIBitClk cycle in the BitClk conversion. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 360c7c65f8c4..36e33cba59a2 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -760,9 +760,10 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) /* 40ns + 4*UI < THS_PREPARE < 85ns + 6*UI */ val = 50 + tc358768_to_ns(4 * ui_nsk); val = tc358768_ns_to_cnt(val, dsibclk_nsk) - 1; - /* THS_ZERO > 145ns + 10*UI */ - val2 = tc358768_ns_to_cnt(145 - tc358768_to_ns(ui_nsk), dsibclk_nsk); - val |= (val2 - tc358768_to_ns(phy_delay_nsk)) << 8; + /* THS_PREPARE + THS_ZERO > 145ns + 10*UI */ + raw_val = tc358768_ns_to_cnt(145 - tc358768_to_ns(3 * ui_nsk), dsibclk_nsk) - 10; + val2 = clamp(raw_val, 0, 127); + val |= val2 << 8; dev_dbg(priv->dev, "THS_HEADERCNT: 0x%x\n", val); tc358768_write(priv, TC358768_THS_HEADERCNT, val);