From patchwork Thu Apr 27 14:29:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88298 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp333004vqo; Thu, 27 Apr 2023 08:05:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ779ZuKkOi+prxA9LM+AtjIZrZVJP6wZFC7Z7sPRLZTBgO0E8no6Sga07Au70ZzHFBNwQpK X-Received: by 2002:a05:6a00:ad4:b0:63d:67e5:9731 with SMTP id c20-20020a056a000ad400b0063d67e59731mr3288721pfl.2.1682607925089; Thu, 27 Apr 2023 08:05:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682607925; cv=none; d=google.com; s=arc-20160816; b=PFvBoJXLi4ga2LF/s7v8cO57icWFV1QbhCpA+/flQrBOdc9xvsgDClThfr+gtijzqC lNTGqQ3xv8WTUUBH92VLGuyS1EBop/+bc66m4+biYtArt7EBytjeHEW+KaHnHkv29QA8 BhasMiLew7eqK4YiYi7spLpcQBLd1qgRAIN3OemFSUhlIPkLizjmVlu9z5Uwcs5HhOTs Wt+FYZOt+KBbaPiAd16wEMy8CSNWm3SO1Txx8E24uD7sExcBn2gzdUYOgDpUjVN1sxFD b60l8vtTB9lmCTHzWrnPWGJTfyFh4hqddatELuebpGQQOnPHRNNwCQbDrPFdetRxiXBQ Aajw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hEQT5jAKA3Jk0loFtssyFuA/Ca2EB2fsjrNCNNnpWlg=; b=O+dYi10JQqUGp4C5i0ZE48zWceKL+a4Fmj9QTIcvBbqFMHY2872/KsUbnBSCwuC3CP YZHxwcD6d9lxbb3bysw+7IFkEhPaNjB+xwAbB0xOE7E6hbqI8nnqVsvT61tP39VqKpuR jSkSKdOKrGL+CUscxXfSehxydpFEGPixOmlSo2MBFjgSlr7iFA05VHfeagWkGaNQ0+ex O3PRYWLDhLbVYAlpRIO0sHabPB/Z/aCEYFu2I/fNe8Elcho/RSXnh7dyykGSlv+DVzK4 7RmoQ9D3P9BNaSCn0LQ7PYfhy5BjbptWBMIACZlmjbTLuDKoYtOK1ES5ynoVPc1CTb/5 48ng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 194-20020a6218cb000000b0063b64146c13si19302746pfy.254.2023.04.27.08.05.08; Thu, 27 Apr 2023 08:05:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244155AbjD0Oaj (ORCPT + 99 others); Thu, 27 Apr 2023 10:30:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243711AbjD0OaT (ORCPT ); Thu, 27 Apr 2023 10:30:19 -0400 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BB825BB3 for ; Thu, 27 Apr 2023 07:29:44 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 5631220B5D; Thu, 27 Apr 2023 16:29:41 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 4/9] drm/bridge: tc358768: fix TCLK_ZEROCNT computation Date: Thu, 27 Apr 2023 16:29:29 +0200 Message-Id: <20230427142934.55435-5-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764342287491166605?= X-GMAIL-MSGID: =?utf-8?q?1764342287491166605?= From: Francesco Dolcini Correct computation of TCLK_ZEROCNT register. This register must be set to a value that ensure that (TCLK-PREPARECNT + TCLK-ZERO) > 300ns with the actual value of (TCLK-PREPARECNT + TCLK-ZERO) being (1 to 2) + (TCLK_ZEROCNT + 1)) x HSByteClkCycle + (PHY output delay) with PHY output delay being about (2 to 3) x MIPIBitClk cycle in the BitClk conversion. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index dba1bf3912f1..aff400c36066 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -742,10 +742,10 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) /* 38ns < TCLK_PREPARE < 95ns */ val = tc358768_ns_to_cnt(65, dsibclk_nsk) - 1; - /* TCLK_PREPARE > 300ns */ - val2 = tc358768_ns_to_cnt(300 + tc358768_to_ns(3 * ui_nsk), - dsibclk_nsk); - val |= (val2 - tc358768_to_ns(phy_delay_nsk - dsibclk_nsk)) << 8; + /* TCLK_PREPARE + TCLK_ZERO > 300ns */ + val2 = tc358768_ns_to_cnt(300 - tc358768_to_ns(2 * ui_nsk), + dsibclk_nsk) - 2; + val |= val2 << 8; dev_dbg(priv->dev, "TCLK_HEADERCNT: 0x%x\n", val); tc358768_write(priv, TC358768_TCLK_HEADERCNT, val);