From patchwork Thu Apr 27 14:29:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88284 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp312238vqo; Thu, 27 Apr 2023 07:34:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Fq4mMSuz7UM+AhcalckdBjVAxQ3O0TwQ4QGieZLEkeDJr9sIxYtV9vuiDsQHPFwdP4rIT X-Received: by 2002:a05:6a00:240c:b0:623:5880:98cd with SMTP id z12-20020a056a00240c00b00623588098cdmr2439327pfh.5.1682606085216; Thu, 27 Apr 2023 07:34:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682606085; cv=none; d=google.com; s=arc-20160816; b=uyn6gP4tSNcvsj1SZhUIR2BIoAWeOfOaNY5Ddh1pAkzJd/uvEH7c9+yOdTtCwyVvmE LotAV81QlRdgf9iE1q/x/Vq7vt11F0kwNvakOFJTc59E1H0nnQnxv+eBINZz2PfQrxaf EiMh+4dZE4ZXWklCZYxNWtPI+yWjvSA614Gpm0c1N8Ire9sf0A5Kt+2sqLLXYsawar4X dFIutj5gTnsZjqoX8u1U7a+/WAGg8XaLI9lUkQy9jZPFJqoog6x5ZK6MtJf+zoZJovim 9R1ffU3NUJeZy3kKP9hk2aRPZTGpm4CQv803ElHZVOrtIlXDVtV0snJZ/ZhhuKXDrhTs 7Z+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QFQFlG7JJPnyTT9ggo/86FUIEOD4XJn6sbO/A9vZSlI=; b=Fr5KnQYnyNjXz33INie9/rK4xDzjZShriXmEe9dP91v1Ns87r3vcX+8966waKRKqqY Y+rk1fM3W4373CSatlybtvv3eBjQjHJaLvTcVP4kBB1GGZRHDynHzvWnjGlTA0veAmRi WL4A+nEP2fo22BrBzpFhuZBXbBTUymHvQBv6h+WHvXiEKE38pQQFrewLcnktzUPPQZgQ 9A7mHrk1PCrgMX6MuRtqpk8cPDznULVQklA8XWrjWH1416tcjuud8pgJapI+K5QoDcla kCONzet1JDzhRwB0gSWssUlODC1sr6uNxQlxq9fLg7rIKtr3zsYUt2sEuusuu25qLHn0 FwSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g16-20020aa796b0000000b0063b86ce6813si18688043pfk.41.2023.04.27.07.34.29; Thu, 27 Apr 2023 07:34:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244087AbjD0Oab (ORCPT + 99 others); Thu, 27 Apr 2023 10:30:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243662AbjD0OaT (ORCPT ); Thu, 27 Apr 2023 10:30:19 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B73E5BAE for ; Thu, 27 Apr 2023 07:29:44 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id D87B620B49; Thu, 27 Apr 2023 16:29:39 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 1/9] drm/bridge: tc358768: always enable HS video mode Date: Thu, 27 Apr 2023 16:29:26 +0200 Message-Id: <20230427142934.55435-2-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764340358613839325?= X-GMAIL-MSGID: =?utf-8?q?1764340358613839325?= From: Francesco Dolcini Always enable HS video mode setting the TXMD bit, without this change no video output is present with DSI sinks that are setting MIPI_DSI_MODE_LPM flag (tested with LT8912B DSI-HDMI bridge). Previously the driver was enabling HS mode only when the DSI sink was not explicitly setting the MIPI_DSI_MODE_LPM, however this is not correct. The MIPI_DSI_MODE_LPM is supposed to indicate that the sink is willing to receive data in low power mode, however clearing the TC358768_DSI_CONTROL_TXMD bit will make the TC358768 send video in LP mode that is not the intended behavior. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 7c0cbe84611b..8f349bf4fc32 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -866,8 +866,7 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) val = TC358768_DSI_CONFW_MODE_SET | TC358768_DSI_CONFW_ADDR_DSI_CONTROL; val |= (dsi_dev->lanes - 1) << 1; - if (!(dsi_dev->mode_flags & MIPI_DSI_MODE_LPM)) - val |= TC358768_DSI_CONTROL_TXMD; + val |= TC358768_DSI_CONTROL_TXMD; if (!(mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS)) val |= TC358768_DSI_CONTROL_HSCKMD;