From patchwork Wed Apr 26 17:17:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 87917 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp402138vqo; Wed, 26 Apr 2023 10:28:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5dw19cNhzLWX67o1k9+Gb2RlzZ6yKSdlVTgr5YMOCKgAGOmWEAD3zdNPKcXoTgPlnita1H X-Received: by 2002:a05:6a20:7f87:b0:f6:d60d:dbbd with SMTP id d7-20020a056a207f8700b000f6d60ddbbdmr4755117pzj.61.1682530092015; Wed, 26 Apr 2023 10:28:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682530092; cv=none; d=google.com; s=arc-20160816; b=hAQ0niZqITQs2/irI9VqqYqJnkON8Ely2nYuRKHndgB+upZxSnTkr1pZXBiI+y+BGn eUEZgfA6mMgh+KxsjjHPHCjDNT7KPLrGIxCG8mqkcpbvZprm4b0VnxmmvkgAEMbTcZJD N1lW0vGVHI/brqPDyWCAol1XDFnoN/APkj0Z0/AAmatepNoubK/SGVVc73Tda9SlgzM9 6c0MPr39zEn5ky3j9UEhnxlqdjoyip34pKbE5wPHj/9XUt8lHUIKhNEP5nn+ZbLpwqk1 F/sVvYjm2CXzJi8Ws35oQsps5V00eJh2kgI/p0ffaztZG9P/LWSejamDoyePKy+K93KU zWrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=z9IUt9qimQj2Uynqb1bii58wtgNIXVOzrbIuW5hTnWo=; b=Vt2EauFKjmFNOvena9j1jUXt/SbjTNhOELUywApzjkpRzLcV9kVpbiJjqZ9fC8i5kR o4ML2bsw3L2hqWb9p/IB6IPCybcgsKqkiVYHLbvHRewvhet8ARWsk08kQSnEEIk6cav1 VvNrpKrXh7VxjxI6ehxobbZw2E0O9l+rDMLBS4hHidymPrwQPiBqBrb7A3vyN1toSdJJ T3kV88ElsdJxzP6zUivRCmUCnfo0zTawe7riXt79b81Abi8zGWaMzUlr7jmGqpBleTR1 xVw3Y4zxfSjfjRFXOLXB8ALHmoW9rzcN2RdAteCyxOwNunv5wXKBI24G2eIrVT/27+Hy H9HQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i184-20020a6387c1000000b00525019d1f8bsi11090382pge.346.2023.04.26.10.27.53; Wed, 26 Apr 2023 10:28:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234835AbjDZRR6 (ORCPT + 99 others); Wed, 26 Apr 2023 13:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233187AbjDZRRw (ORCPT ); Wed, 26 Apr 2023 13:17:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A8D955B1 for ; Wed, 26 Apr 2023 10:17:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 395F863153 for ; Wed, 26 Apr 2023 17:17:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97BECC4339C; Wed, 26 Apr 2023 17:17:50 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1prim5-005KYD-1v; Wed, 26 Apr 2023 13:17:49 -0400 Message-ID: <20230426171749.416626191@goodmis.org> User-Agent: quilt/0.66 Date: Wed, 26 Apr 2023 13:17:05 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Beau Belgrave Subject: [for-next][PATCH 02/11] tracing/user_events: Set event filter_type from type References: <20230426171703.202523909@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764260673565861271?= X-GMAIL-MSGID: =?utf-8?q?1764260673565861271?= From: Beau Belgrave Users expect that events can be filtered by the kernel. User events currently sets all event fields as FILTER_OTHER which limits to binary filters only. When strings are being used, functionality is reduced. Use filter_assign_type() to find the most appropriate filter type for each field in user events to ensure full kernel capabilities. Link: https://lkml.kernel.org/r/20230419214140.4158-2-beaub@linux.microsoft.com Signed-off-by: Beau Belgrave Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_events_user.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index cc8c6d8b69b5..eadb58a3efba 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -918,6 +918,9 @@ static int user_event_add_field(struct user_event *user, const char *type, field->is_signed = is_signed; field->filter_type = filter_type; + if (filter_type == FILTER_OTHER) + field->filter_type = filter_assign_type(type); + list_add(&field->link, &user->fields); /*