diff mbox series

rust: Sort rust/helpers.c's #include directives

Message ID 20230425202848.261139-1-amiculas@cisco.com
State New
Headers
Series rust: Sort rust/helpers.c's #include directives |

Commit Message

Ariel Miculas April 25, 2023, 8:28 p.m. UTC 
  Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1003
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
---
 rust/helpers.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Miguel Ojeda April 25, 2023, 8:37 p.m. UTC | #1 
Hi Ariel,

On Tue, Apr 25, 2023 at 10:28 PM Ariel Miculas <ariel.miculas@gmail.com> wrote:
>
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1003
> Signed-off-by: Ariel Miculas <amiculas@cisco.com>

First of all, thanks for the patch!

These tags look OK, but if you want to attribute the patches to your
Cisco address, could you please send them from that address?

Also, the commit description is missing. In the kernel, we give the
rationale for a change and describe what the patch does for every
commit.

Please take a look at `Documentation/process/submitting-patches.rst`
and try `scripts/checkpatch.pl` -- it can point some issues like this.

> +/*
> + * Sorted alphabetically.
> + */

Please join this comment with the top one, i.e. please do not open a
new /* */ block, like it is done in the other file mentioned in the
linked issue.

Cheers,
Miguel
diff mbox series

Patch

diff --git a/rust/helpers.c b/rust/helpers.c
index 81e80261d597..59a23b1647fb 100644
--- a/rust/helpers.c
+++ b/rust/helpers.c
@@ -18,13 +18,17 @@ 
  * accidentally exposed.
  */
 
+/*
+ * Sorted alphabetically.
+ */
+
 #include <linux/bug.h>
 #include <linux/build_bug.h>
 #include <linux/err.h>
-#include <linux/refcount.h>
 #include <linux/mutex.h>
-#include <linux/spinlock.h>
+#include <linux/refcount.h>
 #include <linux/sched/signal.h>
+#include <linux/spinlock.h>
 #include <linux/wait.h>
 
 __noreturn void rust_helper_BUG(void)