From patchwork Tue Apr 25 18:49:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 87523 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3610753vqo; Tue, 25 Apr 2023 12:02:38 -0700 (PDT) X-Google-Smtp-Source: AKy350aRH/5safrWnm8PWlkcNvIQe51KsA3KOwUxHyp/sjr35o0GmaELCIpADVCJSXJGubfDtaRP X-Received: by 2002:a17:90b:196:b0:247:1997:6a1f with SMTP id t22-20020a17090b019600b0024719976a1fmr18927768pjs.12.1682449358425; Tue, 25 Apr 2023 12:02:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682449358; cv=none; d=google.com; s=arc-20160816; b=NZoVcWpgiZC6U1OF5K4Wl1LJkf4Cbv5BH+PAVBVflJ+rbLUo9KDI0tGG7YgRJs9svm RST41wfHtbbd6UfQbj4JXc6hJK02IpQe7eSoJpFGtkKi36G7tOUeMu9IEvTVWHHpzUbE 3sF1JOYU9oVdiETcGvUViS8loL+TL/tnPKuhydHTIHDzPjrlfh7janYxp7aiqWI1898p JZkI9kp6cYyBu7CpyJBWGL/jcYaP+2XxiudG6IQgzxxOtUWeyNmdTOsKvkO8K/BQetMH hTMI9B6G9BXIzjy+7nmQJJTsdT4Hc1/qI/2tbh8wvWvHxv1YxOfOBKXPfMvQGl2r9XpX BSdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=Sx10pK8BcTlPxWuC2UdyTLoJxTd/hzNVWxOXwJTCI1U=; b=E/Nn5KE5T3xXwsklMbNAFc/pgfwL3joJI/0v7hhfgsbox9PmI6b9kO+37oZWT6hVjj 0TTx+Rs9SGszHe9XLn05wzk5u+g/L82cvGs5SjE7kq6tG3wRX0sZ4e7z7ezG+fj98ZKf oO814EltkVAfLSlwWfCA9tUwgYfDG3qzb5fEiqlf7Y23LyZUWtD8edtRR5kYpN8NC+9r PShxj/IhwZfX1ocllmRTIXDGao9IAsDUr0UbWVmlK4gWtZN7M65S6EJnvNkdfeQpDCLX 9fBqtRfmcH37FA6N2Iy3zq/Lo7UfHIvbRmYoDGle2nP1a41lxcLraiaBbFyfqBXV4IJk x+/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=oVYfclpJ; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x190-20020a6386c7000000b0051322a8d2aesi4909229pgd.110.2023.04.25.12.02.25; Tue, 25 Apr 2023 12:02:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=oVYfclpJ; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234826AbjDYStd (ORCPT + 99 others); Tue, 25 Apr 2023 14:49:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234665AbjDYStM (ORCPT ); Tue, 25 Apr 2023 14:49:12 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F111B14F43 for ; Tue, 25 Apr 2023 11:49:09 -0700 (PDT) Message-ID: <20230425183313.249063953@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1682448548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Sx10pK8BcTlPxWuC2UdyTLoJxTd/hzNVWxOXwJTCI1U=; b=oVYfclpJ4lXKyc1Bv0jWCtlJnHFR794oSAq6ZcvZ6asVYXISjUvO0tN93BYtwSO12YAd21 MiA5UkB41+BZuAcVdlwhCozJ6bxIb8u0daak4y8sWpeW++b+jPuLhnXj9Xb4IjzSLadoEI eXo3aZ+rMSBfX2vYolhSI2ddy6fTkjTiyl8Zp/rL/IBs4vWg2EgqF7hBomKS3iAc/SekNQ louWpCkTkZ7BFVTcBJAlCAttj+oMMxOd3MCoD+zZdAw/LRmUrQfE2CyJFXtjmsTYLXa2hj gYsPjfalmaSX9INSBITMwbcm9yqSXJMDcpkUprqvvL0cWJ8Y1Z1Kr5yxTDLIeQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1682448548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Sx10pK8BcTlPxWuC2UdyTLoJxTd/hzNVWxOXwJTCI1U=; b=fJxM40v2se4bAIg7K9hcBCTFrE3LoyTK2ertCWxBDpVMTKPMPr3GAupe6nWQ1401iGOGSE 87AUOcaZkmXy4WDQ== From: Thomas Gleixner To: LKML Cc: Frederic Weisbecker , Anna-Maria Behnsen , Peter Zijlstra , Sebastian Siewior , syzbot+5c54bd3eb218bb595aa9@syzkaller.appspotmail.com, Dmitry Vyukov , Michael Kerrisk Subject: [patch 08/20] posix-timers: Remove pointless irqsafe from hash_lock References: <20230425181827.219128101@linutronix.de> MIME-Version: 1.0 Date: Tue, 25 Apr 2023 20:49:08 +0200 (CEST) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764176018549232911?= X-GMAIL-MSGID: =?utf-8?q?1764176018549232911?= All usage of hash_lock is in thread context. No point in using spin_lock_irqsave()/irqrestore() for a single usage site. Signed-off-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker --- kernel/time/posix-timers.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/kernel/time/posix-timers.c +++ b/kernel/time/posix-timers.c @@ -470,10 +470,9 @@ static void k_itimer_rcu_free(struct rcu static void release_posix_timer(struct k_itimer *tmr, int it_id_set) { if (it_id_set) { - unsigned long flags; - spin_lock_irqsave(&hash_lock, flags); + spin_lock(&hash_lock, flags); hlist_del_rcu(&tmr->t_hash); - spin_unlock_irqrestore(&hash_lock, flags); + spin_unlock(&hash_lock, flags); } put_pid(tmr->it_pid); sigqueue_free(tmr->sigq);