diff mbox series

[5/9] maple_tree: Remove an if statement that cannot be true

Message ID 20230425110511.11680-6-zhangpeng.00@bytedance.com
State New
Headers
Series fix, rework and clean up for maple tree |

Commit Message

Peng Zhang April 25, 2023, 11:05 a.m. UTC 
  Because the commit 06e8fd999334b ("maple_tree: fix mas_empty_area() search")
is merged, this if statement cannot be true, so delete it.

Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
---
 lib/maple_tree.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Liam R. Howlett April 25, 2023, 4:16 p.m. UTC | #1 
* Peng Zhang <zhangpeng.00@bytedance.com> [230425 07:05]:
> Because the commit 06e8fd999334b ("maple_tree: fix mas_empty_area() search")
> is merged, this if statement cannot be true, so delete it.

Please try to focus on what you did and not why you did the change.  You
did the change "Because of the commit..", but that's in the git history if
someone cares to find out.

> 
> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
> ---
>  lib/maple_tree.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 294d4c8668323..7f4b2ce84ce61 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -5084,9 +5084,6 @@ static inline bool mas_anode_descend(struct ma_state *mas, unsigned long size)
>  			return true;
>  		}
>  	}
> -
> -	if (mte_is_root(mas->node))
> -		found = true;
>  done:
>  	mas->offset = offset;
>  	return found;
> -- 
> 2.20.1
>
diff mbox series

Patch

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 294d4c8668323..7f4b2ce84ce61 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5084,9 +5084,6 @@  static inline bool mas_anode_descend(struct ma_state *mas, unsigned long size)
 			return true;
 		}
 	}
-
-	if (mte_is_root(mas->node))
-		found = true;
 done:
 	mas->offset = offset;
 	return found;