diff mbox series

[net-next] net: phy: marvell: Fix inconsistent indenting in led_blink_set

Message ID 20230423172800.3470-1-ansuelsmth@gmail.com
State New
Headers
Series [net-next] net: phy: marvell: Fix inconsistent indenting in led_blink_set |

Commit Message

Christian Marangi April 23, 2023, 5:28 p.m. UTC 
  Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
test robot, probably done by the presence of an if condition dropped in
later revision of the same code.

Cc: Andrew Lunn <andrew@lunn.ch>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304240007.0VEX8QYG-lkp@intel.com/
Fixes: 46969f66e928 ("net: phy: marvell: Implement led_blink_set()")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 drivers/net/phy/marvell.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Andrew Lunn April 24, 2023, 12:37 a.m. UTC | #1 
On Sun, Apr 23, 2023 at 07:28:00PM +0200, Christian Marangi wrote:
> Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
> test robot, probably done by the presence of an if condition dropped in
> later revision of the same code.
> 
> Cc: Andrew Lunn <andrew@lunn.ch>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304240007.0VEX8QYG-lkp@intel.com/
> Fixes: 46969f66e928 ("net: phy: marvell: Implement led_blink_set()")
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
patchwork-bot+netdevbpf@kernel.org April 25, 2023, 2:10 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 23 Apr 2023 19:28:00 +0200 you wrote:
> Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
> test robot, probably done by the presence of an if condition dropped in
> later revision of the same code.
> 
> Cc: Andrew Lunn <andrew@lunn.ch>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304240007.0VEX8QYG-lkp@intel.com/
> Fixes: 46969f66e928 ("net: phy: marvell: Implement led_blink_set()")
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: phy: marvell: Fix inconsistent indenting in led_blink_set
    https://git.kernel.org/netdev/net-next/c/4774ad841bef

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index cd5d0ed9c5e5..43b6cb725551 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -2880,10 +2880,10 @@  static int m88e1318_led_blink_set(struct phy_device *phydev, u8 index,
 	case 1:
 	case 2:
 		reg &= ~(0xf << (4 * index));
-			reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
-			/* Reset default is 84ms */
-			*delay_on = 84 / 2;
-			*delay_off = 84 / 2;
+		reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
+		/* Reset default is 84ms */
+		*delay_on = 84 / 2;
+		*delay_off = 84 / 2;
 		break;
 	default:
 		return -EINVAL;