Message ID | 20230423172528.1398158-2-dario.binacchi@amarulasolutions.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2296502vqo; Sun, 23 Apr 2023 10:29:01 -0700 (PDT) X-Google-Smtp-Source: AKy350auh4JP3N1ZRxsajvicwytJaBQI8y3hXSj+jLn7j0Z+ASdbDvyf4mGkeqwvYYChnIR5zkau X-Received: by 2002:a17:90b:1e04:b0:249:86ef:f7e2 with SMTP id pg4-20020a17090b1e0400b0024986eff7e2mr11679807pjb.31.1682270940871; Sun, 23 Apr 2023 10:29:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682270940; cv=none; d=google.com; s=arc-20160816; b=kR4b0lW5eHBeSsBCEFcC0uFK85qb19hyuwS4At+IMF0DOh1mL1liNK9vVB/UU8QGWh g2+6uQd713YEtx/vupO336ZTa91Ate58Swx7zqnbunm5YVKQcyx8YDI9khSzwig+57+Z f61mE4jkhzOCqoeBwUVYPSFgeRMhxXwzuozDNQyiwldjYNfBPsKoRPNEQRswf2o+RCsr 7ZJDJugsA/4nMhd1/Pnoo4fVHb/yyuFhRG8fP/2hAHwlS1Z0FG9mifMW0oBBEpsEbiYT umle+YYA9Eh1zG3rIY70xJ7hHx4+r0FKNzeCNp4Ju69PT4eh6RhsOLbjzO+Iosv7CX4F 8Mcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6edtHrRUhMOVgTrX/B7WTyKMw10ZM0V+1t1+5ZMKBJE=; b=t/J1aO35XZwCpi76mHMxTS9wwFoNAszIhzGJgKV202epb4CivVjEaAPq7cyHYZRmQA efIT3JjyG31yA7t87GQJt8ZsMSFqrQWsFScmvVPnLgnpuuxtMH+IP3hR0OJ9p0jtKMHm gL2YkbU2hh4wbLsplfRB4an7gfJM5kXWCIqEJBIACezRAUN7BTZRa2k6ZDcVy8V1Hvwb jNQMwggZSVxE/tE9pXSCB2BqvifsCbhWLsZvBJfDhB8Q4PbksJJX0eZt1rCnVndPlRzJ rFcO2tx4EtNYuuWpUJsYUy9JpZF4LCQgCfchhppdl6TqEhNEGf7oY5U2A+c1+PFdaGkm de4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JADuU+he; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id il2-20020a17090b164200b00246ff7fbff8si10560963pjb.11.2023.04.23.10.28.48; Sun, 23 Apr 2023 10:29:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JADuU+he; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbjDWRZs (ORCPT <rfc822;fengqi706@gmail.com> + 99 others); Sun, 23 Apr 2023 13:25:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230046AbjDWRZn (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 23 Apr 2023 13:25:43 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F30B310DC for <linux-kernel@vger.kernel.org>; Sun, 23 Apr 2023 10:25:41 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-2fa0ce30ac2so3293506f8f.3 for <linux-kernel@vger.kernel.org>; Sun, 23 Apr 2023 10:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1682270740; x=1684862740; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6edtHrRUhMOVgTrX/B7WTyKMw10ZM0V+1t1+5ZMKBJE=; b=JADuU+heM2MwZW61nEJP7BxXxJ+uBDr7C7gBiY+1WKF53GSrll27l31QhAAv//vNCR MyIIGRdjzcwFduWH0m5lY+8JVthfsqqXnx2kdG91PzmYiJzR0ew21vv1f8YkRcg+udXY 2gynCLOKAD0aiNiUmStVQHwLXFIDDuKHPct+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682270740; x=1684862740; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6edtHrRUhMOVgTrX/B7WTyKMw10ZM0V+1t1+5ZMKBJE=; b=XrYVdh8w4nb3Pcb2sPLLXm3ZeGtHBaEJR4M/3eC70NHP/B2wa4CkIDz83aeydKJghr tnLj10VXePw/aWkIM3X1V574FjJLB7c2q9xqQ5++S2IVSyY8YD1hpeNLePg8xHLR97Lh IhTdBc4vZoBXUfFCxiPZVW8hLMFPmQpQZwlSs1s0aQ7ZORUicDb5jqhRzXGlBgZxDHMo roP6L82o28CqUskq/ZF/PfyNoX+mJwrRKHqD8x4qZGPtTLUrwvsagICL4dER87EpZN2z k0wpWkvlrc1DcMaAi5cgrqc8PAgZxVap4s2EIzxr+Emn6tqKSY7FZHSlJjAyW7e3GUGS ju+g== X-Gm-Message-State: AAQBX9dRSdafZlDdrmT6KSY3l3Uf2wLfqswp/4cagH8Yf8WWTTjq90Ez sTuGPk+GOUuhfzAnujNZ5C4XAD9/H44xeUbDy+eMVg== X-Received: by 2002:adf:e28b:0:b0:2f8:24f7:cc4a with SMTP id v11-20020adfe28b000000b002f824f7cc4amr7634427wri.57.1682270740105; Sun, 23 Apr 2023 10:25:40 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.. ([37.159.119.249]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b003f173987ec2sm13511653wms.22.2023.04.23.10.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 10:25:39 -0700 (PDT) From: Dario Binacchi <dario.binacchi@amarulasolutions.com> To: linux-kernel@vger.kernel.org Cc: Amarula patchwork <linux-amarula@amarulasolutions.com>, michael@amarulasolutions.com, Dario Binacchi <dario.binacchi@amarulasolutions.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Lee Jones <lee@kernel.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH 1/4] dt-bindings: mfd: stm32f7: add binding definition for CAN3 Date: Sun, 23 Apr 2023 19:25:25 +0200 Message-Id: <20230423172528.1398158-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20230423172528.1398158-1-dario.binacchi@amarulasolutions.com> References: <20230423172528.1398158-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763988934256280370?= X-GMAIL-MSGID: =?utf-8?q?1763988934256280370?= |
Series |
can: bxcan: add support for single peripheral configuration
|
|
Commit Message
Dario Binacchi
April 23, 2023, 5:25 p.m. UTC
Add binding definition for CAN3 peripheral.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
include/dt-bindings/mfd/stm32f7-rcc.h | 1 +
1 file changed, 1 insertion(+)
Comments
On Sun, 23 Apr 2023, Dario Binacchi wrote: > Add binding definition for CAN3 peripheral. > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > --- > > include/dt-bindings/mfd/stm32f7-rcc.h | 1 + > 1 file changed, 1 insertion(+) Applied, thanks
Hey Lee Jones, On 24.04.2023 10:02:29, Lee Jones wrote: > On Sun, 23 Apr 2023, Dario Binacchi wrote: > > > Add binding definition for CAN3 peripheral. > > > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > > --- > > > > include/dt-bindings/mfd/stm32f7-rcc.h | 1 + > > 1 file changed, 1 insertion(+) > > Applied, thanks I upstreamed the v2 of this series (https://lore.kernel.org/all/20230427204540.3126234-1-dario.binacchi@amarulasolutions.com/) that doesn't contain this change to net/main without noticing that the DT changes in that series depend on it. This broke the DT compilation of the stm32f746.dtsi in the net/main tree. I don't see the stm32f7-rcc.h changes in linus/master so I'm afraid this will break mainline too :/ What are the possible solutions? I see: 1) revert the stm32f746.dtsi changes via net/main 2) upstream the stm32f7-rcc.h changes via net/main, too 3) upstream the stm32f7-rcc.h changes via you tree, so that it hits mainline in the v6.4 release cycle. I'm in favor of solution number 1. Thoughts? Sorry for the mess, Marc
On 17/05/2023 16:16, Marc Kleine-Budde wrote: > Hey Lee Jones, > > On 24.04.2023 10:02:29, Lee Jones wrote: >> On Sun, 23 Apr 2023, Dario Binacchi wrote: >> >>> Add binding definition for CAN3 peripheral. >>> >>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> >>> --- >>> >>> include/dt-bindings/mfd/stm32f7-rcc.h | 1 + >>> 1 file changed, 1 insertion(+) >> >> Applied, thanks > > I upstreamed the v2 of this series > (https://lore.kernel.org/all/20230427204540.3126234-1-dario.binacchi@amarulasolutions.com/) > that doesn't contain this change to net/main without noticing that the > DT changes in that series depend on it. > > This broke the DT compilation of the stm32f746.dtsi in the net/main > tree. I don't see the stm32f7-rcc.h changes in linus/master so I'm > afraid this will break mainline too :/ > > What are the possible solutions? I see: > 1) revert the stm32f746.dtsi changes via net/main > 2) upstream the stm32f7-rcc.h changes via net/main, too > 3) upstream the stm32f7-rcc.h changes via you tree, so that it hits > mainline in the v6.4 release cycle. > > I'm in favor of solution number 1. Thoughts? DTS should never go with driver changes or with driver trees, not only because it hides ABI breaks but also for above reasons. The best if you just drop or revert DTS commits, so they can go via platform maintainer. Best regards, Krzysztof
On 17.05.2023 17:23:13, Krzysztof Kozlowski wrote: > On 17/05/2023 16:16, Marc Kleine-Budde wrote: > > Hey Lee Jones, > > > > On 24.04.2023 10:02:29, Lee Jones wrote: > >> On Sun, 23 Apr 2023, Dario Binacchi wrote: > >> > >>> Add binding definition for CAN3 peripheral. > >>> > >>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > >>> --- > >>> > >>> include/dt-bindings/mfd/stm32f7-rcc.h | 1 + > >>> 1 file changed, 1 insertion(+) > >> > >> Applied, thanks > > > > I upstreamed the v2 of this series > > (https://lore.kernel.org/all/20230427204540.3126234-1-dario.binacchi@amarulasolutions.com/) > > that doesn't contain this change to net/main without noticing that the > > DT changes in that series depend on it. > > > > This broke the DT compilation of the stm32f746.dtsi in the net/main > > tree. I don't see the stm32f7-rcc.h changes in linus/master so I'm > > afraid this will break mainline too :/ > > > > What are the possible solutions? I see: > > 1) revert the stm32f746.dtsi changes via net/main > > 2) upstream the stm32f7-rcc.h changes via net/main, too > > 3) upstream the stm32f7-rcc.h changes via you tree, so that it hits > > mainline in the v6.4 release cycle. > > > > I'm in favor of solution number 1. Thoughts? > > DTS should never go with driver changes or with driver trees, not only > because it hides ABI breaks but also for above reasons. The best if you > just drop or revert DTS commits, so they can go via platform maintainer. Reverted: https://lore.kernel.org/20230517181950.1106697-1-mkl@pengutronix.de Thanks, Marc
diff --git a/include/dt-bindings/mfd/stm32f7-rcc.h b/include/dt-bindings/mfd/stm32f7-rcc.h index a90f3613c584..8d73a9c51e2b 100644 --- a/include/dt-bindings/mfd/stm32f7-rcc.h +++ b/include/dt-bindings/mfd/stm32f7-rcc.h @@ -64,6 +64,7 @@ #define STM32F7_RCC_APB1_TIM14 8 #define STM32F7_RCC_APB1_LPTIM1 9 #define STM32F7_RCC_APB1_WWDG 11 +#define STM32F7_RCC_APB1_CAN3 13 #define STM32F7_RCC_APB1_SPI2 14 #define STM32F7_RCC_APB1_SPI3 15 #define STM32F7_RCC_APB1_SPDIFRX 16