From patchwork Sun Apr 23 01:29:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 86654 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1988770vqo; Sat, 22 Apr 2023 19:33:35 -0700 (PDT) X-Google-Smtp-Source: AKy350bgA4doL++kX2EKLVmAJc2n4YRrXWBmWU8AwcWqXojVDS6bTlqYWVaiXJuM5Oa/E4JOCkNK X-Received: by 2002:a05:6a20:8e2a:b0:ef:4fa7:b1ee with SMTP id y42-20020a056a208e2a00b000ef4fa7b1eemr10511117pzj.4.1682217214968; Sat, 22 Apr 2023 19:33:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682217214; cv=none; d=google.com; s=arc-20160816; b=vCJ9nLvJTGd4Z+89cVoamV4eqCRrdQ61zp3STHZDi1mcyzBjK0zVuhtMXA0Ee5EXNN YpfLYGQH8idlNhflHUdTFXd14jqrdaO2u5G5nUbC2RU6wIwoL2pN41/Y2NgxkYxoCWTg jRQ6/7+3jg0V/14PpRMrDGGYh2AUdhKfrQxyTDgU+DxA1AKisqVARG1mLTyOHAUTcF9k 69D8yoUNyE+GV50uc1WYN+q29Yy0gXZ9dpdgF6ZhbEA36CAPNzosK+Bxz+rqTlcRVkHR 8IxLoLI2bnLZyJOChqegM+qrl2eDRYAjIGRqs/aDSk2EFIpH0AQJt8C8q7tFCTAls+wl 8Yig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Nk+vpmATbZZ7fTZlWVG2vpP3YZZ2kDr6ZsDfrq62WvE=; b=iqPvX1OdAJVkPhcVfTT6zjtf9H2buQkj4AgBJ+5EV/Rtdc5tcwQpC9LgW+yB20oXst ksQRMTJnqwzpC75CUdCqYnBVTMPxkCfDXpIaqyooYsIqkjcjLa/V9pXS2HTLnefr5/cT JAfD3wHpNRA9pIw0Vt8W/nNN40FOLpZWyR/a7c9JkGvITmUSxbiNbqAr/qwofa9aa5/F JW4J7ZtURmAIJ4ZiDF8pG/2kIL/K0kjB1k2eG5ilryLRz/bLZMQHJDqmdyb9phSuSDER fR03tSpaifrEY/kLquiHaxs5x41bkqRYABufq0yuGHUS7jbJSzLqPuoj4kfjdRHXoCx3 1Ljw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f16-20020a63f110000000b00524ba819b3csi7592748pgi.443.2023.04.22.19.33.22; Sat, 22 Apr 2023 19:33:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbjDWBax (ORCPT + 99 others); Sat, 22 Apr 2023 21:30:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbjDWBav (ORCPT ); Sat, 22 Apr 2023 21:30:51 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9528B10E2 for ; Sat, 22 Apr 2023 18:30:50 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Q3rKY2rXbzKtCK; Sun, 23 Apr 2023 09:29:53 +0800 (CST) Received: from huawei.com (10.67.175.83) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 23 Apr 2023 09:30:48 +0800 From: ruanjinjie To: , , , , CC: Subject: [PATCH RESEND] riscv: fix kprobe __user string arg print fault issue Date: Sun, 23 Apr 2023 09:29:12 +0800 Message-ID: <20230423012912.890965-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.67.175.83] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763928486262618757?= X-GMAIL-MSGID: =?utf-8?q?1763932598266523310?= On riscv qemu platform, when add kprobe event on do_sys_open() to show filename string arg, it just print fault as follow: echo 'p:myprobe do_sys_open dfd=$arg1 filename=+0($arg2):string flags=$arg3 mode=$arg4' > kprobe_events bash-166 [000] ...1. 360.195367: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename=(fault) flags=0x8241 mode=0x1b6 bash-166 [000] ...1. 360.219369: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename=(fault) flags=0x8241 mode=0x1b6 bash-191 [000] ...1. 360.378827: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename=(fault) flags=0x98800 mode=0x0 As riscv do not select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE, the +0($arg2) addr is processed as a kernel address though it is a userspace address, cause the above filename=(fault) print. So select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE to avoid the issue, after that the kprobe trace is ok as below: bash-166 [000] ...1. 96.767641: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename="/dev/null" flags=0x8241 mode=0x1b6 bash-166 [000] ...1. 96.793751: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename="/dev/null" flags=0x8241 mode=0x1b6 bash-177 [000] ...1. 96.962354: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename="/sys/kernel/debug/tracing/events/kprobes/" flags=0x98800 mode=0x0 Signed-off-by: ruanjinjie --- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index eb7f29a412f8..c51f0d3227af 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -26,6 +26,7 @@ config RISCV select ARCH_HAS_KCOV select ARCH_HAS_MMIOWB select ARCH_HAS_PMEM_API + select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE select ARCH_HAS_PTE_SPECIAL select ARCH_HAS_SET_DIRECT_MAP if MMU select ARCH_HAS_SET_MEMORY if MMU