From patchwork Sat Apr 22 20:50:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 86626 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1887463vqo; Sat, 22 Apr 2023 13:51:53 -0700 (PDT) X-Google-Smtp-Source: AKy350ah5pRecygw+LSTeS4pyaA5HL1UatupbP/Fk1yet/HxzHFFuqyyTae5eG2PDUHYsvKfAP+T X-Received: by 2002:a05:6a00:1408:b0:63d:3339:e967 with SMTP id l8-20020a056a00140800b0063d3339e967mr11164038pfu.19.1682196713028; Sat, 22 Apr 2023 13:51:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682196713; cv=none; d=google.com; s=arc-20160816; b=vD5snNKg7e1iwcKHtsRMCnrvFyBWkL1bMAMpeN2IigAvdwjJjzCgnltu+UDUWpseMy YTxFzg+TTK+qqA4LYCpKauscFJCqY0rbgXiXxz2TGpqlSHbeZP4CYLrXFl5AQr9HnZpk fyrkbVVp6Yx2QGy8i4nod1H0PooiMiJ+Aob++1ThSgx7LI6UPMvGM0auWCxYklmJsNfk Po+6OXdFytPEtjyZWBwlB2DxuNjC0PD6pPP9m8+ek5I1gUcdpPiSBS5XRuo5SrCCVXM0 yTyCFHYuBu97UlxrcXS3oeDRkfjx7tKrFWk2UciOOSSnwRezJDBsNvalkHiho7MJX5YN mUEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oGL4YjUmNtjzAo13eiRDRoegyGKg47+uG5hqSGTP83I=; b=fK1kDqvIyDCVvmp0bh9bjIWcmBze8zMWNZ3VlJXbwWsArPnurANwxEPpw0XbOKKz/G Ote8GFQVOFAlcm02swUfyRffantxMFKvYr7QLKclYkuzvN9RGlFGeBOX8mg1rnUUwJnv +t2fInkVQcdNHK74WoXIvB6r6TN6ewaXBNF/maqNjnLokMp9UYnmSjVP7v3dMncLxsFX OnMMO8bCMgp5bzQyexMHAPfw5XlKUUs62cINlgvKUhgQqHxohFKlrYqTENYD9enT+mTT R5Hkoa4aNOMkE7YfX2PXPvHzErOlnB3n0USXRpeNij/InEweeHQlGAjo1oWHvKnND3fT vasQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J3kFpcug; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 68-20020a620647000000b0063b550e6e5fsi7353789pfg.367.2023.04.22.13.51.38; Sat, 22 Apr 2023 13:51:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J3kFpcug; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230109AbjDVUvD (ORCPT + 99 others); Sat, 22 Apr 2023 16:51:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229900AbjDVUue (ORCPT ); Sat, 22 Apr 2023 16:50:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBFEA2707; Sat, 22 Apr 2023 13:50:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7CE526154A; Sat, 22 Apr 2023 20:50:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62051C433A0; Sat, 22 Apr 2023 20:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682196630; bh=1l9FZ20oEDWymbieoAwHPoR8F5js0yQ4cqzFrz8ZJSo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J3kFpcugwh6SrXrf0AACnC0GZ2ci4nyX29YS0xlBjJS6ybq/SvyXf8BimJnkCbq7R S19s7XEx5DSPc8x9xoDFPlvjSQ+zAZ0qPRq+STcYkqJ74xbrxhOPL8Kc3SFpF3V4my kjAkFm/kwmHVKEMmhOjwyf3P6WTfssnOQFaFa4Q+Iqq3zm0/ggL/dYkXrWJ056F+BK YSO7Y3h3NstiQIJvqEWe6hn45bRb9qkvz3cSPjMAx0VsDHxqxSwZe2JwiDSsr6oJ+N 8f8x34oND6WJ+sqxQYN78YN6eC5igTfWChsqNHkw1S6zDR6YkWGogNIgQbgnJVhgPB k8BjjxiMgPB9w== Received: by mercury (Postfix, from userid 1000) id 2058C1066CCE; Sat, 22 Apr 2023 22:50:25 +0200 (CEST) From: Sebastian Reichel To: Sebastian Reichel Cc: Gerald Loacker , Michael Riesch , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: [PATCH v2 11/13] drm/panel: sitronix-st7789v: avoid hardcoding invert mode Date: Sat, 22 Apr 2023 22:50:10 +0200 Message-Id: <20230422205012.2464933-12-sre@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230422205012.2464933-1-sre@kernel.org> References: <20230422205012.2464933-1-sre@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763911100641423263?= X-GMAIL-MSGID: =?utf-8?q?1763911100641423263?= While the default panel uses invert mode, some panels require non-invert mode instead. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index 6d155c6262f3..158623a8dfb7 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c @@ -112,6 +112,7 @@ struct st7789_panel_info { const struct drm_display_mode *mode; u32 bus_format; + bool invert_mode; }; struct st7789v { @@ -171,6 +172,7 @@ static const struct drm_display_mode default_mode = { struct st7789_panel_info default_panel = { .mode = &default_mode, + .invert_mode = true, .bus_format = MEDIA_BUS_FMT_RGB666_1X18, }; @@ -321,7 +323,13 @@ static int st7789v_prepare(struct drm_panel *panel) ST7789V_TEST(ret, st7789v_write_data(ctx, ST7789V_NVGAMCTRL_VN61(0x1b))); ST7789V_TEST(ret, st7789v_write_data(ctx, ST7789V_NVGAMCTRL_VN62(0x28))); - ST7789V_TEST(ret, st7789v_write_command(ctx, MIPI_DCS_ENTER_INVERT_MODE)); + if (ctx->info->invert_mode) { + ST7789V_TEST(ret, st7789v_write_command(ctx, + MIPI_DCS_ENTER_INVERT_MODE)); + } else { + ST7789V_TEST(ret, st7789v_write_command(ctx, + MIPI_DCS_EXIT_INVERT_MODE)); + } ST7789V_TEST(ret, st7789v_write_command(ctx, ST7789V_RAMCTRL_CMD)); ST7789V_TEST(ret, st7789v_write_data(ctx, ST7789V_RAMCTRL_DM_RGB |