From patchwork Thu Apr 20 08:50:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "D. Starke" X-Patchwork-Id: 85789 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp186914vqo; Thu, 20 Apr 2023 02:07:46 -0700 (PDT) X-Google-Smtp-Source: AKy350ang2+RyTZZMhHa2uLdIUHMVXzDIyGz39UGnJH5lVMimaEjf9n7XcOoAW+N5vYsgEVl98l1 X-Received: by 2002:a05:6a21:99a1:b0:ee:d266:32b9 with SMTP id ve33-20020a056a2199a100b000eed26632b9mr1575212pzb.10.1681981666181; Thu, 20 Apr 2023 02:07:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681981666; cv=none; d=google.com; s=arc-20160816; b=0KPrK5gXqBXV6pKwjMy3HogOCWyP34LNkGmcwrWKGT5XZl8RVjr0QbKvOsNbR8AFIR dBb+bM9FqI64XzqPDrN1Jh60J+YGCYKOSGj1yw1fOOfuI/gWddY6mRdrSCQDCnHoAaCq A5zrreR0Y0XChNTv0lA00NEmIs+HjGMczEJ6QF7Dn7XOPmIGJ7xg+/LMJuSXT3TN75gq PH3HUlkpJsMc99rucS19/nqMvqj9hiwxXPN2fOV1yMLPiQkuK13NIbVqUNG9j3qmXJ4Y StGLBz4w2k+YuUdoO3nDVSQMrtDbGnonTwnnCPy5bHk5TvHpumXPOhCAkDmldu2JCKVP W4kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=oSulKytkzWMOv+kgWgQEjqlRjBDH0GiaM4Nt6CmQ6uE=; b=qX2F57pazmK2h+/vSGdi+bzvaoVAvkQRQxe4FI+s4VJBbKfzk/vu8r07YMGCphctf1 KFgfG2T6Iqmi16oKHNaGhsWE7WzpBLdHpgqi4EAvzfG5NpMT8PxZibjtSAterW1F3W8X WTcYCriB1mrUev7hOcYm+SZC+6f4mWQI2Wf2Yrx28tk05nWDnztxIclDLD5WWx2HcvVn +GnW+tPaTtdrpEcTGVZq/q/QGYva6kV2StOr0MiK9QvhGPYObBXscMKRSFUW+l/xL9jr rRL5mSsZ2Qt+y9JSgjyFvyzIT5XmF1wDUlqGl0k5HhCP4aVE7c5C/uNkYhSp7lQLb/Qr AebA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=H3Bf3Xfs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h11-20020a65480b000000b0051352239dc2si999914pgs.839.2023.04.20.02.07.33; Thu, 20 Apr 2023 02:07:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=H3Bf3Xfs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234520AbjDTI4N (ORCPT + 99 others); Thu, 20 Apr 2023 04:56:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234281AbjDTIyp (ORCPT ); Thu, 20 Apr 2023 04:54:45 -0400 X-Greylist: delayed 72 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 20 Apr 2023 01:53:12 PDT Received: from mta-65-226.siemens.flowmailer.net (mta-65-226.siemens.flowmailer.net [185.136.65.226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDD4B4C1E for ; Thu, 20 Apr 2023 01:53:12 -0700 (PDT) Received: by mta-65-226.siemens.flowmailer.net with ESMTPSA id 20230420085158fa117b030f0e7ba1f0 for ; Thu, 20 Apr 2023 10:51:58 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=daniel.starke@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc; bh=oSulKytkzWMOv+kgWgQEjqlRjBDH0GiaM4Nt6CmQ6uE=; b=H3Bf3XfsSLywLif6PpgsJJi4WNvmVpQOlZLznH+PPooqlzDhVpOPeQtn6BggKtXLtvTtGD TQpgfkfrpoI3pShOkwRM9Oi8qqZZrk8935yV5syD9+qaHX2+gh8fkMHSEmDNmob2WuOmzwXJ j47+FWaZfErSPfnJZ4yQSQE15xMX8=; From: "D. Starke" To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: linux-kernel@vger.kernel.org, Daniel Starke Subject: [PATCH v2 1/9] tty: n_gsm: fix redundant assignment of gsm->encoding Date: Thu, 20 Apr 2023 10:50:09 +0200 Message-Id: <20230420085017.7314-1-daniel.starke@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-314044:519-21489:flowmailer X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763685607543844694?= X-GMAIL-MSGID: =?utf-8?q?1763685607543844694?= From: Daniel Starke The function gsmld_open() contains a redundant assignment of gsm->encoding. The same value of GSM_ADV_OPT is already assigned to it during the initialization of the struct in gsm_alloc_mux() a few lines earlier. Fix this by removing the redundant second assignment of gsm->encoding in gsmld_open(). Fixes: e1eaea46bb40 ("tty: n_gsm line discipline") Reviewed-by: Ilpo Järvinen Signed-off-by: Daniel Starke --- drivers/tty/n_gsm.c | 1 - 1 file changed, 1 deletion(-) v1 -> v2: Added Reviewed-by tag. Link: https://lore.kernel.org/all/adf7aae2-2fd8-b191-f37-75185167f418@linux.intel.com/ diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index b7e1369a035c..c42c8b89fd46 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -3585,7 +3585,6 @@ static int gsmld_open(struct tty_struct *tty) tty->receive_room = 65536; /* Attach the initial passive connection */ - gsm->encoding = GSM_ADV_OPT; gsmld_attach_gsm(tty, gsm); /* The mux will not be activated yet, we wait for correct