diff mbox series

[06/10] ARM: dts: qcom: ipq8064: correct LED node names

Message ID	20230420075053.41976-6-krzysztof.kozlowski@linaro.org
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 06/10] ARM: dts: qcom: ipq8064: correct LED node names Date: Thu, 20 Apr 2023 09:50:49 +0200 Message-Id: <20230420075053.41976-6-krzysztof.kozlowski@linaro.org> In-Reply-To: <20230420075053.41976-1-krzysztof.kozlowski@linaro.org> References: <20230420075053.41976-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	[01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address \| [01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address [02/10] ARM: dts: qcom: sdx55: correct rsc unit-address [03/10] ARM: dts: qcom: msm8974: correct pronto unit-address [04/10] ARM: dts: qcom: ipq8064: drop leading 0 from unit-address [05/10] ARM: dts: qcom: ipq8064: drop invalid GCC thermal-sensor unit-address [06/10] ARM: dts: qcom: ipq8064: correct LED node names [07/10] ARM: dts: qcom: ipq8064: align USB node names with bindings [08/10] ARM: dts: qcom: apq8060-dragonboard: move regulators out of simple-bus [09/10] ARM: dts: qcom: msm8960-cdp: move regulator out of simple-bus [10/10] ARM: dts: qcom: apq8084: correct thermal sensor unit-address

Commit Message

Krzysztof Kozlowski April 20, 2023, 7:50 a.m. UTC

  GPIO LEDs is not a bus, so drop unit-address and also start suffix
numbering from 0:

  Warning (unit_address_vs_reg): /soc/leds/led@7: node has a unit name, but no reg or ranges property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-ipq8064-rb3011.dts |  2 +-
 arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi  | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

Konrad Dybcio April 20, 2023, 10:48 a.m. UTC | #1

On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> GPIO LEDs is not a bus, so drop unit-address and also start suffix
> numbering from 0:
> 
>   Warning (unit_address_vs_reg): /soc/leds/led@7: node has a unit name, but no reg or ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-ipq8064-rb3011.dts |  2 +-
>  arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi  | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> index 47a5d1849c72..52eadefd2fb4 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> @@ -203,7 +203,7 @@ leds {
>  			pinctrl-0 = <&leds_pins>;
>  			pinctrl-names = "default";
>  
> -			led@7 {
> +			led-0 {
>  				label = "rb3011:green:user";
>  				color = <LED_COLOR_ID_GREEN>;
>  				gpios = <&qcom_pinmux 33 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> index 411c8d63c38e..c5abe7151f14 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> @@ -92,34 +92,34 @@ leds {
>  			pinctrl-0 = <&leds_pins>;
>  			pinctrl-names = "default";
>  
> -			led@7 {
> +			led-0 {
>  				label = "led_usb1";
>  				gpios = <&qcom_pinmux 7 GPIO_ACTIVE_HIGH>;
>  				linux,default-trigger = "usbdev";
>  				default-state = "off";
>  			};
>  
> -			led@8 {
> +			led-1 {
>  				label = "led_usb3";
>  				gpios = <&qcom_pinmux 8 GPIO_ACTIVE_HIGH>;
>  				linux,default-trigger = "usbdev";
>  				default-state = "off";
>  			};
>  
> -			led@9 {
> +			led-2 {
>  				label = "status_led_fail";
>  				function = LED_FUNCTION_STATUS;
>  				gpios = <&qcom_pinmux 9 GPIO_ACTIVE_HIGH>;
>  				default-state = "off";
>  			};
>  
> -			led@26 {
> +			led-3 {
>  				label = "sata_led";
>  				gpios = <&qcom_pinmux 26 GPIO_ACTIVE_HIGH>;
>  				default-state = "off";
>  			};
>  
> -			led@53 {
> +			led-4 {
>  				label = "status_led_pass";
>  				function = LED_FUNCTION_STATUS;
>  				gpios = <&qcom_pinmux 53 GPIO_ACTIVE_HIGH>;

diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
index 47a5d1849c72..52eadefd2fb4 100644
--- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
+++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
@@ -203,7 +203,7 @@  leds {
 			pinctrl-0 = <&leds_pins>;
 			pinctrl-names = "default";
 
-			led@7 {
+			led-0 {
 				label = "rb3011:green:user";
 				color = <LED_COLOR_ID_GREEN>;
 				gpios = <&qcom_pinmux 33 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
index 411c8d63c38e..c5abe7151f14 100644
--- a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
@@ -92,34 +92,34 @@  leds {
 			pinctrl-0 = <&leds_pins>;
 			pinctrl-names = "default";
 
-			led@7 {
+			led-0 {
 				label = "led_usb1";
 				gpios = <&qcom_pinmux 7 GPIO_ACTIVE_HIGH>;
 				linux,default-trigger = "usbdev";
 				default-state = "off";
 			};
 
-			led@8 {
+			led-1 {
 				label = "led_usb3";
 				gpios = <&qcom_pinmux 8 GPIO_ACTIVE_HIGH>;
 				linux,default-trigger = "usbdev";
 				default-state = "off";
 			};
 
-			led@9 {
+			led-2 {
 				label = "status_led_fail";
 				function = LED_FUNCTION_STATUS;
 				gpios = <&qcom_pinmux 9 GPIO_ACTIVE_HIGH>;
 				default-state = "off";
 			};
 
-			led@26 {
+			led-3 {
 				label = "sata_led";
 				gpios = <&qcom_pinmux 26 GPIO_ACTIVE_HIGH>;
 				default-state = "off";
 			};
 
-			led@53 {
+			led-4 {
 				label = "status_led_pass";
 				function = LED_FUNCTION_STATUS;
 				gpios = <&qcom_pinmux 53 GPIO_ACTIVE_HIGH>;