diff mbox series

ARM: dts: qcom: msm8974: drop unit addresses from USB phys

Message ID 20230420065318.23503-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series ARM: dts: qcom: msm8974: drop unit addresses from USB phys |

Commit Message

Krzysztof Kozlowski April 20, 2023, 6:53 a.m. UTC 
  The ulpi node does not allow children to have unit address:

  Warning (unit_address_vs_reg): /soc/usb@f9a55000/ulpi/phy@a: node has a unit name, but no reg or ranges property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Actual way of fixing it depends on bindings change, so apply only if
bindings got Acked/Reviewed:
https://lore.kernel.org/linux-devicetree/20230420065051.22994-1-krzysztof.kozlowski@linaro.org/T/#u
---
 arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Konrad Dybcio April 20, 2023, 10:43 a.m. UTC | #1 
On 20.04.2023 08:53, Krzysztof Kozlowski wrote:
> The ulpi node does not allow children to have unit address:
> 
>   Warning (unit_address_vs_reg): /soc/usb@f9a55000/ulpi/phy@a: node has a unit name, but no reg or ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> 
> Actual way of fixing it depends on bindings change, so apply only if
> bindings got Acked/Reviewed:
> https://lore.kernel.org/linux-devicetree/20230420065051.22994-1-krzysztof.kozlowski@linaro.org/T/#u
> ---
>  arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 6310f635197f..939449a0c695 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -676,7 +676,7 @@ usb: usb@f9a55000 {
>  			#reset-cells = <1>;
>  
>  			ulpi {
> -				usb_hs1_phy: phy@a {
> +				usb_hs1_phy: phy-0 {
>  					compatible = "qcom,usb-hs-phy-msm8974",
>  						     "qcom,usb-hs-phy";
>  					#phy-cells = <0>;
> @@ -687,7 +687,7 @@ usb_hs1_phy: phy@a {
>  					status = "disabled";
>  				};
>  
> -				usb_hs2_phy: phy@b {
> +				usb_hs2_phy: phy-1 {
>  					compatible = "qcom,usb-hs-phy-msm8974",
>  						     "qcom,usb-hs-phy";
>  					#phy-cells = <0>;
Bjorn Andersson May 25, 2023, 4:54 a.m. UTC | #2 
On Thu, 20 Apr 2023 08:53:18 +0200, Krzysztof Kozlowski wrote:
> The ulpi node does not allow children to have unit address:
> 
>   Warning (unit_address_vs_reg): /soc/usb@f9a55000/ulpi/phy@a: node has a unit name, but no reg or ranges property
> 
> 

Applied, thanks!

[1/1] ARM: dts: qcom: msm8974: drop unit addresses from USB phys
      commit: b5c0e4a078772aa42257050df249af88301f6b13

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 6310f635197f..939449a0c695 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -676,7 +676,7 @@  usb: usb@f9a55000 {
 			#reset-cells = <1>;
 
 			ulpi {
-				usb_hs1_phy: phy@a {
+				usb_hs1_phy: phy-0 {
 					compatible = "qcom,usb-hs-phy-msm8974",
 						     "qcom,usb-hs-phy";
 					#phy-cells = <0>;
@@ -687,7 +687,7 @@  usb_hs1_phy: phy@a {
 					status = "disabled";
 				};
 
-				usb_hs2_phy: phy@b {
+				usb_hs2_phy: phy-1 {
 					compatible = "qcom,usb-hs-phy-msm8974",
 						     "qcom,usb-hs-phy";
 					#phy-cells = <0>;