From patchwork Wed Apr 19 22:55:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 85651 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp726315vqo; Wed, 19 Apr 2023 16:18:44 -0700 (PDT) X-Google-Smtp-Source: AKy350aEZcWZ2qu35W97nz981wCjlenk7dLwL01+3WLebjYRAzXvcDOxcYTq9RJmVm15cIPOEs4S X-Received: by 2002:a17:90a:8382:b0:247:1418:ad28 with SMTP id i2-20020a17090a838200b002471418ad28mr4006945pjn.22.1681946324660; Wed, 19 Apr 2023 16:18:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681946324; cv=none; d=google.com; s=arc-20160816; b=qlvnB02hGQVHiFq7AFlqp6KdSb4dRggXZpBUBRLvZIkBujaz06vNVYVYBQ82N7FEvq rTafHFrsVFsr7iEDsNKdigyij4sFdIZlCQwp2Vhtv3THs+ftsN3gP7Mx4yw40cN2D39B 5RQ+aKUXKYZPpP3mbZ3tLtFWYsdgguoCNMQmo/rj1TNEDCXQSSmbhVkHITlk6lcHAk9L bXxDQnIusZ04q8Jo+1D2ClFI6uMfVNeCD4aMZad+OLpk7JiO5bAdASt0cKVk8VmlrOJR 9kaRx3HSipMZjhQ0d/AwQjprwlGKyMuYYEgpIjibOUIdfnPkXAfJJqAZ0zyGtpkc6q6J Hjeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dpO6xBr8GRTIiZAwOhR7DhqHQGx50IOyRoOo/b42ur0=; b=g8ecqZxY9cO8gQ9AHtIZHTdXIdAzdKcVcx5z9B+K31eP4eLt/a5UblZECi+W/VWLWs ADkvSZ/cUhaXyjDRKKsxcl3d7GE7g4Uox2MI9LN/iEkRIPlzlJ75r72vt+zWVMF9rnn6 EaYgdbThTsGQffeWLQoYjA8w63FYitcj5UJ6jw6phXXRcmpq/zXVfpJeNOMhQq8w9f9h MBsqbULYMJalLPjUzFgXYvJx4hhEUOl90K3JUHdD0xR/pNx3fd+Vf8Zo5F24gcFhILpF 6v0y2SMPIns4OcAXTqFEZGuE6RQbmJE1WIDaHj7d0JK1GJH8Dm4BkUU+Wftd7Hgh5S+D lirA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kscE08GA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w14-20020a17090a1b8e00b00247735d1475si2640411pjc.143.2023.04.19.16.18.32; Wed, 19 Apr 2023 16:18:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kscE08GA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233778AbjDSW5i (ORCPT + 99 others); Wed, 19 Apr 2023 18:57:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233666AbjDSW5T (ORCPT ); Wed, 19 Apr 2023 18:57:19 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35D9E5FF7 for ; Wed, 19 Apr 2023 15:57:13 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-246bb512038so217977a91.1 for ; Wed, 19 Apr 2023 15:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681945032; x=1684537032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dpO6xBr8GRTIiZAwOhR7DhqHQGx50IOyRoOo/b42ur0=; b=kscE08GAAWK411hIe/AlrpkEs4LuqorOLSZXU62OFqZbcuwAzAR8cxaFEQzLrqNjma eIM4oARZaGkVYYFo7UShuM6mT3sodkflb5QAh7j0/+pCO1fujDsTYb6Cdq4h4L7LheLe LvW+QGq9VdNSHMlXNHrY28CT0AZxYFUZ4elQo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681945032; x=1684537032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dpO6xBr8GRTIiZAwOhR7DhqHQGx50IOyRoOo/b42ur0=; b=AjxwhUKzkbHvJD8sU3g1TnyOvjQgVIenfxNCzEHmJRWJ7HQ/L0YQ7lbMiLy3rWX8RX wzhJWUf0EL7fHB9ElNCQz58rUa8Zvg1x8+7uilHoI7/h8+Na9JutP0VPK9Kq0p8fbSmS B+1Py7+EQETGDcsBgzcVcPfS5y9XAzqXNR1kj93tPTrb7Yw1M1yFU+Mni8VkfgQ2Qxfd yEyRbAuLu8wz86Oz70Or32qSFXY/ZzDmJyFq9trjsafTzJGdymvw0szh/HSCwdXbEF+N yOE66qSFdFx1KdtWk6fKQko6Vqo18mLuavRwliLTDr7DKB6QKNeq1pghhKc/bMqxTtDx smYQ== X-Gm-Message-State: AAQBX9fCjrA26OR5fIMCQxImzMmAW54ps5arNJVQO5FojFQUpxiXf5fj 2khf99PLr1PxrQbs+8V+dDoUuA== X-Received: by 2002:a17:90a:c297:b0:240:3dc7:4939 with SMTP id f23-20020a17090ac29700b002403dc74939mr4439076pjt.27.1681945032562; Wed, 19 Apr 2023 15:57:12 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:8b1:fa03:670e:b784]) by smtp.gmail.com with ESMTPSA id h15-20020a17090aea8f00b00246ea338c96sm1847101pjz.53.2023.04.19.15.57.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 15:57:11 -0700 (PDT) From: Douglas Anderson To: Catalin Marinas , Will Deacon , Sumit Garg , Daniel Thompson , Marc Zyngier , Mark Rutland Cc: ito-yuichi@fujitsu.com, kgdb-bugreport@lists.sourceforge.net, Chen-Yu Tsai , Masayoshi Mizuma , Peter Zijlstra , Ard Biesheuvel , "Rafael J . Wysocki" , linux-arm-kernel@lists.infradead.org, Stephen Boyd , Lecopzer Chen , Thomas Gleixner , linux-perf-users@vger.kernel.org, Masayoshi Mizuma , Douglas Anderson , linux-kernel@vger.kernel.org Subject: [PATCH v8 05/10] arm64: ipi_nmi: Add support for NMI backtrace Date: Wed, 19 Apr 2023 15:55:59 -0700 Message-ID: <20230419155341.v8.5.I65981105e1f62550b0316625dd1e599deaf9e1aa@changeid> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <20230419225604.21204-1-dianders@chromium.org> References: <20230419225604.21204-1-dianders@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763648549368593507?= X-GMAIL-MSGID: =?utf-8?q?1763648549368593507?= From: Sumit Garg Enable NMI backtrace support on arm64 using IPI turned as an NMI leveraging pseudo NMIs support. It is now possible for users to get a backtrace of a CPU stuck in hard-lockup using magic SYSRQ. Signed-off-by: Sumit Garg Tested-by: Masayoshi Mizuma Tested-by: Chen-Yu Tsai Signed-off-by: Douglas Anderson --- Changes in v8: - Removed "#ifdef CONFIG_SMP" since arm64 is always SMP arch/arm64/include/asm/irq.h | 4 ++++ arch/arm64/kernel/ipi_nmi.c | 18 ++++++++++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h index fac08e18bcd5..dc35b9d23a81 100644 --- a/arch/arm64/include/asm/irq.h +++ b/arch/arm64/include/asm/irq.h @@ -6,6 +6,10 @@ #include +extern bool arch_trigger_cpumask_backtrace(const cpumask_t *mask, + bool exclude_self); +#define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace + struct pt_regs; int set_handle_irq(void (*handle_irq)(struct pt_regs *)); diff --git a/arch/arm64/kernel/ipi_nmi.c b/arch/arm64/kernel/ipi_nmi.c index 712411eed949..c592e92b8cbf 100644 --- a/arch/arm64/kernel/ipi_nmi.c +++ b/arch/arm64/kernel/ipi_nmi.c @@ -8,6 +8,7 @@ #include #include +#include #include #include @@ -31,11 +32,24 @@ void arm64_send_nmi(cpumask_t *mask) __ipi_send_mask(ipi_nmi_desc, mask); } +bool arch_trigger_cpumask_backtrace(const cpumask_t *mask, bool exclude_self) +{ + if (!ipi_nmi_desc) + return false; + + nmi_trigger_cpumask_backtrace(mask, exclude_self, arm64_send_nmi); + + return true; +} + static irqreturn_t ipi_nmi_handler(int irq, void *data) { - /* nop, NMI handlers for special features can be added here. */ + irqreturn_t ret = IRQ_NONE; + + if (nmi_cpu_backtrace(get_irq_regs())) + ret = IRQ_HANDLED; - return IRQ_NONE; + return ret; } void dynamic_ipi_setup(void)