From patchwork Tue Apr 18 23:36:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 85115 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3207138vqo; Tue, 18 Apr 2023 17:01:53 -0700 (PDT) X-Google-Smtp-Source: AKy350bp+3H+ax9PCJTTSA6NzdgCnXTstkyhytm1Tu6MoCy0ccYcJeHvXGfZjJ6cAics2ddAl2+h X-Received: by 2002:a17:902:d481:b0:1a6:d295:ad5a with SMTP id c1-20020a170902d48100b001a6d295ad5amr566104plg.1.1681862513429; Tue, 18 Apr 2023 17:01:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681862513; cv=none; d=google.com; s=arc-20160816; b=BuEX7gRZ+QaXrAdZFy6VfKloDNcci2aYnSRddEye7KupbiwlGkRh46h9v4j3f/N6/q HqKfuuub3/arrovG4JJLi/E6vPFt6RJ6xlCvCCxuKGMb6A3xDvxF6M/d/9nD9PIB50ra 43rgM7w6rBozFS7utgPRHwfBYtgrtDmxZO4V6uCxJQBdiEHF/XXOvK18VlnEP1DGMEh8 1GesNCx9T+X6KvmBZKT8MdcQFtvwUTGBMUC6OdGkDuVtGOml+f8lZG+qCRPqnuu5ATHJ hwQZiugE5J2tmJ3p4MjF08ABh/RTCDX/B/yWRMTIatgHLg+4zspZZ6PUSlluYIc0IKE+ Xdaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Fbv4H9jmdq6VlD5UfEb37WubIhQNFvs8UbIcHX8jjUI=; b=IhhyIKBoM3hxAWylhXI46PJE+bGLrKemphWmZb1eHug7Lv0zAnXLS6JR9fLIXMkteM HlNNHbfYV2MxVwB+QK/P1OGrr1CHrWM2TqUWgk+doDkplgMPt9HR5pc7DNPBV62bVoZn g9TntEKmqb9OfiDBW1q5krz44axI10jr2BWJvDuHtUrqSXZMX3lA5hROmut15ZW4K1g2 TWHI5ZEnPNN+e5wDoICLhpPSb5PVgqay7uS6gPhXZCbFohWi60XMU1Q2C9AheGzXPxwC rkUBbTcBOrLwaMjU/yJDD+c3E05Y+JOFJvdM4F34Gy41vsT5qg0YoGbyv3+eoJ8KEX/o pjMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alliedtelesis.co.nz header.s=mail181024 header.b=O3EJpAz0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=alliedtelesis.co.nz Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jf1-20020a170903268100b001a52ce7fb39si14601936plb.46.2023.04.18.17.01.40; Tue, 18 Apr 2023 17:01:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alliedtelesis.co.nz header.s=mail181024 header.b=O3EJpAz0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=alliedtelesis.co.nz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231846AbjDRXkP (ORCPT + 99 others); Tue, 18 Apr 2023 19:40:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231538AbjDRXjz (ORCPT ); Tue, 18 Apr 2023 19:39:55 -0400 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [IPv6:2001:df5:b000:5::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3FF512CBF for ; Tue, 18 Apr 2023 16:37:11 -0700 (PDT) Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id CB7572C06BA; Wed, 19 Apr 2023 11:37:08 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1681861028; bh=Fbv4H9jmdq6VlD5UfEb37WubIhQNFvs8UbIcHX8jjUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O3EJpAz0KqODcW1Dx6bXUDkGjIV/FUSYQq8wcotOrz5HmmoleRPcOTMH+MSBWj+jo n0Y3Ql6Ye9OV0TLi2fxpOfeON+kCGrj5BKg9uxq5a3gCE7CGc0xqK6TPCwdNmwFeeu 2y3eD26lza/Rol0B6jy+LV7b6QDRsIDe6HqVJvS0GCeJVdHDMUUlzLQZyjv9fwhasx F1l2rYhzPHoK4iiaDGDZdFQDRKL18AjUa9ni3VnC0TivEXTOcrzPMLXCKlgtswaVqp vOpHGAVonYW+ao/gD5KF1Bqkv4IzL+jGbPeBOky9rb2pMr6MEm7bdSseAx5tXT0jTE LOai0fkTFPpjQ== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Wed, 19 Apr 2023 11:37:08 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 054D713EE52; Wed, 19 Apr 2023 11:37:08 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 0A556283BBF; Wed, 19 Apr 2023 11:37:08 +1200 (NZST) From: Chris Packham To: jdelvare@suse.com, linux@roeck-us.net, manio@skyboo.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Packham Subject: [PATCH v2 2/2] hwmon: (adt7475) Convert to use device_property APIs Date: Wed, 19 Apr 2023 11:36:56 +1200 Message-Id: <20230418233656.869055-3-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230418233656.869055-1-chris.packham@alliedtelesis.co.nz> References: <20230418233656.869055-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 X-SEG-SpamProfiler-Analysis: v=2.3 cv=VfuJw2h9 c=1 sm=1 tr=0 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=dKHAf1wccvYA:10 a=B2oEPs-dVrQZeniiuWAA:9 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763560667040565809?= X-GMAIL-MSGID: =?utf-8?q?1763560667040565809?= Instead of of_property_read_*() use the equivalent device_property_read_*() API. This will allow these properties to be used on DT unaware platforms. For DT aware platforms this will be a noop. Signed-off-by: Chris Packham --- Notes: This is an additional update for master from the preceeding bugfix commit. I've not added a fixes tag for this one because I don't think there will be a behaviour change for existing usages. I know we have one upcoming DT unaware platform that we may want to use some of these properties via ACPI tables so I won't object if this ends up on the stable track but I don't think it meets the criteria for stable. drivers/hwmon/adt7475.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c index 6a6ebcc896b1..3b9289bc5997 100644 --- a/drivers/hwmon/adt7475.c +++ b/drivers/hwmon/adt7475.c @@ -1468,7 +1468,7 @@ static int load_config3(const struct i2c_client *client, const char *propname) u8 config3; int ret; - ret = of_property_read_string(client->dev.of_node, propname, &function); + ret = device_property_read_string(&client->dev, propname, &function); if (!ret) { ret = adt7475_read(REG_CONFIG3); if (ret < 0) @@ -1494,7 +1494,7 @@ static int load_config4(const struct i2c_client *client, const char *propname) u8 config4; int ret; - ret = of_property_read_string(client->dev.of_node, propname, &function); + ret = device_property_read_string(&client->dev, propname, &function); if (!ret) { ret = adt7475_read(REG_CONFIG4); if (ret < 0) @@ -1556,8 +1556,8 @@ static int set_property_bit(const struct i2c_client *client, char *property, u8 *config, u8 bit_index) { u32 prop_value = 0; - int ret = of_property_read_u32(client->dev.of_node, property, - &prop_value); + int ret = device_property_read_u32(&client->dev, property, + &prop_value); if (!ret) { if (prop_value)