From patchwork Tue Apr 18 13:01:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Wagner X-Patchwork-Id: 84847 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2855643vqo; Tue, 18 Apr 2023 06:34:23 -0700 (PDT) X-Google-Smtp-Source: AKy350a7nWZJb7XIT1roTBF3mtXT6FFuI2KGBQc7Z9oZT2BYUT3Yx7sGwEaqbGuY82gvQrpsOZgc X-Received: by 2002:a05:6a20:431a:b0:ef:e440:8aac with SMTP id h26-20020a056a20431a00b000efe4408aacmr8130900pzk.39.1681824863197; Tue, 18 Apr 2023 06:34:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681824863; cv=none; d=google.com; s=arc-20160816; b=Bq8avlRzZTslROCBZUhHOrEw+yfQ/9VedDPQcrRwbhhflcCdWVJvTZyg9SoREBiJ3I 9+YTvWc8kKspK379DmnKcS2mZrN3lZ/PZNepznXbGwaLDvgY+b5u+YkDQk5GwTh03SAE Y59u3AKLzdFGJFqzwFmijVmnUnvM6u9DH+b1v3OF6b4rE9UAJg2/u06/0+Svv2xKwdog /0PSrRF1clNUc3BreSyJ/GvP/ge2scwjq++QTcAH9avGJlWtyiZ16V0sNMu6TMX9oRCm d3vVRYVtnJQ8wjsCh0WvGxNErM1aLeuDUu1ourO9xfhZbRZ6+hj+RQspzMkCh+9MOR9T fT5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=ZY9sxvj6D4iXpgx1qxODzCgmh0MIsy7/YXUSzF3Zq2Y=; b=erHAoiCu4jj2Ch2tHHXmBJtIpayCyfyp+ThMN07KkPXjMKRZjmKV5nsG2oFTw3SV8A KA4byhXYNvM1vA+YLUJIVEkcEFfiA2+6MVMV5stQkn4EsQrH1lT8r1AwJX/Ydl/wQ+bL UrguRZQT4h9e0+sIVZNu5/IKA75rUx0aH00BNbSaDWZF6nUzMqIyEpcLTU97WsAApYKg 6Lrab6SMypDhKuEINuUnCNqkvU06BJjqiLeJh83nyETfZ6721E/gLYm5nyB5NIEQmBwF RkSjV3QXo6kem7+xsI4+2RvMr3pqOArgyaDh8hwr+OwPVPuhoqc1uFeA6grLdcZgSRn4 fZrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=m4dN3zHb; dkim=neutral (no key) header.i=@suse.de header.b=Eu5bdJz+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020a63f508000000b0051bb433f5d3si5305785pgh.862.2023.04.18.06.34.05; Tue, 18 Apr 2023 06:34:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=m4dN3zHb; dkim=neutral (no key) header.i=@suse.de header.b=Eu5bdJz+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232347AbjDRNCk (ORCPT + 99 others); Tue, 18 Apr 2023 09:02:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232341AbjDRNCX (ORCPT ); Tue, 18 Apr 2023 09:02:23 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A79AC140; Tue, 18 Apr 2023 06:02:13 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 583772198D; Tue, 18 Apr 2023 13:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681822932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZY9sxvj6D4iXpgx1qxODzCgmh0MIsy7/YXUSzF3Zq2Y=; b=m4dN3zHb/zbBb6KD/8nwFZcUptHzIHM08HbBQITK+/s96hkdRAB8nTZxX1aOgwx4lUeGur rOXTUaHfqzGXqbxfpy+R/0muoO2/CuvHblkltgBf+iAAcjqEyduK2UybDRbja++lnzOwYQ N7hUtYxA2i4yoA2+3ZikUumbAF+BwOk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681822932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZY9sxvj6D4iXpgx1qxODzCgmh0MIsy7/YXUSzF3Zq2Y=; b=Eu5bdJz+i0cTxM/ZzsknJ8+gQU297t32ycgeZ12JWAIvPnhulke5ZodY5vqscwKpKsB0NJ bnlqu005LfMEBUAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 49D58139CC; Tue, 18 Apr 2023 13:02:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CtbPEdSUPmSVJwAAMHmgww (envelope-from ); Tue, 18 Apr 2023 13:02:12 +0000 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Sagi Grimberg , James Smart , Chaitanya Kulkarni , Martin Belanger , Shinichiro Kawasaki , Daniel Wagner Subject: [PATCH v3 4/4] nvmet-fc: Release reference on target port Date: Tue, 18 Apr 2023 15:01:59 +0200 Message-Id: <20230418130159.11075-5-dwagner@suse.de> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230418130159.11075-1-dwagner@suse.de> References: <20230418130159.11075-1-dwagner@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763521187317058117?= X-GMAIL-MSGID: =?utf-8?q?1763521187317058117?= In case we return early out of __nvmet_fc_finish_ls_req() we still have to release the reference on the target port. Signed-off-by: Daniel Wagner --- drivers/nvme/target/fc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c index 1ab6601fdd5c..df7d84aff843 100644 --- a/drivers/nvme/target/fc.c +++ b/drivers/nvme/target/fc.c @@ -359,6 +359,7 @@ __nvmet_fc_finish_ls_req(struct nvmet_fc_ls_req_op *lsop) if (!lsop->req_queued) { spin_unlock_irqrestore(&tgtport->lock, flags); + nvmet_fc_tgtport_put(tgtport); return; }