From patchwork Tue Apr 18 13:01:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Wagner X-Patchwork-Id: 84842 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2835091vqo; Tue, 18 Apr 2023 06:09:55 -0700 (PDT) X-Google-Smtp-Source: AKy350Z9IXJKNSZyQyoLkZmFE6UOdY/ihE8dlg+ma2nY96+HGEvoojXAihecs6g3i4MP8TQI1yeb X-Received: by 2002:a05:6a20:4422:b0:f0:515d:1742 with SMTP id ce34-20020a056a20442200b000f0515d1742mr5192615pzb.53.1681823395239; Tue, 18 Apr 2023 06:09:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681823395; cv=none; d=google.com; s=arc-20160816; b=bQI1KHTB3gXCJJ2UDnUwB18dNVGTWtMwKAW4/G8bYR3H8IQ8baYoWkLdOSExgV80ku p8ZrBK162GK6JwNix3IxqW7LrWdGvhzzfHi/xKo6mDPNJr+9JAG5NtfY0wmkULj39/jO pL0B0JHVfSdIQYof1Iyr2IUJ169r9i60on8LIc6vGlQ6TGA5AVqzXo+ITpw2dWskXNK0 QgMika6UIJOU/2rx0GbFNafXX9LEWGr3+UAEnP7unO64VzdUvAM2uDjNxEIU0zhN5Emm zOFjOWLCgjhFA0/20YX+rCULRvQ086zFzZgCYWBO4Ly3eRTfZfo03nxW0AYQfW4ijq1g 762g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=5g2m9cdhDFuckoCqEKdoJuXLXK61genfhZXKo2FvJPM=; b=m+ajQuJTh0dB0NxnaLi6YMpZ8dSem9sTityEOQW5SqhGhjY2KVga7cAkPpnexBGpB3 fcEKHvCqeaxMOq2eVDP5VAPTanDuXRuv2JhjxJTxgHTcE+hye/EtoSWpXIJtOXCM+RZu YKIPzCO9DjfLs9AbZwAesTTaBPb2l9beAE4L7BPitGkA0ywhSlPL/GHiaKEj7gKOZxBq T/j2dOQ0ViDHdDzkIJUmU0P+5DysUnzOPRp1XvWgIlKqdGXlNY4c8R2/jQyvhEZnku5k K62P5t2fNUmzF6j9+xEpzCCidRxEDH0ZwLNuNaJYu8nyKR1IlcQSS3JQXB6gQD952WYU Up1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="lc1/ke99"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=YZYmCE5d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x15-20020a634a0f000000b0051f0e959dc6si2475666pga.483.2023.04.18.06.09.38; Tue, 18 Apr 2023 06:09:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="lc1/ke99"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=YZYmCE5d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232350AbjDRNCc (ORCPT + 99 others); Tue, 18 Apr 2023 09:02:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232329AbjDRNCW (ORCPT ); Tue, 18 Apr 2023 09:02:22 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB1673581; Tue, 18 Apr 2023 06:02:12 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 23EB71F8D5; Tue, 18 Apr 2023 13:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681822931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5g2m9cdhDFuckoCqEKdoJuXLXK61genfhZXKo2FvJPM=; b=lc1/ke99ZqNTootV2UfmpxNzV5L/dqCzxEu2E/KslbltKBcQqpu/J+JzXvDKdUDRFEfXFO 9NRMvGzSWM4nwIEyFA2cwsqLEhb+voC45PGEk8K+PhFpZteYuImCpYLQrS4fESQ7cTacRE I6jW3JTVYwDiENs+OgbFXOZqPaD8fqk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681822931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5g2m9cdhDFuckoCqEKdoJuXLXK61genfhZXKo2FvJPM=; b=YZYmCE5dO+lD/Uw9acR0E8Bgo4py4Uli0L+em/DUjLlbgdz/RTVlZsjRTCWfmRwZwtuf12 6h0mBsmUdG4ce6Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 14A99139CC; Tue, 18 Apr 2023 13:02:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oC4HBdOUPmSKJwAAMHmgww (envelope-from ); Tue, 18 Apr 2023 13:02:11 +0000 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Sagi Grimberg , James Smart , Chaitanya Kulkarni , Martin Belanger , Shinichiro Kawasaki , Daniel Wagner Subject: [PATCH v3 2/4] nvmet-fcloop: Do not wait on completion when unregister fails Date: Tue, 18 Apr 2023 15:01:57 +0200 Message-Id: <20230418130159.11075-3-dwagner@suse.de> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230418130159.11075-1-dwagner@suse.de> References: <20230418130159.11075-1-dwagner@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763519648079588460?= X-GMAIL-MSGID: =?utf-8?q?1763519648079588460?= The nvme_fc_unregister_localport() returns an error code in case that the locaport pointer is NULL or has already been unegisterd. localport is is either in the ONLINE state (all resources allocated) or has already been put into DELETED state. In this case we will never receive an wakeup call and thus any caller will hang, e.g. module unload. Signed-off-by: Daniel Wagner --- drivers/nvme/target/fcloop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c index 629a90fe4306..57b2d47cf640 100644 --- a/drivers/nvme/target/fcloop.c +++ b/drivers/nvme/target/fcloop.c @@ -1163,7 +1163,8 @@ __wait_localport_unreg(struct fcloop_lport *lport) ret = nvme_fc_unregister_localport(lport->localport); - wait_for_completion(&lport->unreg_done); + if (!ret) + wait_for_completion(&lport->unreg_done); kfree(lport);