Message ID | 20230418114506.46788-2-ilpo.jarvinen@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2780670vqo; Tue, 18 Apr 2023 04:49:10 -0700 (PDT) X-Google-Smtp-Source: AKy350YKA6MruGrZGLOphVrR3YRUzfPA6xLnafMOPtmgAwyW8mofnODXn8CaEgIOY4RLtJK87+b9 X-Received: by 2002:a17:90b:300c:b0:23d:3931:7b49 with SMTP id hg12-20020a17090b300c00b0023d39317b49mr1596970pjb.35.1681818550160; Tue, 18 Apr 2023 04:49:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681818550; cv=none; d=google.com; s=arc-20160816; b=A0ZAu1n8yCC1P4Zx4uCBkNmNWZeC1kDk4xreloDd4/Z5XRY9oJcipeLtGAynaP4OZE F/giOcfTtCQdbgaHaIMRMIA2Hv+UmovuKYM8b86+Ip8NIk+HG/KBxB4Zog4YQwqZ2OlF IoygFLJZaDQIeIkfWAQtDnNKlGPQJzUhr4d0/c/u/VVAZd+06NyGBWlvbETUbjSpZ2UR HoT+o7ErXmxPniuiU4Bl9x1RR1V62P79LqtICCgiv4oDh1TpUN5tWwWngG1u+EU/emMu PWj3/Iof50VtGFB5bgFfB9vd2hcV0hZCvAWw9diulkYfccMMlIh+JATbPLmbED+cSy7E vp5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hOOWL5cZAgybLvTfgqyqqJqs20FQ8Dmv7+oo0RcccEg=; b=LEpnP2xOAJxmdRe/WCJcuGueRaURsi9nhJYZRk8JpJ0he9Xjif+1JrjGCz8NhLZZt7 BCGCaPbewFwm0Sd4vtUINeHJQoGItnAYZBs0tB50Xrj4e1rOfQCBQIIkVvJ/7N+Fa6Gj NJZoPYFd+1i8x8bmeVSeSYBgjzOkGaGgWhK0Yo9PicHG80qiG1VUBkNbijGCNxEwMnpa /is08hwcvgoVYIgCZbab1UipdIViP/fKcN8IqM0tafi0JG+meU+VUKlgeH5mUuuEj/Uw fnkaT0ekrOS0rp30bn6W+zLDzTLtmo6c4/6NNAbA/XlFxDEF3ATf7H0ZlaTHLio9kFFh Thyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=S79S7sEQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mj12-20020a17090b368c00b00246799bf0c2si13457168pjb.187.2023.04.18.04.48.57; Tue, 18 Apr 2023 04:49:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=S79S7sEQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231481AbjDRLpf (ORCPT <rfc822;leviz.kernel.dev@gmail.com> + 99 others); Tue, 18 Apr 2023 07:45:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjDRLpb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 18 Apr 2023 07:45:31 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9460855AC; Tue, 18 Apr 2023 04:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681818330; x=1713354330; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gKz1qH2cDM86ZzghpGTcpGq4JirHuIesPeKIy9RAyIA=; b=S79S7sEQHo111z3klaQ2A//opsbih0hYCxF9YOIlo3DuHJSAkjvF9B4C V70praE77u5WPYrafjaxtMAN/uxqLzIu1sQBjMlG2THrwzf251kclD3+d W02Mxz1gd5cRoDhO+rgGXxjTR5T/r5qilSg1H8FOvB0oELJNhewFwdIqO Lhk+hViniaGEy16U3H6A2VNhCcCAAqQS/cpw26uwZGTDaWzeHC3vhUORS XdB7hYKGhhCCyq8SCd1HTTMy0g1gOfZv32tAmutERwkGbsEiSPfuYiHt7 9d57JRizN1WaJdwQZnmpxMR3l22K/LAl6VGWXtdVrwf1NPedRqiguvwc2 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="346994279" X-IronPort-AV: E=Sophos;i="5.99,207,1677571200"; d="scan'208";a="346994279" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 04:45:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="723601516" X-IronPort-AV: E=Sophos;i="5.99,207,1677571200"; d="scan'208";a="723601516" Received: from yvolokit-mobl1.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.251.213.103]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 04:45:27 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> To: linux-kselftest@vger.kernel.org, Reinette Chatre <reinette.chatre@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>, Babu Moger <babu.moger@amd.com>, Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>, linux-kernel@vger.kernel.org Cc: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>, =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> Subject: [PATCH v2 01/24] selftests/resctrl: Add resctrl.h into build deps Date: Tue, 18 Apr 2023 14:44:43 +0300 Message-Id: <20230418114506.46788-2-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com> References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763514568046457988?= X-GMAIL-MSGID: =?utf-8?q?1763514568046457988?= |
Series |
selftests/resctrl: Fixes, cleanups, and rewritten CAT test
|
|
Commit Message
Ilpo Järvinen
April 18, 2023, 11:44 a.m. UTC
Makefile only lists *.c as build dependecies for the restctrl_tests
executable which excludes resctrl.h.
Add *.h to wildcard() cover also resctrl.h.
Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data")
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
tools/testing/selftests/resctrl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Ilpo, On 4/18/2023 4:44 AM, Ilpo Järvinen wrote: > Makefile only lists *.c as build dependecies for the restctrl_tests dependecies -> dependencies restctrl_tests -> resctrl_tests > executable which excludes resctrl.h. > > Add *.h to wildcard() cover also resctrl.h. I find this a bit hard to parse. How about "Add *.h to wildcard() to include resctrl.h." (considering the problem statement indicates that resctrl.h was "excluded", having it now "included" seems to match) > > Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data") > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > tools/testing/selftests/resctrl/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile > index 73d53257df42..2dc7da221795 100644 > --- a/tools/testing/selftests/resctrl/Makefile > +++ b/tools/testing/selftests/resctrl/Makefile > @@ -7,4 +7,4 @@ TEST_GEN_PROGS := resctrl_tests > > include ../lib.mk > > -$(OUTPUT)/resctrl_tests: $(wildcard *.c) > +$(OUTPUT)/resctrl_tests: $(wildcard *.c *.h) How about a simpler *.[ch]? Seems like this pattern is popular in selftest code. Reinette
diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile index 73d53257df42..2dc7da221795 100644 --- a/tools/testing/selftests/resctrl/Makefile +++ b/tools/testing/selftests/resctrl/Makefile @@ -7,4 +7,4 @@ TEST_GEN_PROGS := resctrl_tests include ../lib.mk -$(OUTPUT)/resctrl_tests: $(wildcard *.c) +$(OUTPUT)/resctrl_tests: $(wildcard *.c *.h)