[V2,1/3] dt-bindings: net: wireless: qcom,ath11k: allow describing radios
Commit Message
From: Rafał Miłecki <rafal@milecki.pl>
Qualcomm ath11k chipsets can have up to 3 radios. Each radio may need to
be additionally described by including its MAC or available frequency
ranges.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
V2: Fix dt_binding_check (add address + size cells & reg)
---
.../bindings/net/wireless/qcom,ath11k.yaml | 36 +++++++++++++++++++
1 file changed, 36 insertions(+)
Comments
On 18/04/2023 11:38, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Qualcomm ath11k chipsets can have up to 3 radios. Each radio may need to
> be additionally described by including its MAC or available frequency
> ranges.
The binding looks fine, but I wonder what is the radio here? It feels
like one antenna, e.g. 2.4 or 5 GHz, but you added $ref to
ieee80211.yaml which is used for entire device. What is the "radio" here?
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> V2: Fix dt_binding_check (add address + size cells & reg)
> ---
Best regards,
Krzysztof
@@ -78,6 +78,34 @@ properties:
items:
- const: wlan-smp2p-out
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+patternProperties:
+ "^radio@[0-2]$":
+ type: object
+
+ allOf:
+ - $ref: ieee80211.yaml#
+
+ properties:
+ reg:
+ maxItems: 1
+ description: Radio index
+
+ nvmem-cells:
+ items:
+ - description: NVMEM cell with the MAC address
+
+ nvmem-cell-names:
+ items:
+ - const: mac-address
+
+ unevaluatedProperties: false
+
required:
- compatible
- reg
@@ -378,6 +406,14 @@ examples:
"wbm2host-tx-completions-ring1",
"tcl2host-status-ring";
qcom,rproc = <&q6v5_wcss>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ radio@0 {
+ reg = <0x0>;
+ nvmem-cells = <&mac>;
+ nvmem-cell-names = "mac-address";
+ };
};
- |