Message ID | 20230418080054.452955-7-luca.ceresoli@bootlin.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2668820vqo; Tue, 18 Apr 2023 01:13:26 -0700 (PDT) X-Google-Smtp-Source: AKy350b2maCtXrK2pMjD5v/bCls7ICV0ZROF0FazfvXaA8c3OUi/oxyH9ZDBBwS7X7AZSBNKNx56 X-Received: by 2002:a17:902:bc42:b0:1a6:ab9c:ea18 with SMTP id t2-20020a170902bc4200b001a6ab9cea18mr1300113plz.42.1681805606670; Tue, 18 Apr 2023 01:13:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681805606; cv=none; d=google.com; s=arc-20160816; b=pv1s5IITbo/mJWhqN7MCxzuBpyjPO49Byyn9w51oitWvy88BiifGiQjGeGj3SNZXHh qvQXauwRX3ebvpotBOn55aYSPAkNEJkPYSGWgN/yZA+dj5ICimYbR9lyXQyGZj2QImnj CYfbXLgkwYOfr8Hbm+7bGlTzuHSQzQjYGlxY8X+pQ7LNCpXvbWK/gvI1/MnU5jxKN54T n9UUbX3h+Uy8CPQZIwxYWpryPw8IXeChPWu4lQPy8JTV74cy2icwhYkIG4qIl/sQWCcR Q+URRFQ7NWOi2+ZDEmudpYwd0oZF4sboRcHNl2JMuScKyj2gL7xBWwpnZNnoWp/RTZul 1ZqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=h4hLigvdbOVO3P4ObAFFWRZdoPUgyggKpMDr+PVSErU=; b=jcB5EJeoyMku4CijwqQKzi3ioq5cOaaknakTGoHGAExmQUNFxZMq0cbi1MqOLKTiS4 s5sv7tDHI16GPZePfSeTg1Jh1iKawiN8dHW6QLwCTqhLWx/lK8lOA/l3P7hLs0s9vW2H inQh3wbRrOF0c824H+EEgI0litKX05spq+VieYyYAOpJ6VRxrIrWYI86i/vSfwWfBDWc E7tiozAoHIzYdVsJPap6ZZp8Bppjhe4yT3h3E1ZP8Yh9646Y7UZCFvZtC0qImTauZ/N1 lUJrbkBsyYgKZ4snWI3X2zHc0MeaBXTuqsfmow96oywwdNkoWaEC2vvE26B3CFHegMeZ 6srw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=ej0CFkiY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a170903024700b001a1dc236bdbsi15142705plh.539.2023.04.18.01.13.11; Tue, 18 Apr 2023 01:13:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=ej0CFkiY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230252AbjDRICT (ORCPT <rfc822;leviz.kernel.dev@gmail.com> + 99 others); Tue, 18 Apr 2023 04:02:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231445AbjDRIB6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 18 Apr 2023 04:01:58 -0400 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EBC9729D; Tue, 18 Apr 2023 01:01:28 -0700 (PDT) Received: from booty.fritz.box (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPA id CABDF240009; Tue, 18 Apr 2023 08:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681804886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h4hLigvdbOVO3P4ObAFFWRZdoPUgyggKpMDr+PVSErU=; b=ej0CFkiYcDlbNTe95lM4ZQRGtji1xCD/12axQgLoDUa2qIc82WGBOukcHlE/3ZY8oBXrMh ObGlJCM9Brxe2PHwcWvobDsxHSnqDX59DJqncnSrFqRpmybNbWHnRT82EaGKRXAF+n89P7 CDI+wklPwZXQbgzUqEGXXw4Wm3FP/Yv3y+NCxwtdN+XyLMPMm0+gT/UAwDhS6U/flobopr V339JsO2QSz9F63yt5MlwuIiTfGJwo8riWz3c0vFGa9hFnUS+cnzt04umaPEKOGKnrOCFT ykX3UJmAxbcVl+1mxB37LvrwBDncjM7vglk0aj+nvr+mNAVlzKVNOseAEEnS9g== From: Luca Ceresoli <luca.ceresoli@bootlin.com> To: linux-tegra@vger.kernel.org Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Sowjanya Komatineni <skomatineni@nvidia.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Richard Leitner <richard.leitner@skidata.com>, Dmitry Osipenko <digetx@gmail.com> Subject: [PATCH v6 06/20] staging: media: tegra-video: improve error messages Date: Tue, 18 Apr 2023 10:00:40 +0200 Message-Id: <20230418080054.452955-7-luca.ceresoli@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230418080054.452955-1-luca.ceresoli@bootlin.com> References: <20230418080054.452955-1-luca.ceresoli@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763500995953105279?= X-GMAIL-MSGID: =?utf-8?q?1763500995953105279?= |
Series |
Add Tegra20 parallel video input capture
|
|
Commit Message
Luca Ceresoli
April 18, 2023, 8 a.m. UTC
tegra_vi_channels_alloc() can primarily fail for two reasons: 1. "ports" node not found 2. port_num > vi->soc->vi_max_channels Case 1 prints nothing, case 2 has a dev_err(). The caller [tegra_vi_init()] has a generic dev_err() on any failure. This mean that in case 2 we print two messages, and in case 1 we only print a generic message. Remove the generic message and add a specific message when case 1 happens, so that we always have one specific message without even increasing the number of dev_dbg*() calls. Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Reviewed-by: Dmitry Osipenko <digetx@gmail.com> --- No changes in v6 No changes in v5 Changed in v4: - Added review tags No changes in v3 No changes in v2 --- drivers/staging/media/tegra-video/vi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c index 79dd02a1e29b..1c0424bf1ab0 100644 --- a/drivers/staging/media/tegra-video/vi.c +++ b/drivers/staging/media/tegra-video/vi.c @@ -1361,7 +1361,7 @@ static int tegra_vi_channels_alloc(struct tegra_vi *vi) ports = of_get_child_by_name(node, "ports"); if (!ports) - return -ENODEV; + return dev_err_probe(vi->dev, -ENODEV, "%pOF: missing 'ports' node\n", node); for_each_child_of_node(ports, port) { if (!of_node_name_eq(port, "port")) @@ -1921,11 +1921,8 @@ static int tegra_vi_init(struct host1x_client *client) ret = tegra_vi_tpg_channels_alloc(vi); else ret = tegra_vi_channels_alloc(vi); - if (ret < 0) { - dev_err(vi->dev, - "failed to allocate vi channels: %d\n", ret); + if (ret < 0) goto free_chans; - } ret = tegra_vi_channels_init(vi); if (ret < 0)