From patchwork Tue Apr 18 03:18:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Changbin Du X-Patchwork-Id: 84564 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2553333vqo; Mon, 17 Apr 2023 20:21:59 -0700 (PDT) X-Google-Smtp-Source: AKy350a03oUpH1tI3LNhwlbb8II4eN+TJgbNiWk9RK3R7VmAZ5dSGs53uMtNEadACgFYUCQKdtUF X-Received: by 2002:a17:902:d503:b0:1a6:87d8:b8fb with SMTP id b3-20020a170902d50300b001a687d8b8fbmr838344plg.2.1681788119654; Mon, 17 Apr 2023 20:21:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681788119; cv=none; d=google.com; s=arc-20160816; b=c1p69YAY+8dkAMHQwqefmuMMVAI9hQV8z5IbCZB+O5B61d6nb5OAbmop4AwOr4ADlu 424VIJeEdVxN9TR5VR/lnNKLn8oU/nfxuRD3Vtz/mfcz9Tvbp0lw26rrOVgBqyFFBmEE mI9HOX/b2wkYL7Mz416qoCJ1KvjLtBzTmxPgJUnJhHTdeXIQGq4pfSszGUKP7tVw1LXr CunQUBF0M9Hx3zsfA2l2z5MhS4Gz5B1zj+DXaaiOK9l6+jTxReo9SOud7fUZFyT3EYZ8 hDNKInCQdafvjNCOCYWimlfihohrmD8qpWNpAKgKPL4ZCpdm55G1ACnFQ2/w0gZx+Qag dB4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=vshH/S7a4mKC4iS/0QUxbjARWUBBLZDLQUXrjil1ofI=; b=QBAmpYKaXOSZGxmmndfYJNyEUB4Dq00ZJoZXEX4oM21ti7Q2cm+VuUAe7IXYnffx8k RaA6rTfb6zo170TVfh+g8Xf+JjT8PQEAXMd6BFV/giNlfNlu9YKHgIq6+DVqV1dxMDM6 PDnbJJGm1nXhUyPuHz33txooerqldUAQfiaypIopJYzJBGyVqLbSy7oeVmH6xemeY+8s sTWWO1CZzT+FWbGK2xlEuS1fDVuPuwuLDoouV+o7wqoyQ7tdlGR/hvZblNSCHViZHZ9c o/fPMrNA/B+5bK+zYr0doRjYaQBC8dXevMgafc19vi+S1o+d7MEOYcZR7pZ342VNxq7S J9ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c1-20020a170902b68100b0019cd86735f1si12231152pls.481.2023.04.17.20.21.47; Mon, 17 Apr 2023 20:21:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230285AbjDRDTD (ORCPT + 99 others); Mon, 17 Apr 2023 23:19:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230170AbjDRDSu (ORCPT ); Mon, 17 Apr 2023 23:18:50 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C2EB59DF; Mon, 17 Apr 2023 20:18:48 -0700 (PDT) Received: from kwepemi500013.china.huawei.com (unknown [7.221.188.120]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Q0pyX3K6xzKs83; Tue, 18 Apr 2023 11:17:56 +0800 (CST) Received: from M910t.huawei.com (10.110.54.157) by kwepemi500013.china.huawei.com (7.221.188.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 18 Apr 2023 11:18:45 +0800 From: Changbin Du To: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar CC: Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , , , Hui Wang , Changbin Du Subject: [PATCH v5 1/3] perf script: print raw ip instead of binary offset for callchain Date: Tue, 18 Apr 2023 11:18:23 +0800 Message-ID: <20230418031825.1262579-2-changbin.du@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230418031825.1262579-1-changbin.du@huawei.com> References: <20230418031825.1262579-1-changbin.du@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.110.54.157] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500013.china.huawei.com (7.221.188.120) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763482659670836139?= X-GMAIL-MSGID: =?utf-8?q?1763482659670836139?= Before this, the raw ip is printed for non-callchain and dso offset for callchain. This inconsistent output for address may confuse people. And mostly what we expect is the raw ip. 'dso offset' is printed in callchain: $ perf script ... ls 1341034 2739463.008343: 2162417 cycles: ffffffff99d657a7 [unknown] ([unknown]) ffffffff99e00b67 [unknown] ([unknown]) 235d3 memset+0x53 (/usr/lib/x86_64-linux-gnu/ld-2.31.so) # dso offset a61b _dl_map_object+0x1bb (/usr/lib/x86_64-linux-gnu/ld-2.31.so) raw ip is printed for non-callchain: $ perf script -G ... ls 1341034 2739463.008876: 2053304 cycles: ffffffffc1596923 [unknown] ([unknown]) ls 1341034 2739463.009381: 1917049 cycles: 14def8e149e6 __strcoll_l+0xd96 (/usr/lib/x86_64-linux-gnu/libc-2.31.so) # raw ip Let's have consistent output for it. Later I'll add a new field 'dsoff' to print dso offset. Signed-off-by: Changbin Du Acked-by: Adrian Hunter --- tools/perf/util/evsel_fprintf.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c index a09ac00810b7..cc80ec554c0a 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools/perf/util/evsel_fprintf.c @@ -153,13 +153,8 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, if (map) addr = map__map_ip(map, node->ip); - if (print_ip) { - /* Show binary offset for userspace addr */ - if (map && !map__dso(map)->kernel) - printed += fprintf(fp, "%c%16" PRIx64, s, addr); - else - printed += fprintf(fp, "%c%16" PRIx64, s, node->ip); - } + if (print_ip) + printed += fprintf(fp, "%c%16" PRIx64, s, node->ip); if (print_sym) { printed += fprintf(fp, " ");