Message ID | 20230418-dpu-drop-useless-for-lookup-v2-1-acb08e82ef19@somainline.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1336185vqo; Fri, 21 Apr 2023 13:55:17 -0700 (PDT) X-Google-Smtp-Source: AKy350YIBPdwrXZibtJT73v/DArZSWjJdIXTKvedYb+w8g1h/SxoqckNDObwn1xwfFBu4YV2784U X-Received: by 2002:a17:902:fa87:b0:19a:9890:eac6 with SMTP id lc7-20020a170902fa8700b0019a9890eac6mr5802810plb.24.1682110517149; Fri, 21 Apr 2023 13:55:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682110517; cv=none; d=google.com; s=arc-20160816; b=lEwVQBSFFroSvwztfRQZyOBVvL9TcTYUphXs0sWY4QJGlcTQT4v9Hv1nQX+Y4+Uzh3 34OHj8P4wcN6kRCzHxnpKJDrwu6KpbgsJJD1AH7MV98arTmRzi8HPk7Qshi/kBSVpXiW GAnaD2sWIehM9CTZkX6z5j35qpnH35WOXeZa9Htl912+i9o0pG2SQqlXhf/zPgmAheUV FSJIp/XoeSlc7pMKIb4hWRpS/x+269So10DFNVNRuQQqF9mXhbnz/a6xUQTSdPlTGzgC f8PPXaXl4XUoGtStogt41UnQmf7u1Zlle32YXvqJeK8dm8vfFQ7tMEYM0VjsMnA2dWZh i9DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from; bh=ytbD1cziV9lhLDiKNujfIOe8WKRVezFG5TBAiP3vI04=; b=LbKN4b7HBCln6E9SRiZOdAbLwJc66oVA5rUViWAHT3X17ueJQxCVqO1mmlWyOaMBiD Sce0m/IfNPn0ljXNgSVos44C/ZAykORWluHzTnm8EDTwvXc2xQ2MScUr+Sg96DJsgJd5 apkmJAR7zpiWHHgIwDtceBv3bHHSDwcZTH9jxkPjq4XxrvSQ3tEc7nT1SpJwfbzLHsZl Xj2Q9gPZBvyBmCgZZiMUsPastE30+bU+gl2KGeZ5WvHGnoVbAMlyEDNmyv4onn9WxtYr VlyQIefoub3QEQL+yp3bdljcGeVPJ0lLjJA6gogNrn6ZGbB2yQCRb5uJh4fTn0yFdQmd X5/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o1-20020a170902778100b0019d20f7db09si5025688pll.597.2023.04.21.13.55.05; Fri, 21 Apr 2023 13:55:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232357AbjDUUyK (ORCPT <rfc822;cjcooper78@gmail.com> + 99 others); Fri, 21 Apr 2023 16:54:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229891AbjDUUyG (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Apr 2023 16:54:06 -0400 Received: from relay08.th.seeweb.it (relay08.th.seeweb.it [5.144.164.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06A9E1FD5 for <linux-kernel@vger.kernel.org>; Fri, 21 Apr 2023 13:54:03 -0700 (PDT) Received: from Marijn-Arch-PC.localdomain (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 670CB3F5C0; Fri, 21 Apr 2023 22:54:00 +0200 (CEST) From: Marijn Suijten <marijn.suijten@somainline.org> Date: Fri, 21 Apr 2023 22:53:51 +0200 Subject: [PATCH v2 1/3] drm/msm/dpu: Assign missing writeback log_mask MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230418-dpu-drop-useless-for-lookup-v2-1-acb08e82ef19@somainline.org> References: <20230418-dpu-drop-useless-for-lookup-v2-0-acb08e82ef19@somainline.org> In-Reply-To: <20230418-dpu-drop-useless-for-lookup-v2-0-acb08e82ef19@somainline.org> To: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Martin Botka <martin.botka@somainline.org>, Jami Kettunen <jami.kettunen@somainline.org>, Jordan Crouse <jordan@cosmicpenguin.net>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Marijn Suijten <marijn.suijten@somainline.org> X-Mailer: b4 0.12.2 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763820717691659076?= X-GMAIL-MSGID: =?utf-8?q?1763820717691659076?= |
Series |
drm/msm/dpu: Drop useless for-loop HW block lookup
|
|
Commit Message
Marijn Suijten
April 21, 2023, 8:53 p.m. UTC
The WB debug log mask ended up never being assigned, leading to writes to this block to never be logged even if the mask is enabled in dpu_hw_util_log_mask via debugfs. Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks") Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c index 2d28afdf860ef..a3e413d277175 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c @@ -61,6 +61,7 @@ static const struct dpu_wb_cfg *_wb_offset(enum dpu_wb wb, for (i = 0; i < m->wb_count; i++) { if (wb == m->wb[i].id) { b->blk_addr = addr + m->wb[i].base; + b->log_mask = DPU_DBG_MASK_WB; return &m->wb[i]; } }