From patchwork Mon Apr 17 21:02:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 84463 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2403740vqo; Mon, 17 Apr 2023 14:09:39 -0700 (PDT) X-Google-Smtp-Source: AKy350YpfqnBxmynd9ubNcPZcqrhaV6n87jY5nhSYYfa6QDstk6rfdTx/mCk/ajeh0GZM3jgPXzy X-Received: by 2002:a17:90b:46d5:b0:23f:2661:f94c with SMTP id jx21-20020a17090b46d500b0023f2661f94cmr16263874pjb.47.1681765779189; Mon, 17 Apr 2023 14:09:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681765779; cv=none; d=google.com; s=arc-20160816; b=lRn8DZToFn5+iSaN/znpAigb7m5rbFufH6Mvq/aGf22ZJxIuFZx7n8GC0rqbBPzhGq eE48BES8AeBdDjfp7KgkMcIo3/mZeggLpNYut82mwVTXia00+HLKf2InC63fo+aQOngX pqEBLZVsoSI8dNG87zmmSO3ksaBzDmfAQMPfUu8swHjtGvq9i8ce3O2q9wo4OnH3rRV6 /2jqRWOytpKdaHaOaF6F6R+xBF3Q/U9gnDRF0LfvVkK0xU7TT5v5vMLBnQzcevrBxdfq WcGANEn6NE16/qgYZMp6WQwWzUii5S6TkabdyFt+SMGA/QNHz9O5PNa1yPs2hSCmDc/l FQ9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QSW9WEBPhRehuRB9DtZAgKlY1x5GoyfP6pK9Yzn/Mn8=; b=icZ8P7c/VxnLDL1FHT5fE42qL8wMypLV+dETHu/TMRQ8AaZIrBe7mNEuRMdxQbYjKm 8BUNhB4Fp7WJKVyXWM479gp5MMUMfWRhvSwOCJZQnvfsarmC0Hpmtn+2bgEj14g+hrs6 ZAfUYl2lFVWvX5cyahb3zbBf8XPMbwnOlG6e0vd3WR5T0hylNJiajx/7cnYnQ6Gey/Zi hJ/3OtvWCpn0LyA87E1eTtwPlnB+r9YAzhDdAE+OBBMD7EjvLPpT6ccZ5pOALi86snsn Cg/oyMJt3C4Vp2pp7ie7W9VWyOSIaDJVaiH8I345kTRekUwE0Y6OMaY9a290/6M7ZrdT FCVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MpAkNO0k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pi19-20020a17090b1e5300b002477ddfa2f3si5624038pjb.182.2023.04.17.14.09.27; Mon, 17 Apr 2023 14:09:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MpAkNO0k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbjDQVDK (ORCPT + 99 others); Mon, 17 Apr 2023 17:03:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230347AbjDQVCz (ORCPT ); Mon, 17 Apr 2023 17:02:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFE6A7AA4 for ; Mon, 17 Apr 2023 14:02:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4CDAF62A85 for ; Mon, 17 Apr 2023 21:02:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4189DC4339B; Mon, 17 Apr 2023 21:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681765339; bh=M+0Wkonx6xgqnpncRO7OGIWleTNT95JSdoH0jUPeOZ4=; h=From:To:Cc:Subject:Date:From; b=MpAkNO0krwEsoJPAt7dNl0COD7+wh03WF2d3c1EKXmjLKM6OZnBMcSPbqYKub1jR7 hLsZp9CBdvceZrM2gfDGyMn9PkVoXBAL79G6J7/YShxy9ffLlPz804Z+P1rbTnR6ON lVAuh9boHMbLX0yd7BASNMdQ/UoeAigySsBqyZpCcHYQXBP4ght0vdteUdZk65f2Yn nAzuq70pEK34nvCo/eIP5nTE2nuy0HdxCLQfbNdZ2JZBgLX6A9YuSWdR3RhBEHQPhF 7wSvaXvV+60Ho5gRttq68P2dag6QhODix4Fwf3XeCFMSCO2y5qiXGWRa8RGDfaO7fU Bees4prCuY2WQ== From: Arnd Bergmann To: Lee Jones Cc: Daniel Thompson , Jingoo Han , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [PATCH] backlight: corgi_lcd: fix missing prototype Date: Mon, 17 Apr 2023 23:02:13 +0200 Message-Id: <20230417210213.2385912-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763459233480020122?= X-GMAIL-MSGID: =?utf-8?q?1763459233480020122?= From: Arnd Bergmann The corgi_lcd_limit_intensity() function is called from platform and defined in a driver, but the driver does not see the declaration: drivers/video/backlight/corgi_lcd.c:434:6: error: no previous prototype for 'corgi_lcd_limit_intensity' [-Werror=missing-prototypes] 434 | void corgi_lcd_limit_intensity(int limit) Move the prototype into a header that can be included from both sides to shut up the warning. Signed-off-by: Arnd Bergmann Reviewed-by: Daniel Thompson --- arch/arm/mach-pxa/sharpsl_pm.h | 1 - arch/arm/mach-pxa/spitz_pm.c | 1 + include/linux/spi/corgi_lcd.h | 2 ++ 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-pxa/sharpsl_pm.h b/arch/arm/mach-pxa/sharpsl_pm.h index 9429900db0bb..eff9a74e787f 100644 --- a/arch/arm/mach-pxa/sharpsl_pm.h +++ b/arch/arm/mach-pxa/sharpsl_pm.h @@ -105,5 +105,4 @@ void sharpsl_pm_led(int val); #define MAX1111_ACIN_VOLT 6u int sharpsl_pm_pxa_read_max1111(int channel); -void corgi_lcd_limit_intensity(int limit); #endif diff --git a/arch/arm/mach-pxa/spitz_pm.c b/arch/arm/mach-pxa/spitz_pm.c index c783696e13b9..9571f2b5b118 100644 --- a/arch/arm/mach-pxa/spitz_pm.c +++ b/arch/arm/mach-pxa/spitz_pm.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include diff --git a/include/linux/spi/corgi_lcd.h b/include/linux/spi/corgi_lcd.h index 0b857616919c..fc6c1515dc54 100644 --- a/include/linux/spi/corgi_lcd.h +++ b/include/linux/spi/corgi_lcd.h @@ -15,4 +15,6 @@ struct corgi_lcd_platform_data { void (*kick_battery)(void); }; +void corgi_lcd_limit_intensity(int limit); + #endif /* __LINUX_SPI_CORGI_LCD_H */