| Message ID | 20230417133308.1990057-1-kamlesh@ti.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2146510vqo;
Mon, 17 Apr 2023 07:00:51 -0700 (PDT)
X-Google-Smtp-Source:
AKy350Z7WLFVzUxpyrg5Swjwt5xRoxft4N6yOuw4nlABWPOLDfQ4HTGZD8djbDz6AFYbRlWXcIcs
X-Received: by 2002:a05:6a00:10c7:b0:5a8:a0df:a624 with SMTP id
d7-20020a056a0010c700b005a8a0dfa624mr20701134pfu.22.1681740050578;
Mon, 17 Apr 2023 07:00:50 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1681740050; cv=none;
d=google.com; s=arc-20160816;
b=Ap2A2I/ESbuyKCPVGcWLsfSiwjnnMOqSFXNUi/pl7dRgj7kS3bjIJz8X0INd1TZAIZ
TSz564/0NKiwRG4gDs/U3yOmA/GB3XkNbahjDCW0woVNTnrll8Q2pi0XiVLlzOspEKaf
veYAfFJmh3bMhISt8Wwo1h2v4akAGGNNJ6PKbOHulJgUv7QvMH9/7uJr2kjUUr3nl6Cr
3lXokhH//JXTckCaLfCSlAU2O4aNhK0GaHNbgCbDupdvcSFfEFcgJlZ6MMc5qVZAU8BE
rNkuOya1nKBY355lOIBEc2Ak+53CcVmlQ9dlDp50KeaOjS9A/DyFOFXWmWqPzIErD6PC
EwOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=5j+thoOyIbYVeZd46Hj2i9qA/56u4rW+5ESCXPcuJzM=;
b=JU/pb7C0ewLdeajQH1UXB7810uDLmghozaIrRcrcTz3q3kdEbt7iJoYeNdqx7iYXA6
wi+15glBDbvDB8D+X59FuX/z5OQNSkIyR9xgFLh5laao2+s5SJ0WQj+kyFoufn2Jnq/I
UlHxmtZXNAXWU1azkjEPMDNMRHGL498wjBc0tla1y7JHXhwG1ka+1NdvuawlZFg3P+Sl
KPqvJvcaH66ZJLVSwquhIdwOR7Z8XnydeKrtUrX+aNRpABwvW8IaDNPQ423cwDnB06gN
uDGguC2jI+6P6dSpgXME5oPCtYJijOsfrRg6Kz/DMj25wvZwkV9M0/ADHeljSxO1t4PF
lWGQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=qZHi3StG;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
a3-20020aa794a3000000b0063d2c3e897bsi911831pfl.202.2023.04.17.07.00.31;
Mon, 17 Apr 2023 07:00:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=qZHi3StG;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230283AbjDQNdz (ORCPT <rfc822;leviz.kernel.dev@gmail.com>
+ 99 others); Mon, 17 Apr 2023 09:33:55 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60138 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229876AbjDQNdx (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 17 Apr 2023 09:33:53 -0400
Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88D994EDD;
Mon, 17 Apr 2023 06:33:20 -0700 (PDT)
Received: from fllv0034.itg.ti.com ([10.64.40.246])
by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33HDXCHk003323;
Mon, 17 Apr 2023 08:33:12 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
s=ti-com-17Q1; t=1681738392;
bh=5j+thoOyIbYVeZd46Hj2i9qA/56u4rW+5ESCXPcuJzM=;
h=From:To:CC:Subject:Date;
b=qZHi3StGSy6DZUTeRopY8C1eU4V/8ofPzcCYVxMjk9VnPZCuLzZ+DjqZXupl51s1a
qzlGzME3YSzpCXkqRSDuxSrFrvVqeLC8ri+e0ny9eAd1MXi+rFPwjLixjPYpjcE2ZN
V7VlaKWZFJTzKwWIOoL/PKZp+XXQJ+X5jN687qHw=
Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35])
by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33HDXCGl078599
(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
Mon, 17 Apr 2023 08:33:12 -0500
Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE114.ent.ti.com
(10.64.6.35) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 17
Apr 2023 08:33:11 -0500
Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE111.ent.ti.com
(10.64.6.32) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via
Frontend Transport; Mon, 17 Apr 2023 08:33:11 -0500
Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6])
by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33HDXBhj104012;
Mon, 17 Apr 2023 08:33:11 -0500
From: <kamlesh@ti.com>
To: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>
CC: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Kamlesh Gurudasani <kamlesh@ti.com>
Subject: [PATCH] arm64: dts: ti: k3-am62-main: Remove power-domains from
crypto node
Date: Mon, 17 Apr 2023 19:03:08 +0530
Message-ID: <20230417133308.1990057-1-kamlesh@ti.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
SPF_HELO_PASS,SPF_PASS,TVD_SUBJ_WIPE_DEBT,T_SCC_BODY_TEXT_LINE
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1763432088294035521?=
X-GMAIL-MSGID: =?utf-8?q?1763432254620409621?=
|
| Series |
arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node
|
|
Commit Message
Kamlesh Gurudasani
April 17, 2023, 1:33 p.m. UTC
From: Kamlesh Gurudasani <kamlesh@ti.com> With latest firmware update, we can no longer control power of SA3UL from main domain. Remove power-domains property from the crypto node. Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com> --- arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 - 1 file changed, 1 deletion(-)
Comments
On Mon, Apr 17, 2023 at 08:42:41AM -0500, Nishanth Menon wrote: > On 19:03-20230417, kamlesh@ti.com wrote: > > From: Kamlesh Gurudasani <kamlesh@ti.com> > > > > With latest firmware update, we can no longer control power of SA3UL from > > main domain. > > How is this backward compatible? I just stumbled across this commit since I had an issue with crypto@40900000 not being probed on Verdin AM62. Not sure how this is supposed to work about backward/forward compatibility, however this is needed for having it working with the latest firmware. And if there is a proper way that take care of this, it should be backported IMO. Francesco
On 25/05/23 8:14 pm, Francesco Dolcini wrote: > On Mon, Apr 17, 2023 at 08:42:41AM -0500, Nishanth Menon wrote: >> On 19:03-20230417, kamlesh@ti.com wrote: >>> From: Kamlesh Gurudasani <kamlesh@ti.com> >>> >>> With latest firmware update, we can no longer control power of SA3UL from >>> main domain. >> >> How is this backward compatible? > > I just stumbled across this commit since I had an issue with crypto@40900000 > not being probed on Verdin AM62. > > Not sure how this is supposed to work about backward/forward > compatibility, however this is needed for having it working with the > latest firmware. > From what I understand, newer firmware seems to hate SA3UL PD control requests. But older firmwares just ignored the call as the SA3UL PD is on by default. So as such, this DT patch alone wont break forward/backward compatibility. It looks like newer firmware is broken wrt older kernel which is unfortunate. Kamlesh: can you resubmit this patch with appropriate "Fixes" tag so that it gets backported to stable kernels? > And if there is a proper way that take care of this, it should be > backported IMO. > > Francesco >
diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi index b3e4857bbbe4..18a6e9ffaf58 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi @@ -174,7 +174,6 @@ k3_reset: reset-controller { crypto: crypto@40900000 { compatible = "ti,am62-sa3ul"; reg = <0x00 0x40900000 0x00 0x1200>; - power-domains = <&k3_pds 70 TI_SCI_PD_SHARED>; #address-cells = <2>; #size-cells = <2>; ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;