diff mbox series

arm64: dts: mt8173: Power on panel regulator on boot

Message ID 20230417123956.926266-1-treapking@chromium.org
State New
Headers
Series arm64: dts: mt8173: Power on panel regulator on boot |

Commit Message

Pin-yen Lin April 17, 2023, 12:39 p.m. UTC 
  Add "regulator-boot-on" to "panel_fixed_3v3" to save time on powering
the regulator during boot.  Also add "off-on-delay-us" to the node to
make sure the regulator never violates the panel timing requirements.

Signed-off-by: Pin-yen Lin <treapking@chromium.org>

---

 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Doug Anderson April 17, 2023, 1:32 p.m. UTC | #1 
Hi,

On Mon, Apr 17, 2023 at 5:40 AM Pin-yen Lin <treapking@chromium.org> wrote:
>
> Add "regulator-boot-on" to "panel_fixed_3v3" to save time on powering
> the regulator during boot.  Also add "off-on-delay-us" to the node to
> make sure the regulator never violates the panel timing requirements.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
>
> ---
>
>  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Pin-yen Lin May 26, 2023, 6:14 a.m. UTC | #2 
Friendly ping on this patch.

Pin-yen

On Mon, Apr 17, 2023 at 9:32 PM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Mon, Apr 17, 2023 at 5:40 AM Pin-yen Lin <treapking@chromium.org> wrote:
> >
> > Add "regulator-boot-on" to "panel_fixed_3v3" to save time on powering
> > the regulator during boot.  Also add "off-on-delay-us" to the node to
> > make sure the regulator never violates the panel timing requirements.
> >
> > Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> >
> > ---
> >
> >  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Matthias Brugger May 29, 2023, 4:16 p.m. UTC | #3 
On 17/04/2023 14:39, Pin-yen Lin wrote:
> Add "regulator-boot-on" to "panel_fixed_3v3" to save time on powering
> the regulator during boot.  Also add "off-on-delay-us" to the node to
> make sure the regulator never violates the panel timing requirements.
> 
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> 

Applied, thanks!

> ---
> 
>   arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index d77f6af19065..03d1ab2ca820 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -96,6 +96,8 @@ panel_fixed_3v3: regulator1 {
>   		regulator-min-microvolt = <3300000>;
>   		regulator-max-microvolt = <3300000>;
>   		enable-active-high;
> +		regulator-boot-on;
> +		off-on-delay-us = <500000>;
>   		gpio = <&pio 41 GPIO_ACTIVE_HIGH>;
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&panel_fixed_pins>;
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index d77f6af19065..03d1ab2ca820 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -96,6 +96,8 @@  panel_fixed_3v3: regulator1 {
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		enable-active-high;
+		regulator-boot-on;
+		off-on-delay-us = <500000>;
 		gpio = <&pio 41 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&panel_fixed_pins>;