From patchwork Mon Apr 17 12:25:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yang X-Patchwork-Id: 84209 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2101081vqo; Mon, 17 Apr 2023 05:53:59 -0700 (PDT) X-Google-Smtp-Source: AKy350alxj6nCHg4YgICaLbaZ8Jc8TSmF2c+g7PWKFBHa0/xU4myr361489Eib5hEThTSQIASRlB X-Received: by 2002:a05:6a00:1709:b0:63b:5496:7af1 with SMTP id h9-20020a056a00170900b0063b54967af1mr19396355pfc.33.1681736039412; Mon, 17 Apr 2023 05:53:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681736039; cv=none; d=google.com; s=arc-20160816; b=g/sQGt8g5QblypJEgbhnF0WqQvfWVwSkBprUoxv/A0PlRMGchwvwcfWgnaOJb/Mr/w /GNy5xc1fFdEJxdOvWl+yOk/5lXdMYDPm8DufbqoCRlKbL0hmdcc2BJE8GSZknEnlNm2 8DOJkGLC/nD2zQPKA1pwZoJN5L47xCuDh3x6nuylUXwoBeiF0jDKho40LFhqk1Ow7Hzr G5po8AVAARS6/9c8C1GWB282AvFKYI/KthqmypbTKcSqRv858DimaGVIMNSkeOnrxArp alAY10VByKk2klOsNwsngmXxGG9bWFdx/cmoX8AI4HxEA1zrhDXSuF42VUrTgdvfsy4A jqvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Rxq4Yk/LgNkx+XnYXVz8UGjTQQyJ6Cw2OUnIbfmIBLE=; b=MFKBbRfw7RGuGbV9olz/7XOF3F3/2yNb6dI/Xy7vroOyDHAf9vjZfs80faIkoh1gcS UokxX/xaW+yeahqnZohQOEBVjQEt8oE7VRaJYuMvDVEf+NE9mQhkzCOfBhuqrNABpY0h abQWkI+BkbRdP4etjaazLCyYT18QOrg8PvNv2CSxVjgjXr+oPmkzapiUZzY7ni0YuPWv xifFVtSnZOChIcUyKHJ584JMUSpXNvKEF6bX305b7IoxkagPeRQtEZN0Q+BbgXvhwXio 91oeJyFzzU/hHFSgxR24U87Tpvik3F3l5YCEhr+4S1soi02HBDdg75ml2ECAOZJPmfcH MVSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z7-20020aa79587000000b0063b87539e44si4848730pfj.399.2023.04.17.05.53.46; Mon, 17 Apr 2023 05:53:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231191AbjDQMkm (ORCPT + 99 others); Mon, 17 Apr 2023 08:40:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231200AbjDQMkb (ORCPT ); Mon, 17 Apr 2023 08:40:31 -0400 Received: from ubuntu20 (unknown [193.203.214.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC0AB5267; Mon, 17 Apr 2023 05:40:29 -0700 (PDT) Received: by ubuntu20 (Postfix, from userid 1003) id 21913E1A83; Mon, 17 Apr 2023 12:25:05 +0000 (UTC) From: Yang Yang To: davem@davemloft.net, edumazet@google.com, willemdebruijn.kernel@gmail.com Cc: yang.yang29@zte.com.cn, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, shuah@kernel.org, zhang.yunkai@zte.com.cn, xu.xin16@zte.com.cn, Xuexin Jiang Subject: [PATCH linux-next 3/3] selftests: net: udpgso_bench_rx: Fix packet number exceptions Date: Mon, 17 Apr 2023 20:25:04 +0800 Message-Id: <20230417122504.193350-1-yang.yang29@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <202304172017351308785@zte.com.cn> References: <202304172017351308785@zte.com.cn> MIME-Version: 1.0 X-Spam-Status: No, score=3.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FSL_HELO_NON_FQDN_1, HEADER_FROM_DIFFERENT_DOMAINS,HELO_NO_DOMAIN,NO_DNS_FOR_FROM, RCVD_IN_PBL,RDNS_NONE,SPF_SOFTFAIL,SPOOFED_FREEMAIL_NO_RDNS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763428049272271360?= X-GMAIL-MSGID: =?utf-8?q?1763428049272271360?= From: Zhang Yunkai (CGEL ZTE) The -n parameter is confusing and seems to only affect the frequency of determining whether the time reaches 1s. However, the final print of the program is the number of messages expected to be received, which is always 0. bash# udpgso_bench_rx -4 -n 100 bash# udpgso_bench_tx -l 1 -4 -D "$DST" udpgso_bench_rx: wrong packet number! got 0, expected 100 This is because the packets are always cleared after print. Signed-off-by: Zhang Yunkai (CGEL ZTE) Reviewed-by: xu xin (CGEL ZTE) Reviewed-by: Yang Yang (CGEL ZTE) Cc: Xuexin Jiang (CGEL ZTE) --- tools/testing/selftests/net/udpgso_bench_rx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/udpgso_bench_rx.c b/tools/testing/selftests/net/udpgso_bench_rx.c index 784e88b31f7d..b66bb53af19f 100644 --- a/tools/testing/selftests/net/udpgso_bench_rx.c +++ b/tools/testing/selftests/net/udpgso_bench_rx.c @@ -50,7 +50,7 @@ static int cfg_rcv_timeout_ms; static struct sockaddr_storage cfg_bind_addr; static bool interrupted; -static unsigned long packets, bytes; +static unsigned long packets, total_packets, bytes; static void sigint_handler(int signum) { @@ -405,6 +405,7 @@ static void do_recv(void) "%s rx: %6lu MB/s %8lu calls/s\n", cfg_tcp ? "tcp" : "udp", bytes >> 20, packets); + total_packets += packets; bytes = packets = 0; treport = tnow + 1000; } @@ -415,7 +416,7 @@ static void do_recv(void) if (cfg_expected_pkt_nr && (packets != cfg_expected_pkt_nr)) error(1, 0, "wrong packet number! got %ld, expected %d\n", - packets, cfg_expected_pkt_nr); + total_packets + packets, cfg_expected_pkt_nr); if (close(fd)) error(1, errno, "close");