From patchwork Mon Apr 17 10:47:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 84164 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2029151vqo; Mon, 17 Apr 2023 03:59:38 -0700 (PDT) X-Google-Smtp-Source: AKy350ZLTa9otG6GVhPt6fj/AhQKX/NpDJerMDCYWrIqrOemgXh1iFvV8qkEP4FwmNlr7cxb5fSl X-Received: by 2002:a05:6a21:3393:b0:ec:5eb2:a2bb with SMTP id yy19-20020a056a21339300b000ec5eb2a2bbmr18716127pzb.61.1681729178638; Mon, 17 Apr 2023 03:59:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681729178; cv=none; d=google.com; s=arc-20160816; b=F073+F8bqmh+crxLFWgpv0/ypPwMWZy/GERY82azGNFedlPKjZMlnrlD1Bg02ylKtp msVzgq/Yse1q0TZJ52fl5c5ElK7/ZPi4RqHmlbuCVck3dkdBwvQcRkndf7sXC2ingeZO VaLVLbzY3vZr5A8SSXkSfF+enH8wgEZSc+GN16IVduwPUxYwB14uOHecfHh0sdI4tMwz Hess0fChH6kKsBJ4ouD3PuwpnRfeUMI2kwMI9Sg0c1jJj7CNDkq014sMk7+ykGKXVpOy A9JnVBEN3jZbLn1zBaaK/o8iNMWYVgVpYS61VdHGysfTLudXvMTN0VmKJBmZqz3uwryp qjHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=aObB3gJrc6daE2Ub3D70WFvZc+MAMO7dkXaerkKuI3s=; b=nhHLcR6j5Yc7uNNQgA0N8eF/Uiihkb8s1CFAMmpyv4UY7FYY/GhH78HA1GzImpwfXb yLb0y25nWzB6QcAX0JCpzOYKqitTsrCeKLp3cmJSxo8+eHHO0xjHTbjt1jC5GJ3Lh87Q ZRHQ01wNUJhDxNnBmrsBU9rpkC0mWR/gRuRELsxmJRHEqVzmKZhfoG1jqLU2aKJhwTQb 7+517os4RS8/NnhO+3tagZZdK/SefTu69jPxc319cTECaGEmQrA13nL6qIfBE7zClPu3 ARVRI9MQ4QNI7CJQ+Ki8VN9N2ApsUdqhukV+o/W5EULidHMQ9A8V8eEGIczHd3fJvbfV PBFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=RXtnXeZZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i12-20020a056a00004c00b0063b7f1ed115si5472484pfk.167.2023.04.17.03.59.24; Mon, 17 Apr 2023 03:59:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=RXtnXeZZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbjDQKuY (ORCPT + 99 others); Mon, 17 Apr 2023 06:50:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjDQKuX (ORCPT ); Mon, 17 Apr 2023 06:50:23 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A8E33A82; Mon, 17 Apr 2023 03:49:39 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-2f8405b3dc1so834728f8f.3; Mon, 17 Apr 2023 03:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681728465; x=1684320465; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aObB3gJrc6daE2Ub3D70WFvZc+MAMO7dkXaerkKuI3s=; b=RXtnXeZZXh+VYZJiHO88aK0CSgdCnLOoMdEuRCkY9HvdqoQOpy2yOdn2VbYysVhQEo Qp3qQWty1Awi//NPEO2vjwxvnTunFZEh9JGMiPRZUbbo91duK52ft167gIsvd4SoSAZP g2+UMw+9aEMMIuHjthxFdI4y/ffXjJtbbCHQaycZsrxO9XubnFo5FXbb92ZqW85yXFzT XYIZd0AAJkP+bCshzIFAZ5k0U5ek3spTLDa26+TcErtP1d2/KveQe5VcKXD4YClmjZpe CBhTG0XqkXen+uqzAifVeYjxEFJxVEVJ5f6nVylsLEJXv6u2KQehZmTwTVN7yC0Ayy3s cAJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681728465; x=1684320465; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aObB3gJrc6daE2Ub3D70WFvZc+MAMO7dkXaerkKuI3s=; b=elJqsQ0SpPyuu0zpbttoYly9NrPpRK8SzOJh9SU/pWth8FJELhnLGIn4qGmfK39+zm oy1CE1qIbb4vnH6ZrzWhFPdhZGwsacgBm/MNUDhRsOmm81yZPK+t6T9hHWfjp0JfXm7p wf6N4NuyfdkjufUkByFQIDsDb7YygVHUE7KwhO12QAM2E/EYvEQ9cw109I+KqUb62Lkm VUHqA8odmP+FnhBw0lXdBfXeb80l8owNPqIiOuU/YhhLh98ColNOvKDXUnhhN0wXluY7 3iM/kJofcflwsZn0EXs4mDwUtNN7PQfuyosD7uzDd2jEsnH7m0tUsKOKVrUktm1MqHPO lCSQ== X-Gm-Message-State: AAQBX9eA6lbuctPyrlcjybttNpmg/l9cbQyjSU2BBsfr3q4vwDSUib6R fehvYlDdXMJUPZ8lSbIQeug= X-Received: by 2002:adf:ce12:0:b0:2ef:b137:37fe with SMTP id p18-20020adfce12000000b002efb13737femr4862686wrn.0.1681728464622; Mon, 17 Apr 2023 03:47:44 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id v11-20020a5d43cb000000b002f490a0cd1asm10138510wrr.92.2023.04.17.03.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 03:47:44 -0700 (PDT) From: Colin Ian King To: Shuah Khan , Thomas Gleixner , Vincenzo Frascino , linux-kselftest@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] kselftest: vDSO: Fix accumulation of uninitialized ret when CLOCK_REALTIME is undefined Date: Mon, 17 Apr 2023 11:47:43 +0100 Message-Id: <20230417104743.30018-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763420854803327113?= X-GMAIL-MSGID: =?utf-8?q?1763420854803327113?= In the unlikely case that CLOCK_REALTIME is not defined, variable ret is not initialized and further accumulation of return values to ret can leave ret in an undefined state. Fix this by initialized ret to zero and changing the assignment of ret to an accumulation for the CLOCK_REALTIME case. Fixes: 03f55c7952c9 ("kselftest: Extend vDSO selftest to clock_getres") Signed-off-by: Colin Ian King Reviewed-by: Vincenzo Frascino --- tools/testing/selftests/vDSO/vdso_test_clock_getres.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/vDSO/vdso_test_clock_getres.c b/tools/testing/selftests/vDSO/vdso_test_clock_getres.c index 15dcee16ff72..38d46a8bf7cb 100644 --- a/tools/testing/selftests/vDSO/vdso_test_clock_getres.c +++ b/tools/testing/selftests/vDSO/vdso_test_clock_getres.c @@ -84,12 +84,12 @@ static inline int vdso_test_clock(unsigned int clock_id) int main(int argc, char **argv) { - int ret; + int ret = 0; #if _POSIX_TIMERS > 0 #ifdef CLOCK_REALTIME - ret = vdso_test_clock(CLOCK_REALTIME); + ret += vdso_test_clock(CLOCK_REALTIME); #endif #ifdef CLOCK_BOOTTIME