[1/3] dt-bindings: net: wireless: qcom,ath11k: allow describing radios
Commit Message
From: Rafał Miłecki <rafal@milecki.pl>
Qualcomm ath11k chipsets can have up to 3 radios. Each radio may need to
be additionally described by including its MAC or available frequency
ranges.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../bindings/net/wireless/qcom,ath11k.yaml | 26 +++++++++++++++++++
1 file changed, 26 insertions(+)
Comments
On Fri, 14 Apr 2023 23:23:54 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Qualcomm ath11k chipsets can have up to 3 radios. Each radio may need to
> be additionally described by including its MAC or available frequency
> ranges.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bindings/net/wireless/qcom,ath11k.yaml | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.example.dtb: wifi@c000000: radio@0: Unevaluated properties are not allowed ('reg' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.example.dtb: wifi@c000000: '#address-cells', '#size-cells' do not match any of the regexes: '^radio@[0-2]$', 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230414212356.9326-1-zajec5@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
@@ -78,6 +78,24 @@ properties:
items:
- const: wlan-smp2p-out
+patternProperties:
+ "^radio@[0-2]$":
+ type: object
+
+ allOf:
+ - $ref: ieee80211.yaml#
+
+ properties:
+ nvmem-cells:
+ items:
+ - description: NVMEM cell with the MAC address
+
+ nvmem-cell-names:
+ items:
+ - const: mac-address
+
+ unevaluatedProperties: false
+
required:
- compatible
- reg
@@ -378,6 +396,14 @@ examples:
"wbm2host-tx-completions-ring1",
"tcl2host-status-ring";
qcom,rproc = <&q6v5_wcss>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ radio@0 {
+ reg = <0x0>;
+ nvmem-cells = <&mac>;
+ nvmem-cell-names = "mac-address";
+ };
};
- |