diff mbox series

[V1,1/4] dt-bindings: clock: qcom,ipq9574-gcc: Drop the Bias PLL ubi clock source

Message ID 20230414134812.16812-2-quic_devipriy@quicinc.com
State New
Headers
Series Incremental patches on minimal boot support |

Commit Message

Devi Priya April 14, 2023, 1:48 p.m. UTC 
  Remove bias_pll_ubi_nc_clk from the binding as it has been removed from
the Device Tree. Also added Bjorn Andersson to the maintainers list.

Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
---
 Changes since V9:
	- Dropped the clock description for Bias PLL ubi clock source
	  to reflect the gcc node in the DT
	- Added Bjorn Andersson to the maintainers list

 Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Krzysztof Kozlowski April 14, 2023, 2:17 p.m. UTC | #1 
On 14/04/2023 15:48, Devi Priya wrote:
> Remove bias_pll_ubi_nc_clk from the binding as it has been removed from
> the Device Tree. Also added Bjorn Andersson to the maintainers list.

Was it really removed? Where?

> 
> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>


Best regards,
Krzysztof
Devi Priya April 14, 2023, 2:22 p.m. UTC | #2 
On 4/14/2023 7:47 PM, Krzysztof Kozlowski wrote:
> On 14/04/2023 15:48, Devi Priya wrote:
>> Remove bias_pll_ubi_nc_clk from the binding as it has been removed from
>> the Device Tree. Also added Bjorn Andersson to the maintainers list.
> 
> Was it really removed? Where?
> 
It has been removed from the Device tree and binding in V11
https://lore.kernel.org/linux-arm-msm/20230404101622.5394-1-quic_devipriy@quicinc.com/

Thanks,
Devi Priya
>>
>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
> 
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski April 14, 2023, 3:09 p.m. UTC | #3 
On 14/04/2023 16:22, Devi Priya wrote:
> 
> 
> On 4/14/2023 7:47 PM, Krzysztof Kozlowski wrote:
>> On 14/04/2023 15:48, Devi Priya wrote:
>>> Remove bias_pll_ubi_nc_clk from the binding as it has been removed from
>>> the Device Tree. Also added Bjorn Andersson to the maintainers list.
>>
>> Was it really removed? Where?
>>
> It has been removed from the Device tree and binding in V11
> https://lore.kernel.org/linux-arm-msm/20230404101622.5394-1-quic_devipriy@quicinc.com/

I still see it in current next. Are you sure you refer to something
already merged?

Best regards,
Krzysztof
Devi Priya April 14, 2023, 4:04 p.m. UTC | #4 
On 4/14/2023 8:39 PM, Krzysztof Kozlowski wrote:
> On 14/04/2023 16:22, Devi Priya wrote:
>>
>>
>> On 4/14/2023 7:47 PM, Krzysztof Kozlowski wrote:
>>> On 14/04/2023 15:48, Devi Priya wrote:
>>>> Remove bias_pll_ubi_nc_clk from the binding as it has been removed from
>>>> the Device Tree. Also added Bjorn Andersson to the maintainers list.
>>>
>>> Was it really removed? Where?
>>>
>> It has been removed from the Device tree and binding in V11
>> https://lore.kernel.org/linux-arm-msm/20230404101622.5394-1-quic_devipriy@quicinc.com/
> 
> I still see it in current next. Are you sure you refer to something
> already merged?

This change was made in V11 and Currently V9 is merged in linux-next.
So, the delta changes between V9 & V12 is posted in this series.
The device tree change where the clock is removed is added part of this 
incremental patch series and the binding is updated to reflect the same.
Apologies, if the confusion is because of "has been removed from device 
tree" in the commit message.

Thanks,
Devi Priya
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski April 14, 2023, 5:11 p.m. UTC | #5 
On 14/04/2023 18:04, Devi Priya wrote:
> 
> 
> On 4/14/2023 8:39 PM, Krzysztof Kozlowski wrote:
>> On 14/04/2023 16:22, Devi Priya wrote:
>>>
>>>
>>> On 4/14/2023 7:47 PM, Krzysztof Kozlowski wrote:
>>>> On 14/04/2023 15:48, Devi Priya wrote:
>>>>> Remove bias_pll_ubi_nc_clk from the binding as it has been removed from
>>>>> the Device Tree. Also added Bjorn Andersson to the maintainers list.
>>>>
>>>> Was it really removed? Where?
>>>>
>>> It has been removed from the Device tree and binding in V11
>>> https://lore.kernel.org/linux-arm-msm/20230404101622.5394-1-quic_devipriy@quicinc.com/
>>
>> I still see it in current next. Are you sure you refer to something
>> already merged?
> 
> This change was made in V11 and Currently V9 is merged in linux-next.
> So, the delta changes between V9 & V12 is posted in this series.
> The device tree change where the clock is removed is added part of this 
> incremental patch series and the binding is updated to reflect the same.
> Apologies, if the confusion is because of "has been removed from device 
> tree" in the commit message.

Your commit indicated that removal from DTS happened. If it did not
happen, you need to come with proper reason (and fix the tense not to
confuse).

Best regards,
Krzysztof
Devi Priya April 14, 2023, 5:31 p.m. UTC | #6 
On 4/14/2023 10:41 PM, Krzysztof Kozlowski wrote:
> On 14/04/2023 18:04, Devi Priya wrote:
>>
>>
>> On 4/14/2023 8:39 PM, Krzysztof Kozlowski wrote:
>>> On 14/04/2023 16:22, Devi Priya wrote:
>>>>
>>>>
>>>> On 4/14/2023 7:47 PM, Krzysztof Kozlowski wrote:
>>>>> On 14/04/2023 15:48, Devi Priya wrote:
>>>>>> Remove bias_pll_ubi_nc_clk from the binding as it has been removed from
>>>>>> the Device Tree. Also added Bjorn Andersson to the maintainers list.
>>>>>
>>>>> Was it really removed? Where?
>>>>>
>>>> It has been removed from the Device tree and binding in V11
>>>> https://lore.kernel.org/linux-arm-msm/20230404101622.5394-1-quic_devipriy@quicinc.com/
>>>
>>> I still see it in current next. Are you sure you refer to something
>>> already merged?
>>
>> This change was made in V11 and Currently V9 is merged in linux-next.
>> So, the delta changes between V9 & V12 is posted in this series.
>> The device tree change where the clock is removed is added part of this
>> incremental patch series and the binding is updated to reflect the same.
>> Apologies, if the confusion is because of "has been removed from device
>> tree" in the commit message.
> 
> Your commit indicated that removal from DTS happened. If it did not
> happen, you need to come with proper reason (and fix the tense not to
> confuse).
Got it, will update the commit message.

Thanks,
Devi Priya
> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml
index afc68eb9d7cc..8581de266750 100644
--- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-gcc.yaml
@@ -7,6 +7,7 @@  $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: Qualcomm Global Clock & Reset Controller on IPQ9574
 
 maintainers:
+  - Bjorn Andersson <andersson@kernel.org>
   - Anusha Rao <quic_anusha@quicinc.com>
 
 description: |
@@ -25,7 +26,6 @@  properties:
     items:
       - description: Board XO source
       - description: Sleep clock source
-      - description: Bias PLL ubi clock source
       - description: PCIE30 PHY0 pipe clock source
       - description: PCIE30 PHY1 pipe clock source
       - description: PCIE30 PHY2 pipe clock source
@@ -48,7 +48,6 @@  examples:
       reg = <0x01800000 0x80000>;
       clocks = <&xo_board_clk>,
                <&sleep_clk>,
-               <&bias_pll_ubi_nc_clk>,
                <&pcie30_phy0_pipe_clk>,
                <&pcie30_phy1_pipe_clk>,
                <&pcie30_phy2_pipe_clk>,