From patchwork Fri Apr 14 12:55:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wander Lairson Costa X-Patchwork-Id: 83395 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp358719vqo; Fri, 14 Apr 2023 05:58:41 -0700 (PDT) X-Google-Smtp-Source: AKy350ag31kuGv2h8gUj7UkSB2YTRDztwO1xohTLQMI3DR5fXISG49PM2rI6hLAXfOIZ9Y/JrsuT X-Received: by 2002:a17:90b:10a:b0:246:fad6:6932 with SMTP id p10-20020a17090b010a00b00246fad66932mr5564730pjz.8.1681477121674; Fri, 14 Apr 2023 05:58:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681477121; cv=none; d=google.com; s=arc-20160816; b=hl2X9tBqGlIVOhEUZJxwepAFAGmlDSM1z4LjHOSUUuO4VQT5TDpr4wBEq0fRrj72lA 3sKj7cy7HqLvT2arCxDkohipWfnR+X3/8aWL68b6U+ej2qGqQS6c9CMYWA1YwlLmMCNz WO5po2/EknnP9ouVN+TW57rtEnJZQld1tR2i6B52ZI45e/ChIKI2i9QHE44OBC6dmxak /WIDnE2IgQDWB5JENsE8Fj/zNls4x6wmO5PSEZ6Dq53XTQ5W/pdqr6cwCehm/gUnou/e jBOR7e/0Oh+8AxO5K8gY5XWoVS0GQHWcx+VCDhJyM96Ww50TD4jIwINI58dW5Cz3eSlW ijUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YrYqlnliydYiAyvEAuZGBKT9tvoR1n5A0ejNaepolyI=; b=lxFuiFPe8fHjsOaEHbVAevku5q2JgxwrEsW1hus3c1xm7U1ZL7pjhf/exX6MNHFiL4 dfbvmljShWZLkdGsvrAVj6RjDlS7reOZLft2LUN8xIafPb4rZ+byagAVzp5P1/rYE1XD WywyIVTG/uoLb3ix/OoMOkeSunMZSK9GOtc3ZRLfR9UxjthLrGqAnIG5HKXm8lH2U4n3 3b/5B6Mf3sId7EtMdI0dIPi27tq28Rz6QvBilHxUu1snNqhDXTLN0CxTvOTqB5rzcfRU ENhzTpCMBLpbtvJ79OstMXXYgEW1FwRZ2ElaZMSJcWs3XhDe7ShQbkJ4BNQHDzKC9L8p rwtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NfwmMvkQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kk2-20020a17090b4a0200b0023d2b3ac7a2si3950074pjb.60.2023.04.14.05.58.28; Fri, 14 Apr 2023 05:58:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NfwmMvkQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230088AbjDNM5E (ORCPT + 99 others); Fri, 14 Apr 2023 08:57:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbjDNM5C (ORCPT ); Fri, 14 Apr 2023 08:57:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 809E5977F for ; Fri, 14 Apr 2023 05:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681476973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YrYqlnliydYiAyvEAuZGBKT9tvoR1n5A0ejNaepolyI=; b=NfwmMvkQC8XHFUeU+H2lE2/LA95/m6GeIba51GdCAEjtUoXcqdEDuL2o4vyI7LArpeL0M/ RpEQmMPixi91XRJRRvm1t5u0IlmecEcG8OnvU9TjNVOtcE9H+NtH6P55mn0xxZql8kOT2d T1jcOAxeGo7p67+NHZaPRmCyF9GcIAE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-286-6Oqx-tBnN12S4UgBWipkuQ-1; Fri, 14 Apr 2023 08:55:57 -0400 X-MC-Unique: 6Oqx-tBnN12S4UgBWipkuQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C39D4185A791; Fri, 14 Apr 2023 12:55:55 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.9.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4FE9E406AA66; Fri, 14 Apr 2023 12:55:49 +0000 (UTC) From: Wander Lairson Costa To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Will Deacon , Waiman Long , Boqun Feng , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , "Eric W. Biederman" , Wander Lairson Costa , "Russell King (Oracle)" , Oleg Nesterov , Kefeng Wang , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Andrei Vagin , Shakeel Butt , linux-kernel@vger.kernel.org (open list), linux-perf-users@vger.kernel.org (open list:PERFORMANCE EVENTS SUBSYSTEM) Cc: Sebastian Andrzej Siewior Subject: [PATCH v6 1/3] sched/core: warn on call put_task_struct in invalid context Date: Fri, 14 Apr 2023 09:55:27 -0300 Message-Id: <20230414125532.14958-2-wander@redhat.com> In-Reply-To: <20230414125532.14958-1-wander@redhat.com> References: <20230414125532.14958-1-wander@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763156554238739912?= X-GMAIL-MSGID: =?utf-8?q?1763156554238739912?= Under PREEMPT_RT, spinlocks become sleepable locks. put_task_struct() indirectly acquires a spinlock. Therefore, it can't be called in atomic/interrupt context in RT kernels. To prevent such conditions, add a check for atomic/interrupt context before calling put_task_struct(). Signed-off-by: Wander Lairson Costa Suggested-by: Sebastian Andrzej Siewior --- include/linux/sched/task.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index 357e0068497c..b597b97b1f8f 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -113,14 +113,28 @@ static inline struct task_struct *get_task_struct(struct task_struct *t) extern void __put_task_struct(struct task_struct *t); +#define PUT_TASK_RESCHED_OFFSETS \ + (rcu_preempt_depth() << MIGHT_RESCHED_RCU_SHIFT) + +#define __put_task_might_resched() \ + __might_resched(__FILE__, __LINE__, PUT_TASK_RESCHED_OFFSETS) + +#define put_task_might_resched() \ + do { \ + if (IS_ENABLED(CONFIG_PREEMPT_RT)) \ + __put_task_might_resched(); \ + } while (0) + static inline void put_task_struct(struct task_struct *t) { + put_task_might_resched(); if (refcount_dec_and_test(&t->usage)) __put_task_struct(t); } static inline void put_task_struct_many(struct task_struct *t, int nr) { + put_task_might_resched(); if (refcount_sub_and_test(nr, &t->usage)) __put_task_struct(t); }