From patchwork Thu Apr 13 22:38:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 83108 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1363106vqo; Thu, 13 Apr 2023 15:41:27 -0700 (PDT) X-Google-Smtp-Source: AKy350YgkIUCEc8lqV9vpSAMX9wITrUxciMpc7NAl7LEw00yPn1Rw26P4frrYXLPeBrntFn8is0d X-Received: by 2002:a05:6a00:2292:b0:637:f1ae:d3e with SMTP id f18-20020a056a00229200b00637f1ae0d3emr6112761pfe.25.1681425686776; Thu, 13 Apr 2023 15:41:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681425686; cv=none; d=google.com; s=arc-20160816; b=C2yUXWLr3px3wzkzWYDBCw3FFBclMPHxXocOW2Hlde4LPBMcgzsRAzWKln2A+8fQYO NdQEYioyu+sSN9naWiM+VrhOHnxajrEKlpKPPgIsvm5VU3J8Tco9+e7mnPlHbn/9FSw5 xFJnsgmgA9sNKdR3eeZGrKmiXSndNWUBpHhHN4Yy4Fc+O1kUguL4heG+eyvzCLePpRhg hr0XlSdNwJn4NdVrBzoPCWkb5YsB7Pn4Y3DoXe8JlqNxX71jBGVr9h2MiFGOFzuAcZ/a kU0ltFxiJm0bDPUKq197fMh3bHmc5KJUjQMJFUdK8csHFmZQ7Mg8kTnMX3KrI6+SMpHS 3V6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+gpZbyojDqZY1uMDdI7fQWXEYO4PWhhxzAin4eKTqvA=; b=RKjnhhClqGuXY+JqgVd9e9ki1i06beKZq6AtDxC2ua3PLrZWMtvKFtgo2nTxDHu4o6 fvjilVep9zWlNtdc2/3AZ54A7J3YspwzPcCfPYAOKZ3XvWjzgMFNsfJXxdm/e9+nFo6I ubFktm8XQcb++5XfsVMK4wsQn0bpTp/w7FASkC+Nu0ixnxKmHfbk4VRDNUcgC21jYose /xAPItq+In6Ep7BQ8JQlwkJNMxnzqYZ9ZK1G2bNHP/i/uXsASucTux3Baa1yPRGhQve7 CrauKcjxxelYoRfkxEQCDBehMVhJiAIR4lj9F2UEzSx7UrWPJGQrAYbrIlgLo9H/KK5l Zr/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pySViAV4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w203-20020a627bd4000000b0062dbc05a323si1097833pfc.298.2023.04.13.15.41.14; Thu, 13 Apr 2023 15:41:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pySViAV4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229933AbjDMWi6 (ORCPT + 99 others); Thu, 13 Apr 2023 18:38:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbjDMWij (ORCPT ); Thu, 13 Apr 2023 18:38:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC39F4493 for ; Thu, 13 Apr 2023 15:38:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 030286421D for ; Thu, 13 Apr 2023 22:38:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21C82C433A1; Thu, 13 Apr 2023 22:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681425517; bh=cJugASXn8GtyYPZx6Snaqubv3f6wqo6+B4Dp/xetSzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pySViAV4ADvnhaXtB6RJeOBr0xnTNNsj//jOhEoXq0KWG53EpkKSF3ZsZqAVkuWfP 5vrW+3oRtuWzhzb0vTgHyWpz8jaEMy4HVNxZjVfmGdBKz9G3icd1o5V+n+gRdcDGEq 3+o7bSoSDj67tqW1j4wSGeljXiSsncaaYEoZ+8kxtd7teThMqdJWan1mLDkAlmzJ5y PZzAtBXIvbC4zBWnzR0mFe26VO3WnJ/lnT1XFZHK0PlHzYou5F8kaoE3aJ7Q/HW/p5 QMmbQ6eCuVwVrBXUcweRzSiFFpf3TfX/pbnZgHRMc3gNAwI89t6WYX+tJzHN+TTrkz MrIVdZTQEfiiw== From: Stephen Boyd To: Greg Kroah-Hartman Cc: Randy Dunlap , linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: [PATCH 5/6] spmi: fix W=1 kernel-doc warnings Date: Thu, 13 Apr 2023 15:38:33 -0700 Message-ID: <20230413223834.4084793-6-sboyd@kernel.org> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <20230413223834.4084793-1-sboyd@kernel.org> References: <20230413223834.4084793-1-sboyd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763102620879359970?= X-GMAIL-MSGID: =?utf-8?q?1763102620879359970?= From: Randy Dunlap Fix all W=1 kernel-doc warnings in drivers/spmi/: drivers/spmi/spmi.c:414: warning: expecting prototype for spmi_controller_alloc(). Prototype was for spmi_device_alloc() instead drivers/spmi/spmi.c:592: warning: expecting prototype for spmi_driver_register(). Prototype was for __spmi_driver_register() instead drivers/spmi/spmi.c:592: warning: Function parameter or member 'owner' not described in '__spmi_driver_register' drivers/spmi/spmi-pmic-arb.c:155: warning: cannot understand function prototype: 'struct spmi_pmic_arb ' drivers/spmi/spmi-pmic-arb.c:203: warning: cannot understand function prototype: 'struct pmic_arb_ver_ops ' drivers/spmi/spmi-pmic-arb.c:219: warning: expecting prototype for struct pmic_arb_ver. Prototype was for struct pmic_arb_ver_ops instead Signed-off-by: Randy Dunlap Cc: Stephen Boyd Link: https://lore.kernel.org/r/20230113064040.26801-1-rdunlap@infradead.org Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-pmic-arb.c | 4 ++-- drivers/spmi/spmi.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 42a593418aad..dcb675d980d4 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -126,7 +126,7 @@ struct apid_data { }; /** - * spmi_pmic_arb - SPMI PMIC Arbiter object + * struct spmi_pmic_arb - SPMI PMIC Arbiter object * * @rd_base: on v1 "core", on v2 "observer" register base off DT. * @wr_base: on v1 "core", on v2 "chnls" register base off DT. @@ -180,7 +180,7 @@ struct spmi_pmic_arb { }; /** - * pmic_arb_ver: version dependent functionality. + * struct pmic_arb_ver_ops - version dependent functionality. * * @ver_str: version string. * @ppid_to_apid: finds the apid for a given ppid. diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index 73551531ed43..5705151013b3 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -404,7 +404,7 @@ struct spmi_device *spmi_device_from_of(struct device_node *np) EXPORT_SYMBOL_GPL(spmi_device_from_of); /** - * spmi_controller_alloc() - Allocate a new SPMI device + * spmi_device_alloc() - Allocate a new SPMI device * @ctrl: associated controller * * Caller is responsible for either calling spmi_device_add() to add the @@ -582,8 +582,9 @@ void spmi_controller_remove(struct spmi_controller *ctrl) EXPORT_SYMBOL_GPL(spmi_controller_remove); /** - * spmi_driver_register() - Register client driver with SPMI core + * __spmi_driver_register() - Register client driver with SPMI core * @sdrv: client driver to be associated with client-device. + * @owner: module owner * * This API will register the client driver with the SPMI framework. * It is typically called from the driver's module-init function.