From patchwork Thu Apr 13 22:38:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 83111 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1366708vqo; Thu, 13 Apr 2023 15:49:13 -0700 (PDT) X-Google-Smtp-Source: AKy350YqKJeLjtgOWNbmZavmy6BQ5Z62Gm45IigdnFSgbvs+Z0HdafqnrhLkgdxPaoIpCBYfH4By X-Received: by 2002:a17:90a:4414:b0:246:a5d8:cb73 with SMTP id s20-20020a17090a441400b00246a5d8cb73mr8727438pjg.14.1681426153333; Thu, 13 Apr 2023 15:49:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681426153; cv=none; d=google.com; s=arc-20160816; b=jmgQps7XJ6sLR307keyiH3dgYDfGbrZBxuN1mkpSfo5RtEXBka9pOVN4MJ1UVoLxyn zClUPfU8ye/yZ4Ld1tMGhGniGpS8WxUsFJZFmkq7CJB+7P+ZZ/gxvoaV12jyTmKHHT5H ZXl0tUF2g9roC1pEf3caT+gYQvSjLcdIq9wjhApygPV7jg5y/Nba8NtIKbvOzm2L/XwO YvJQhS93QI0dTtGFXm/pla1dIPqJf1prlLJ94oacKGqxO13VGDVfY3B799M7W04BMrO1 hJyrCzpCh/zEVF/BiaJJA7gNPyMW6fzLuDsMOHHa9gUz6SIcSZ3QdORvYJQtCOsSu0MU 8Pww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0MycVYUvF7i9QkMqLqCGGnPlFRDIwg0EfHmUN9y6caU=; b=zEdIWfxa/TCjVx+qgMxPi4Q7e7Vd1+fKKztbnQEnujXRJKrvm0vVpiGJg9VCNq+LEm ZP8HoJUch36TGt+22y9l1AsxsOzDDKplBYobONpa/VXiqPhSzQcmuAqb05Z5LUSeiK9d XAuSh4MXRffLL7c2eCGOSv3/ZgYhuSCLAq3qjymr5vK7iSdHMGYo2SdXGlq9hasOIqxY tSF1hdMA26ipKp6u9tSqsbLBvKNnQBHwFnvN1uCVvFDwJWE3TOM8au7IVC7q75rdPqeM aFpfSR7PZyRMqqP84hn11jHKK4tFaM9s2HISdiSbC1Hg8NkLnZg01ObE/8xbfkxxQlpW 3P0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=prQzSi6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r5-20020a17090a4dc500b002343565e8b4si5397474pjl.122.2023.04.13.15.48.58; Thu, 13 Apr 2023 15:49:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=prQzSi6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230316AbjDMWiu (ORCPT + 99 others); Thu, 13 Apr 2023 18:38:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229910AbjDMWij (ORCPT ); Thu, 13 Apr 2023 18:38:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C15A0423A for ; Thu, 13 Apr 2023 15:38:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5B0956421A for ; Thu, 13 Apr 2023 22:38:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89D5AC4339E; Thu, 13 Apr 2023 22:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681425516; bh=Riwglc43l4f0bQiMlyIBog53NVU6UB5IMNh6rCQlKeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=prQzSi6ipArSlSdvcYVNPRKaicI220MjMHQx5fTrtv22/VLWFypqD52LU3ieWCddT X9aaRS3qeAXd7nuI97DL9Rp5kD+Y4fF7/BUhJw6hQLIpnIZdfY7GXDQ0yCDz4A9vFF nUvG9coNsPE6nYXydRBXy8H8IK8hiuXQga+fqQEqQHyLKw5djHl75wm7wK6Avv7E57 dwpDsJs09Lpr1nLW7BssgDITCmG2tbHE6HaiqN0aXzBw4i9wRW7G8CFD20kFnjYO4E GX6sZ7plP038awaeI4JY1QRtL/T9IOaP4ld2k3pDfM5sHQcDeGdkhNuHaHWZ3eM1So vHp/lwQHjXIZQ== From: Stephen Boyd To: Greg Kroah-Hartman Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: [PATCH 3/6] spmi: pmic-arb: Convert to platform remove callback returning void Date: Thu, 13 Apr 2023 15:38:31 -0700 Message-ID: <20230413223834.4084793-4-sboyd@kernel.org> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <20230413223834.4084793-1-sboyd@kernel.org> References: <20230413223834.4084793-1-sboyd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763103110104454348?= X-GMAIL-MSGID: =?utf-8?q?1763103110104454348?= From: Uwe Kleine-König The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230306073446.2194048-4-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-pmic-arb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 8b6a42ab816f..42a593418aad 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1674,7 +1674,7 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev) return err; } -static int spmi_pmic_arb_remove(struct platform_device *pdev) +static void spmi_pmic_arb_remove(struct platform_device *pdev) { struct spmi_controller *ctrl = platform_get_drvdata(pdev); struct spmi_pmic_arb *pmic_arb = spmi_controller_get_drvdata(ctrl); @@ -1682,7 +1682,6 @@ static int spmi_pmic_arb_remove(struct platform_device *pdev) irq_set_chained_handler_and_data(pmic_arb->irq, NULL, NULL); irq_domain_remove(pmic_arb->domain); spmi_controller_put(ctrl); - return 0; } static const struct of_device_id spmi_pmic_arb_match_table[] = { @@ -1693,7 +1692,7 @@ MODULE_DEVICE_TABLE(of, spmi_pmic_arb_match_table); static struct platform_driver spmi_pmic_arb_driver = { .probe = spmi_pmic_arb_probe, - .remove = spmi_pmic_arb_remove, + .remove_new = spmi_pmic_arb_remove, .driver = { .name = "spmi_pmic_arb", .of_match_table = spmi_pmic_arb_match_table,