Message ID | 20230413173150.71387-2-sebastian.reichel@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1219366vqo; Thu, 13 Apr 2023 10:59:40 -0700 (PDT) X-Google-Smtp-Source: AKy350ZkZCXBW04KHHhjNeX72EfgwCo2KHMoi/Z1ty/YHun6l15C+u1m9omAT8tpbGkHb1adYStj X-Received: by 2002:a05:6a20:60c9:b0:cc:a8d7:ad7e with SMTP id q9-20020a056a2060c900b000cca8d7ad7emr2327216pza.60.1681408780442; Thu, 13 Apr 2023 10:59:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681408780; cv=none; d=google.com; s=arc-20160816; b=ailcogq5Mhu+7rjsOAEQKo+tNkwF2QEvGlRabsm4ibyGK1iqhTwiMievrfTp8hRgOn AsXkNwAwbXdMOWbSOunQiQTNsMMs+xpkp0fEuQHtbDT/Dd+B1DMEq3nITnLP+LyWLY2Z xWh8/bbj4FBdTizm+HCl7wjvpf/vWavJSfko/O67hmvpbbv3riLhcTllyYvcjxTZgilh qYGHUH6MHwo4oD4PmmWVhT6ElejoejTgz4IpBjDfRfLpNUhghAxABUsE5ftsAmsry6lA 64RMTVJBxZsKJyFAgZl2u6wNm3biwbHMYx/PbUYxjD35hXn+ZO6drcL0mDDUxSIwLmyD YDHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UCjWO9UX7wqg0JkOiKSHORDybNFQI3vh6dE8/ALxnMM=; b=VruYykMmCPDwLeHxrT9ocKOkhMsJtgTNXUiJzh5gxCUiT0dF07r0BiGkxWPvkXPGsl Ew4lW4w/hBY/cxlJtIkyav2L8Cn7azwQorf4VHwHAdEZSAhnWz99GyFQ+X04iblhQk3F Mrv7cgXBFdLcOFpO8gIe5Z5Ilt5izqBCW8iE8qRvs6DVp5xVOwpOmXtBAVZIEZy7JRq4 vx6Sa0R4cKJYbWV7LxxJzyHSsZBNRupe2PRyVukxZUK6IQtL3BDlEfk1sqi1ppym4959 4T9GxHqMBF+b+wqhaAEes0gt4SquCMJI45h5M3hMVyrto7rjUSvoj3NvOINRl/G+SpiG Cx+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="WLjc8D/Z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f11-20020a63e30b000000b0050fb0a2622esi2709257pgh.400.2023.04.13.10.59.28; Thu, 13 Apr 2023 10:59:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="WLjc8D/Z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230326AbjDMRcN (ORCPT <rfc822;peter110.wang@gmail.com> + 99 others); Thu, 13 Apr 2023 13:32:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229733AbjDMRcB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 13 Apr 2023 13:32:01 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A3FA93D2; Thu, 13 Apr 2023 10:31:56 -0700 (PDT) Received: from jupiter.universe (dyndsl-091-248-212-251.ewe-ip-backbone.de [91.248.212.251]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 880CE660321C; Thu, 13 Apr 2023 18:31:54 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681407114; bh=9fXlimUk4RI4TS7WB7TrWJCQOOCfy/yC4BkqgN4K5Io=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WLjc8D/ZxyFYoW2KaMRAWUO24rFnT65DUuaFIMuaYrrz9TJcMT8ksCfwuwTiR2mtw hpHsdW8HQ4gQPPZS0iVcJrdXPTiOAPVFWSkt5DPmhs5CpvtHfgErci23QQ17lNXF89 xCHU7ixp0UUWSPV3XiGUpH+MLz0e1cdVbK9I40adBfCCn28c6ZaPkds0yuy2GZHLxT ODhaLlujZu1CYo6yhxTwy5uQrEnlSwRDJ3ems2sCA8FSU4S4MPvytnm+QGu6qXSULb Zar9oDkjKQ98MGgtxlIxobznallwOWyjXwscOjKpQGU/4PiKjQYR621Wx+pfazf8y4 ddDRmFDURQNtw== Received: by jupiter.universe (Postfix, from userid 1000) id CA56E4807E3; Thu, 13 Apr 2023 19:31:51 +0200 (CEST) From: Sebastian Reichel <sebastian.reichel@collabora.com> To: Alan Stern <stern@rowland.harvard.edu>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel <sebastian.reichel@collabora.com>, kernel@collabora.com, Rob Herring <robh@kernel.org> Subject: [PATCHv4 1/3] dt-bindings: usb: Add RK3588 OHCI Date: Thu, 13 Apr 2023 19:31:48 +0200 Message-Id: <20230413173150.71387-2-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230413173150.71387-1-sebastian.reichel@collabora.com> References: <20230413173150.71387-1-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763084893585346288?= X-GMAIL-MSGID: =?utf-8?q?1763084893585346288?= |
Series |
generic-ohci/ehci: add RK3588 support
|
|
Commit Message
Sebastian Reichel
April 13, 2023, 5:31 p.m. UTC
Add compatible for RK3588 OHCI. As far as I know it's fully compatible with generic-ohci. Reviewed-by: Rob Herring <robh@kernel.org> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- .../devicetree/bindings/usb/generic-ohci.yaml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)
Comments
On Thu, 13 Apr 2023 19:31:48 +0200, Sebastian Reichel wrote: > Add compatible for RK3588 OHCI. As far as I know it's fully > compatible with generic-ohci. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../devicetree/bindings/usb/generic-ohci.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/generic-ohci.example.dtb: usb@1c14400: clocks: [[4294967295, 6], [4294967295, 2]] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/generic-ohci.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230413173150.71387-2-sebastian.reichel@collabora.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 13/04/2023 19:31, Sebastian Reichel wrote: > Add compatible for RK3588 OHCI. As far as I know it's fully > compatible with generic-ohci. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Sebastian, Can you fix PATCH subject part in all your submissions? There should be a space between PATCH and v. Just like `git format-patch` creates. If you use other tools for this, fix them so they don't create other format. You also need to rebase your patches - this is something old and cannot be applied. > --- > .../devicetree/bindings/usb/generic-ohci.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > index a9ba7257b884..4feb993af53b 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > @@ -44,6 +44,7 @@ properties: > - hpe,gxp-ohci > - ibm,476gtr-ohci > - ingenic,jz4740-ohci > + - rockchip,rk3588-ohci > - snps,hsdk-v1.0-ohci > - const: generic-ohci > - enum: > @@ -69,7 +70,7 @@ properties: > > clocks: > minItems: 1 > - maxItems: 3 > + maxItems: 4 > description: | > In case the Renesas R-Car Gen3 SoCs: > - if a host only channel: first clock should be host. > @@ -147,6 +148,19 @@ allOf: > then: > properties: > transceiver: false > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3588-ohci > + then: > + properties: > + clocks: > + minItems: 4 > + else: > + properties: > + clocks: Please test the patches before sending. If you tested, you would see warnings here. You need minItems: 1. > + maxItems: 3 > > additionalProperties: false > Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml index a9ba7257b884..4feb993af53b 100644 --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml @@ -44,6 +44,7 @@ properties: - hpe,gxp-ohci - ibm,476gtr-ohci - ingenic,jz4740-ohci + - rockchip,rk3588-ohci - snps,hsdk-v1.0-ohci - const: generic-ohci - enum: @@ -69,7 +70,7 @@ properties: clocks: minItems: 1 - maxItems: 3 + maxItems: 4 description: | In case the Renesas R-Car Gen3 SoCs: - if a host only channel: first clock should be host. @@ -147,6 +148,19 @@ allOf: then: properties: transceiver: false + - if: + properties: + compatible: + contains: + const: rockchip,rk3588-ohci + then: + properties: + clocks: + minItems: 4 + else: + properties: + clocks: + maxItems: 3 additionalProperties: false