From patchwork Thu Apr 13 08:22:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikko Perttunen X-Patchwork-Id: 82858 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp878530vqo; Thu, 13 Apr 2023 01:36:35 -0700 (PDT) X-Google-Smtp-Source: AKy350a9cwGyGFuLhG5pAzTQU3ZLSeWDwELEmhgDnW1OtR6X6Anhg5/igsHk74KqT5DHLcN8fuCA X-Received: by 2002:a05:6a00:1a93:b0:638:d5a7:acc6 with SMTP id e19-20020a056a001a9300b00638d5a7acc6mr2460688pfv.9.1681374995262; Thu, 13 Apr 2023 01:36:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681374995; cv=none; d=google.com; s=arc-20160816; b=mP0Vy2gya0d4NEuEJYY0GS6n6t0eStDrELP41L9ofaUThrsCRHlnOK6LDBO0zxJXaf saTKmCkOVHdK0APmJ/zbC0iLjTx+qPpTKCXH1DYEMoUk83q71NflcrBatCJY25FSiwE5 GkhmESgjQukZdfQxIb7CHFTLIJGp17e5PqiVbTNIDnq7XUwvOnhl3IbYRZCRQRxaWJPW A4/jTD/K6HG0u3YERZtqpBkEJ/BKzU0t77+Jwnp+Lj+51oiEELzRGYHjU2cg51BBFtvu 62x7C1LTlfmALmWnTFtJ0730shDseL6rne+5vW2pxCY1hxQ3N75FUKeBi3Cbji6X0cL5 Pdog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=KKG30S28GcImO9fjjiMWJCrRczwA06I44fh0HArJMdw=; b=XGxJhs99HJGUJLyb6e8Zu0SUvL2C6CvGOpR4fFWCV8AFVNTJsk3s1O5zGjWcN6qS0R QHxOjHUR1aqRcY1tpS9mcvo9P5RVVMDbgVvRtKRKxmgu8jDmgH3nhxeb7DBdhefXBum5 zVke3nzLBHC0tr81qPEUWYpeU4PXQ7O8gaoKUxk94zoeGPbI4083H/dWfqDkVhkS1UrA 9CXP3dKOFXgtuND7PHov/s+GwtonH8dOEx6xrfwzLAEl7694R0LjJqApiZnIx9XbbXce 5yNuGxpUWKSTuCiJeode3FmY0+Ws7q21AcK6WP1MEsRo6O7FzQj35GxpsjVHY7nhm/Xk 3gPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kapsi.fi header.s=20161220 header.b=cFxLsR4N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kapsi.fi Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a4-20020aa795a4000000b006345170da98si1304841pfk.38.2023.04.13.01.36.23; Thu, 13 Apr 2023 01:36:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@kapsi.fi header.s=20161220 header.b=cFxLsR4N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kapsi.fi Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229678AbjDMIWU (ORCPT + 99 others); Thu, 13 Apr 2023 04:22:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbjDMIWS (ORCPT ); Thu, 13 Apr 2023 04:22:18 -0400 Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:67c:1be8::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD2FD8695; Thu, 13 Apr 2023 01:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KKG30S28GcImO9fjjiMWJCrRczwA06I44fh0HArJMdw=; b=cFxLsR4NhRubxrLXp8YIRnE+ty EaYZ+AUsoa+HvlKjdoHKeOOoIWGllAe2t4mW7TN2rs0sCcY1z0E7GgARvD29MNZ0Phb/4L3oW0cD5 kCNvHprgvJthYCVCv7ejDkx7snyOuCp2F+PtZO7Vym6s9V3lFjGUZNkf/IFOrvE/6nqX715LSmUt/ +jKYmqmU7S/pSPBMoyijhVaBGeWKdfuWsckjjOfwK1ru9w+tCVP+hjYjoLNBIl5aDFiyd787WARJE FCxOEZnWn4bE5eHHky4DyxZq188/LHvEFbrJ6t7ACkFOAeWHuUB8p6MoQLg7mTqZB9+g0wT1aD5Zl JLzm3FNw==; Received: from 91-158-25-70.elisa-laajakaista.fi ([91.158.25.70] helo=toshino.localdomain) by mail.kapsi.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pmsDc-008oPu-3l; Thu, 13 Apr 2023 11:22:12 +0300 From: Mikko Perttunen To: Thierry Reding Cc: Mikko Perttunen , Dan Carpenter , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] drm/tegra: Add error check for NVDEC firmware memory allocation Date: Thu, 13 Apr 2023 11:22:01 +0300 Message-Id: <20230413082202.114721-1-cyndis@kapsi.fi> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 91.158.25.70 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763049467224173256?= X-GMAIL-MSGID: =?utf-8?q?1763049467224173256?= From: Mikko Perttunen The return value for tegra_drm_alloc was missing an error check. Add one. Reported-by: Dan Carpenter Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/nvdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/tegra/nvdec.c index ae78a81e5eef..15ce5e89fad4 100644 --- a/drivers/gpu/drm/tegra/nvdec.c +++ b/drivers/gpu/drm/tegra/nvdec.c @@ -276,6 +276,8 @@ static int nvdec_load_falcon_firmware(struct nvdec *nvdec) return err; } else { virt = tegra_drm_alloc(tegra, size, &iova); + if (IS_ERR(virt)) + return PTR_ERR(virt); } nvdec->falcon.firmware.virt = virt;