From patchwork Thu Apr 13 04:06:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolu Lu X-Patchwork-Id: 82783 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp776573vqo; Wed, 12 Apr 2023 21:25:41 -0700 (PDT) X-Google-Smtp-Source: AKy350bgNSFlolrVSfZUVnvPT5a0SEt5fY8gXb0b4/X3X5vr+put14zOXGXO8q1vuDZHEE5d9fVP X-Received: by 2002:a05:6402:8d2:b0:502:24a4:b0ad with SMTP id d18-20020a05640208d200b0050224a4b0admr1087779edz.4.1681359941310; Wed, 12 Apr 2023 21:25:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681359941; cv=none; d=google.com; s=arc-20160816; b=tosKH+BWkDJYxsJBx8kd1kKikS5eEYWpfXus38BITQO7xXKUFFaA9PCgO4opPJn4gZ K+Gxv4T3IdB9v3EQPNYUygxTLDA1EWABmETX4z+ZdzL0f8Rn+K1U7B+85VOzmPp/UaL5 LisK8sTadcoTtFA265E9G+0NWGH+RWC/IOup3c3L/RfZK9/e2rmtqjvViQURwB4GRt3K fRRHE84CYU/olaAJwAminvyj6gdOzHEM5phaoIZsbGp8ayiZ3srtYCtGbmNzCYUL6TB7 2MTii/2yUjogANvXKqiUlImyNmil38LLG+bLy9KR44GO27dNWx+xtysVAxLnThfO3Fo9 frpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JkWEsnZSHpDwUuQeyDX9oA5BBAR+sK+h6IMXfFeyS3k=; b=ubE/DmS3tsSt1/cucyqKJDNNW1F0gHHCdlZmDM37xHxG7Ytj6Tjf22qNBqVVgeX+9H TrwPCwppJdA2mmQuvvMaYgRAbRwarLminAkkSB0LSooQovuUTRfAhbdGSOhNxwh4g7OV dQylgI/zmatXKGtCfUQUZUgMepw/7F32Y3ct4yoALqpMHyWmzOnKpFDFUwBZd2jlRHid X1UqFZdiCJ2fcr6vYXzufNQmNkSpjhMOo+Bs3vgV4/kkTEj98zrBkEKPfpFgK0Az+wk5 4Ftb7JD74q0QBnxtTA8uO7pxNZ3wW+xUxH5gBuNM+utOXi3iVd42zq3ptLdiVwVD9hf1 FjeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jQSQALmc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f6-20020a056402068600b00504a32f988csi727347edy.692.2023.04.12.21.25.17; Wed, 12 Apr 2023 21:25:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jQSQALmc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbjDMEIP (ORCPT + 99 others); Thu, 13 Apr 2023 00:08:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbjDMEHN (ORCPT ); Thu, 13 Apr 2023 00:07:13 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0938E61BF for ; Wed, 12 Apr 2023 21:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681358832; x=1712894832; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tiukwRnefzsk0G3cv6MPqdFvIODlX3L3N/gwsxTD9ak=; b=jQSQALmcifK1fFFrrqgZ5VymZN722Neq0d42JVCUDnKzJVBeyn2LLKOv NrU04Rhmxs5B8DK0Gqs64MvevTJoinZp9+CJ4ThXmvOb3eBzbicwf080d VKUtmtHCYaOaaLdutgKP1xcPLID4PNw77XocCzNa2w370isTtpozq8grd w8J7Ho6z3LvlvwZaXtjDuHNboEJbyjkiZalDmm4p8+DSezGDesP038N77 kVEKJC9vT6ww6al+uThs16giV++D05KI3fe0U0Bfbui+QWgoj6QjLmBx9 Fgc81iqmKFRgSG1+hMXtnkLwFlx5Wjb0q9YFK+XOFctHMIoXQYRLEiw5j w==; X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="332786667" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="332786667" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2023 21:07:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="935361122" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="935361122" Received: from allen-box.sh.intel.com ([10.239.159.127]) by fmsmga006.fm.intel.com with ESMTP; 12 Apr 2023 21:07:10 -0700 From: Lu Baolu To: Joerg Roedel Cc: Tina Zhang , Jacob Pan , Christophe JAILLET , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 16/17] iommu/vt-d: Remove a useless BUG_ON(dev->is_virtfn) Date: Thu, 13 Apr 2023 12:06:44 +0800 Message-Id: <20230413040645.46157-17-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413040645.46157-1-baolu.lu@linux.intel.com> References: <20230413040645.46157-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763033681952520509?= X-GMAIL-MSGID: =?utf-8?q?1763033681952520509?= From: Tina Zhang When dmar_alloc_pci_notify_info() is being invoked, the invoker has ensured the dev->is_virtfn is false. So, remove the useless BUG_ON in dmar_alloc_pci_notify_info(). Signed-off-by: Tina Zhang Link: https://lore.kernel.org/r/20230406065944.2773296-7-tina.zhang@intel.com Signed-off-by: Lu Baolu --- drivers/iommu/intel/dmar.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c index f0f51c957ccb..9346c6e7ebae 100644 --- a/drivers/iommu/intel/dmar.c +++ b/drivers/iommu/intel/dmar.c @@ -127,8 +127,6 @@ dmar_alloc_pci_notify_info(struct pci_dev *dev, unsigned long event) struct pci_dev *tmp; struct dmar_pci_notify_info *info; - BUG_ON(dev->is_virtfn); - /* * Ignore devices that have a domain number higher than what can * be looked up in DMAR, e.g. VMD subdevices with domain 0x10000