Message ID | 20230413030344.13483-1-stanley_chang@realtek.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp757985vqo; Wed, 12 Apr 2023 20:30:32 -0700 (PDT) X-Google-Smtp-Source: AKy350a31l84EupdVcdGwNqHkxcFwoDBT/ZJy1xf7U+MbjPbfPdjcqPAyma6ZgHKfFuY6JhKqcc0 X-Received: by 2002:a05:6a00:b4f:b0:634:dcf7:e885 with SMTP id p15-20020a056a000b4f00b00634dcf7e885mr1853143pfo.25.1681356632272; Wed, 12 Apr 2023 20:30:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681356632; cv=none; d=google.com; s=arc-20160816; b=OmFBxsHV+/h8zrQyRwdeYA9I/IFIamTbvUal8oKw+07zvbt1X/695lSeAUesKiFH3C 03I5NHAo+QWDMqpGAR+yDziU7NdxMmWc90gaoUDtwyTFnmQtXmA1/YRLXNxTrpBwxLPy KyngRzX0rjkmg0Mf8XsJW8/Ndo3ElAVGyJuAqTwP53lDNj4Na3Ar8/ci393XkiNd/pgl zPV2+CAYz9qSJpxFzpMx7hr6Vvl43baQPThpHReebdFn5SEXFobKowQlaZf1IAt9n4XC E/tWgXm3h/S6UQjTul725e9fStTXQBupkuinjIFkxeZBOnstmZ7ZnnjU5sDi5D8Y7pZ5 VXgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :authenticated-by; bh=TLCXc0OuAJFLIpRwKFKmbMBCgtH2Yl2GKJtX15n2iZo=; b=f2ZgXPC/4Tni2SXfXErn/xSv521tUFLa7Jw+73NFouX5rSpQAqOOOiEUjXCptgYhXF suK7mJO0x6SMqJmomOZ+y3ZV4ntrsrS1fUCcx3EC1GRlTJ6ZMO2G0NFOt1c5NIk07/x4 Bbl3B1LC8nFJKcHXeCtIMD/2WLY+ZmFOoXCA6KaN/3cSDUdfQNeP09tenZuuQgxMTsAT aFjS2J+uFWWWyX17lLaFf3Wrf6lQeFvrGQAr+Ol6cn1yl0hnHAE5DWnKNRdrNS7UiRcZ l3poNkjPYBXvCwvXyg8+GFHSnX1pVq09sYD0heJou5fSUXf2x1ZnJzUav2zn19WocE/E u44g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i20-20020aa796f4000000b0063238428e5bsi532924pfq.184.2023.04.12.20.30.20; Wed, 12 Apr 2023 20:30:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbjDMDEA (ORCPT <rfc822;peter110.wang@gmail.com> + 99 others); Wed, 12 Apr 2023 23:04:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229617AbjDMDD6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 12 Apr 2023 23:03:58 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F71F2D4E; Wed, 12 Apr 2023 20:03:56 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 33D33MnW4030161, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 33D33MnW4030161 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Thu, 13 Apr 2023 11:03:22 +0800 Received: from RTEXMBS02.realtek.com.tw (172.21.6.95) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Thu, 13 Apr 2023 11:03:44 +0800 Received: from RTEXH36505.realtek.com.tw (172.21.6.25) by RTEXMBS02.realtek.com.tw (172.21.6.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Thu, 13 Apr 2023 11:03:44 +0800 Received: from localhost.localdomain (172.21.252.101) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server id 15.1.2375.32 via Frontend Transport; Thu, 13 Apr 2023 11:03:44 +0800 From: Stanley Chang <stanley_chang@realtek.com> To: Thinh Nguyen <Thinh.Nguyen@synopsys.com> CC: <linux-usb@vger.kernel.org>, Stanley Chang <stanley_chang@realtek.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Felipe Balbi <balbi@kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, "Krzysztof Kozlowski" <krzk@kernel.org> Subject: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk Date: Thu, 13 Apr 2023 11:03:44 +0800 Message-ID: <20230413030344.13483-1-stanley_chang@realtek.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230411053550.16360-2-stanley_chang@realtek.com> References: <20230411053550.16360-2-stanley_chang@realtek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-KSE-ServerInfo: RTEXMBS02.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762968704037878271?= X-GMAIL-MSGID: =?utf-8?q?1763030211996568926?= |
Series |
None
|
|
Commit Message
Stanley Chang[昌育德]
April 13, 2023, 3:03 a.m. UTC
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for
disable the high-speed parkmode.
Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
---
Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++
1 file changed, 5 insertions(+)
Comments
On 13/04/2023 05:03, Stanley Chang wrote: > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for > disable the high-speed parkmode. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. It's the second time I am writing it. I don't understand why you keep ignoring it. Your commit msg does not explain why do we need it. > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index be36956af53b..45ca967b8d14 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -232,6 +232,11 @@ properties: > When set, all SuperSpeed bus instances in park mode are disabled. > type: boolean > > + snps,parkmode-disable-hs-quirk: > + description: > + When set, all HighSpeed bus instances in park mode are disabled. Why? Best regards, Krzysztof
> On 13/04/2023 05:03, Stanley Chang wrote: > > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for > > disable the high-speed parkmode. > > Please use scripts/get_maintainers.pl to get a list of necessary people and lists > to CC. It might happen, that command when run on an older kernel, gives > you outdated entries. Therefore please be sure you base your patches on > recent Linux kernel. > > It's the second time I am writing it. I don't understand why you keep ignoring > it. Sorry for the confusion. In the beginning I didn't have cc all maintainers. I'll resubmit a new review thread. Please ignore this email. > Your commit msg does not explain why do we need it. I will add it at new patch. > > > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > > --- > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > index be36956af53b..45ca967b8d14 100644 > > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > @@ -232,6 +232,11 @@ properties: > > When set, all SuperSpeed bus instances in park mode are disabled. > > type: boolean > > > > + snps,parkmode-disable-hs-quirk: > > + description: > > + When set, all HighSpeed bus instances in park mode are disabled. > > Why? > For some USB wifi devices, if enable this feature it will reduce the performance. Therefore, add an option for disabling HS park mode by device-tree. Thanks, Stanley
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index be36956af53b..45ca967b8d14 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -232,6 +232,11 @@ properties: When set, all SuperSpeed bus instances in park mode are disabled. type: boolean + snps,parkmode-disable-hs-quirk: + description: + When set, all HighSpeed bus instances in park mode are disabled. + type: boolean + snps,dis_metastability_quirk: description: When set, disable metastability workaround. CAUTION! Use only if you are