From patchwork Wed Apr 12 07:39:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 82295 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp145859vqo; Wed, 12 Apr 2023 01:00:42 -0700 (PDT) X-Google-Smtp-Source: AKy350ZMDexFJFPBP4qTGMNv95D/MwgmHfrzDP0ZARgKIR+eA8Vg5Ydi7boDIC29z6ZuBEvoof6R X-Received: by 2002:a17:90b:1096:b0:246:fbf2:7e6e with SMTP id gj22-20020a17090b109600b00246fbf27e6emr1291712pjb.14.1681286441982; Wed, 12 Apr 2023 01:00:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681286441; cv=none; d=google.com; s=arc-20160816; b=blK7Ysd+gYISfSOee3bnP4hMaUBOagGD0TWTMC+TaJiDaAXbni9QzhlRp88lhEyV6u MDFhdKLfgQgsIX/xZfyKawaIkaHq4yt6aTDw+0lkErY+3Oxp3+057v1gE3wd9xASUYY/ VDzoz2AFidFxqvvZoWkyHOIJuHA054F348Lp7L6TjoP76wMpVabLo9hPyF5dfimB6wHP arNzJOValPuRArp7XCogCbTia6BZUZ1SK/aNi2GYgYNQisutLRkUCHkw9B7NFBP/DSud 8BxZ/ivPVcuUHbblcJ1FytoLkq2MUD0x2j3ilOF4MTssHSbZ+RL9e3JnScJLG7BNnjl0 rSaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=n4VkPIsgh5le7RClTZnrrJBsziirVxB7lAuF6V3AYGk=; b=txUlqoHjnJYaJR179ECpnKjVXI7Lk0GW2iT+tABdIjyZ2CwhaB4c6bZY7Ah8IUsnaD oTQAN5uo08G46a0aXKJ/Nkw3SJmklCdCSXmHVVHlYYNDacbshPQJnry3dO+kbXEsZXpO oAO2mzqRHCXvt2oAt58AsahDRN1YrMCqRGKgbK0pnnKSjJQE/cNR0dkNtk/YkKZ83iVq Xg6CivER4fsFiWkynz/eXev9W4rrNx2Sjajj5FQv0wF7Rja8NOB4u/iOhzu4B3/N+1/Q BT5qIzphbtbt2bYtfcySFfOOZBi0/FkdTR8L9w31cteY20Be4rcoUB29PdEfci2aUmVq uqzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q2-20020a17090a9f4200b0023b56d6c9adsi1340647pjv.37.2023.04.12.01.00.30; Wed, 12 Apr 2023 01:00:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229469AbjDLHkb (ORCPT + 99 others); Wed, 12 Apr 2023 03:40:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjDLHk3 (ORCPT ); Wed, 12 Apr 2023 03:40:29 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 154DFE59; Wed, 12 Apr 2023 00:40:13 -0700 (PDT) Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id CE58B80CD; Wed, 12 Apr 2023 07:40:09 +0000 (UTC) From: Tony Lindgren To: Tomi Valkeinen , David Airlie , Daniel Vetter Cc: Laurent Pinchart , Sebastian Reichel , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/omap: dsi: Fix deferred probe warnings Date: Wed, 12 Apr 2023 10:39:53 +0300 Message-Id: <20230412073954.20601-1-tony@atomide.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762956611867296388?= X-GMAIL-MSGID: =?utf-8?q?1762956611867296388?= We may not have dsi->dsidev initialized during probe, and that can lead into various dsi related warnings as omap_dsi_host_detach() gets called with dsi->dsidev set to NULL. The warnings can be "Fixed dependency cycle(s)" followed by a WARNING: CPU: 0 PID: 787 at drivers/gpu/drm/omapdrm/dss/dsi.c:4414. Let's fix the warnings by checking for a valid dsi->dsidev. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -4411,7 +4411,7 @@ static int omap_dsi_host_detach(struct mipi_dsi_host *host, { struct dsi_data *dsi = host_to_omap(host); - if (WARN_ON(dsi->dsidev != client)) + if (dsi->dsidev && WARN_ON(dsi->dsidev != client)) return -EINVAL; cancel_delayed_work_sync(&dsi->dsi_disable_work);