clocksource/drivers/timer-ti-dm: Fix finding alwon timer

Message ID 20230412064142.12726-1-tony@atomide.com
State New
Headers
Series clocksource/drivers/timer-ti-dm: Fix finding alwon timer |

Commit Message

Tony Lindgren April 12, 2023, 6:41 a.m. UTC
  Clean-up commit b6999fa1c847 ("clocksource/drivers/timer-ti-dm: Use
of_address_to_resource()") caused a regression where pa is never set
making all related SoCs fail to boot. Let's fix this by setting pa
if found.

Fixes: b6999fa1c847 ("clocksource/drivers/timer-ti-dm: Use of_address_to_resource()")
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 drivers/clocksource/timer-ti-dm-systimer.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
  

Comments

Daniel Lezcano April 17, 2023, 7:31 a.m. UTC | #1
On 12/04/2023 08:41, Tony Lindgren wrote:
> Clean-up commit b6999fa1c847 ("clocksource/drivers/timer-ti-dm: Use
> of_address_to_resource()") caused a regression where pa is never set
> making all related SoCs fail to boot. Let's fix this by setting pa
> if found.
> 
> Fixes: b6999fa1c847 ("clocksource/drivers/timer-ti-dm: Use of_address_to_resource()")
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---

Applied, thanks
  

Patch

diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c
--- a/drivers/clocksource/timer-ti-dm-systimer.c
+++ b/drivers/clocksource/timer-ti-dm-systimer.c
@@ -261,8 +261,10 @@  static void __init dmtimer_systimer_assign_alwon(void)
 		if (of_address_to_resource(np, 0, &res))
 			continue;
 
+		pa = res.start;
+
 		/* Quirky omap3 boards must use dmtimer12 */
-		if (quirk_unreliable_oscillator && res.start == 0x48318000)
+		if (quirk_unreliable_oscillator && pa == 0x48318000)
 			continue;
 
 		of_node_put(np);