[v7,05/12] dt-bindings: mfd: syscon: Add nuvoton,ma35d1-sys compatible

Message ID 20230412053824.106-6-ychuang570808@gmail.com
State New
Headers
Series Introduce Nuvoton ma35d1 SoC |

Commit Message

Jacky Huang April 12, 2023, 5:38 a.m. UTC
  From: Jacky Huang <ychuang3@nuvoton.com>

Add Nuvoton ma35d1 system registers compatible.

Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Krzysztof Kozlowski April 13, 2023, 4:47 p.m. UTC | #1
On 12/04/2023 07:38, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
> 
> Add Nuvoton ma35d1 system registers compatible.
> 
> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>

What about the tag? Why did you ignore it?

Also, wasn't this applied? Why do you resend (incorrect version)?

Best regards,
Krzysztof
  
Jacky Huang April 14, 2023, 1:11 a.m. UTC | #2
Dear Krzysztof,


On 2023/4/14 上午 12:47, Krzysztof Kozlowski wrote:
> On 12/04/2023 07:38, Jacky Huang wrote:
>> From: Jacky Huang <ychuang3@nuvoton.com>
>>
>> Add Nuvoton ma35d1 system registers compatible.
>>
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> What about the tag? Why did you ignore it?
>
> Also, wasn't this applied? Why do you resend (incorrect version)?
>
> Best regards,
> Krzysztof
>

When I was making this patchset, this patch was still not merged.
So I'm not sure if I should remove it.
This is just a resend with no updates. And I will remove this patch
in the next version as it was applied.
If possible, please add the following tags for this patch.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Lee Jones <lee@kernel.org>


Thank you,
Jacky Huang
  
Lee Jones April 14, 2023, 7:03 a.m. UTC | #3
On Fri, 14 Apr 2023, Jacky Huang wrote:

> Dear Krzysztof,
>
>
> On 2023/4/14 上午 12:47, Krzysztof Kozlowski wrote:
> > On 12/04/2023 07:38, Jacky Huang wrote:
> > > From: Jacky Huang <ychuang3@nuvoton.com>
> > >
> > > Add Nuvoton ma35d1 system registers compatible.
> > >
> > > Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> > What about the tag? Why did you ignore it?
> >
> > Also, wasn't this applied? Why do you resend (incorrect version)?
> >
> > Best regards,
> > Krzysztof
> >
>
> When I was making this patchset, this patch was still not merged.
> So I'm not sure if I should remove it.
> This is just a resend with no updates. And I will remove this patch
> in the next version as it was applied.
> If possible, please add the following tags for this patch.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

I added this.

> Reviewed-by: Lee Jones <lee@kernel.org>

When did I provide this?

--
Lee Jones [李琼斯]
  
Jacky Huang April 14, 2023, 8:34 a.m. UTC | #4
On 2023/4/14 下午 03:03, Lee Jones wrote:
> On Fri, 14 Apr 2023, Jacky Huang wrote:
>
>> Dear Krzysztof,
>>
>>
>> On 2023/4/14 上午 12:47, Krzysztof Kozlowski wrote:
>>> On 12/04/2023 07:38, Jacky Huang wrote:
>>>> From: Jacky Huang <ychuang3@nuvoton.com>
>>>>
>>>> Add Nuvoton ma35d1 system registers compatible.
>>>>
>>>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>>> What about the tag? Why did you ignore it?
>>>
>>> Also, wasn't this applied? Why do you resend (incorrect version)?
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> When I was making this patchset, this patch was still not merged.
>> So I'm not sure if I should remove it.
>> This is just a resend with no updates. And I will remove this patch
>> in the next version as it was applied.
>> If possible, please add the following tags for this patch.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> I added this.
>
>> Reviewed-by: Lee Jones <lee@kernel.org>
> When did I provide this?
>
> --
> Lee Jones [李琼斯]

Dear Lee,

Thank you for your help. And, I'm sorry, I thought 'applied' meant 
'reviewed', and this patch
didn't actually get your review tag. If this offends you, please remove 
it. Of course, if you are
willing to provide a review tag, I would greatly appreciate it.


Best regards,
Jacky Huang
  
Lee Jones April 19, 2023, 3:37 p.m. UTC | #5
On Fri, 14 Apr 2023, Jacky Huang wrote:

> 
> 
> On 2023/4/14 下午 03:03, Lee Jones wrote:
> > On Fri, 14 Apr 2023, Jacky Huang wrote:
> > 
> > > Dear Krzysztof,
> > > 
> > > 
> > > On 2023/4/14 上午 12:47, Krzysztof Kozlowski wrote:
> > > > On 12/04/2023 07:38, Jacky Huang wrote:
> > > > > From: Jacky Huang <ychuang3@nuvoton.com>
> > > > > 
> > > > > Add Nuvoton ma35d1 system registers compatible.
> > > > > 
> > > > > Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> > > > What about the tag? Why did you ignore it?
> > > > 
> > > > Also, wasn't this applied? Why do you resend (incorrect version)?
> > > > 
> > > > Best regards,
> > > > Krzysztof
> > > > 
> > > When I was making this patchset, this patch was still not merged.
> > > So I'm not sure if I should remove it.
> > > This is just a resend with no updates. And I will remove this patch
> > > in the next version as it was applied.
> > > If possible, please add the following tags for this patch.
> > > 
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > I added this.
> > 
> > > Reviewed-by: Lee Jones <lee@kernel.org>
> > When did I provide this?
> > 
> > --
> > Lee Jones [李琼斯]
> 
> Dear Lee,
> 
> Thank you for your help. And, I'm sorry, I thought 'applied' meant
> 'reviewed', and this patch
> didn't actually get your review tag. If this offends you, please remove it.
> Of course, if you are
> willing to provide a review tag, I would greatly appreciate it.

If I replied with "applied" then it's applied and you do not have to
submit it again.
  

Patch

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index c828c4f5e4a7..7ee1d27f59dd 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -56,6 +56,7 @@  properties:
               - microchip,lan966x-cpu-syscon
               - microchip,sparx5-cpu-syscon
               - mstar,msc313-pmsleep
+              - nuvoton,ma35d1-sys
               - nuvoton,wpcm450-shm
               - rockchip,px30-qos
               - rockchip,rk3036-qos