diff mbox series

scsi: pm80xx: Log device registration

Message ID 20230411230650.1760757-1-pranavpp@google.com
State New
Headers
Series scsi: pm80xx: Log device registration |

Commit Message

Pranav Prasad April 11, 2023, 11:06 p.m. UTC 
  From: Akshat Jain <akshatzen@google.com>

Log combination of phy_id and device_id in device registration
response.

Signed-off-by: Akshat Jain <akshatzen@google.com>
Signed-off-by: Pranav Prasad <pranavpp@google.com>
---
 drivers/scsi/pm8001/pm8001_hwi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Jinpu Wang April 13, 2023, 7:11 a.m. UTC | #1 
On Wed, Apr 12, 2023 at 1:09 AM Pranav Prasad <pranavpp@google.com> wrote:
>
> From: Akshat Jain <akshatzen@google.com>
>
> Log combination of phy_id and device_id in device registration
> response.
>
> Signed-off-by: Akshat Jain <akshatzen@google.com>
> Signed-off-by: Pranav Prasad <pranavpp@google.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
>  drivers/scsi/pm8001/pm8001_hwi.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
> index ec1a9ab61814..73cd25f30ca5 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -3362,8 +3362,9 @@ int pm8001_mpi_reg_resp(struct pm8001_hba_info *pm8001_ha, void *piomb)
>         pm8001_dev = ccb->device;
>         status = le32_to_cpu(registerRespPayload->status);
>         device_id = le32_to_cpu(registerRespPayload->device_id);
> -       pm8001_dbg(pm8001_ha, MSG, " register device is status = %d\n",
> -                  status);
> +       pm8001_dbg(pm8001_ha, INIT,
> +                  "register device status %d phy_id 0x%x device_id %d\n",
> +                  status, pm8001_dev->attached_phy, device_id);
>         switch (status) {
>         case DEVREG_SUCCESS:
>                 pm8001_dbg(pm8001_ha, MSG, "DEVREG_SUCCESS\n");
> @@ -4278,7 +4279,7 @@ int pm8001_chip_dereg_dev_req(struct pm8001_hba_info *pm8001_ha,
>         memset(&payload, 0, sizeof(payload));
>         payload.tag = cpu_to_le32(1);
>         payload.device_id = cpu_to_le32(device_id);
> -       pm8001_dbg(pm8001_ha, MSG, "unregister device device_id = %d\n",
> +       pm8001_dbg(pm8001_ha, INIT, "unregister device device_id %d\n",
>                    device_id);
>
>         return pm8001_mpi_build_cmd(pm8001_ha, 0, opc, &payload,
> --
> 2.40.0.577.gac1e443424-goog
>
Martin K. Petersen April 19, 2023, 3:16 a.m. UTC | #2 
Pranav,

> Log combination of phy_id and device_id in device registration
> response.

Applied to 6.4/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
index ec1a9ab61814..73cd25f30ca5 100644
--- a/drivers/scsi/pm8001/pm8001_hwi.c
+++ b/drivers/scsi/pm8001/pm8001_hwi.c
@@ -3362,8 +3362,9 @@  int pm8001_mpi_reg_resp(struct pm8001_hba_info *pm8001_ha, void *piomb)
 	pm8001_dev = ccb->device;
 	status = le32_to_cpu(registerRespPayload->status);
 	device_id = le32_to_cpu(registerRespPayload->device_id);
-	pm8001_dbg(pm8001_ha, MSG, " register device is status = %d\n",
-		   status);
+	pm8001_dbg(pm8001_ha, INIT,
+		   "register device status %d phy_id 0x%x device_id %d\n",
+		   status, pm8001_dev->attached_phy, device_id);
 	switch (status) {
 	case DEVREG_SUCCESS:
 		pm8001_dbg(pm8001_ha, MSG, "DEVREG_SUCCESS\n");
@@ -4278,7 +4279,7 @@  int pm8001_chip_dereg_dev_req(struct pm8001_hba_info *pm8001_ha,
 	memset(&payload, 0, sizeof(payload));
 	payload.tag = cpu_to_le32(1);
 	payload.device_id = cpu_to_le32(device_id);
-	pm8001_dbg(pm8001_ha, MSG, "unregister device device_id = %d\n",
+	pm8001_dbg(pm8001_ha, INIT, "unregister device device_id %d\n",
 		   device_id);
 
 	return pm8001_mpi_build_cmd(pm8001_ha, 0, opc, &payload,