From patchwork Tue Apr 11 12:07:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Wagner X-Patchwork-Id: 81928 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2521405vqo; Tue, 11 Apr 2023 05:11:29 -0700 (PDT) X-Google-Smtp-Source: AKy350YQXyIKD88Aexp7GzyBstWgmI2CsJ6feUMWZDGHZHOqVmR7lhTstvrICARMnPAjeQLTY3R1 X-Received: by 2002:a17:902:cecb:b0:19e:dc0e:1269 with SMTP id d11-20020a170902cecb00b0019edc0e1269mr21468921plg.7.1681215089324; Tue, 11 Apr 2023 05:11:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681215089; cv=none; d=google.com; s=arc-20160816; b=oWUu2Ef7usQK+lftrAMZNbXxBIVUH59aokY5631uapmF6aEFByzjj+sM+j01LgbxU9 wkq2LVFqaRzgUpNv9OfzBy5wXFvQ8XH3RD3uj+amLC64io17RJ062oGs9PZwC5gvjOpT apkehsnRiNLGrzv/Esdl1GMHFqP6RPefR7tXqPM30OWa/eARzulBgUaC/5KRTT2ENrzJ 34QCQvdIjk73iQ8QABi0m6Fd3TL6Z47vd66VKhXx4+wK/IWx/R3m5FbIhJj3l8gXfN9x XeFbHr6E76rfXjJ4Iiv8h3zHDRfXmmDu/6bSbEndDcrUuFPSOlFjbunsZnLSwWbRFR4d 0aIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=NfxBQ+YwCQT4C500tsTvYDqFoF6jclwkqD6YJhX2o+Y=; b=jnrdIfhP4tBrd4r8ze5jp17E0eJ+EZYgtziItYHl+gQyvTRZ1BGHpOm3vtJYYP/+0g BygJyqReMczMUU5UY9b+WwrpgPXX6+qSvWmh0fyYJusAGJAhHyzLxpvpvCZnKL+DQBM8 wlxt68JlYsz4YwKBk9xt7hpiwPa0xSbmrirxmpuU0k3o2jrC+jjILhrbuUsypn71rv7S 1RQJfH8C5/ATRLnv+0GExmR38vGFJgqGI6mO6tHLhflvMfKhYG+TUDlBhX59IbxTThrp zQvqw6bkEZAdofllx2zl6BDGqruwhyF4WcWYp6HSyEN/8TMDZlWZhGusaNP/Jl4ufHCA PG7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=K2o6RKqo; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=sY0Uc2g6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j29-20020a63595d000000b0050e60e36393si12528445pgm.776.2023.04.11.05.11.16; Tue, 11 Apr 2023 05:11:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=K2o6RKqo; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=sY0Uc2g6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229804AbjDKMHa (ORCPT + 99 others); Tue, 11 Apr 2023 08:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbjDKMH1 (ORCPT ); Tue, 11 Apr 2023 08:07:27 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3393F2D48 for ; Tue, 11 Apr 2023 05:07:27 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D467021A47; Tue, 11 Apr 2023 12:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681214845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NfxBQ+YwCQT4C500tsTvYDqFoF6jclwkqD6YJhX2o+Y=; b=K2o6RKqoXbIRqvLQ6ms4tAYt3tGPge1LW+XGpeyYNhhwqPzdArhN6/F3MnL6zVvfehSubm ND0+AMAxECFBLQzvPbOkFyhqM3OHkp+Aw2GdDTHe6JwYuEs7p4W7xfRN6wJG/5due289zq hKC1Ejf+zYVQ6qn7uU0zf5UVjjzMqbg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681214845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NfxBQ+YwCQT4C500tsTvYDqFoF6jclwkqD6YJhX2o+Y=; b=sY0Uc2g6d18FdMSnd04E+yW9xydSYI6kfSSY7gk/t2eOtbrnREBHE9ONU1Gh7M+InxjOtw 2WITr9fAddjJzMAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C76A013638; Tue, 11 Apr 2023 12:07:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NVmqMH1NNWR5BgAAMHmgww (envelope-from ); Tue, 11 Apr 2023 12:07:25 +0000 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Sagi Grimberg , James Smart , Chaitanya Kulkarni , Daniel Wagner Subject: [PATCH v2 1/4] nvmet-fcloop: Remove remote port from list when unlinking Date: Tue, 11 Apr 2023 14:07:15 +0200 Message-Id: <20230411120718.14477-2-dwagner@suse.de> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230411120718.14477-1-dwagner@suse.de> References: <20230411120718.14477-1-dwagner@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762881793566515125?= X-GMAIL-MSGID: =?utf-8?q?1762881793566515125?= The remote port is never removed from fcloop_nports list. During module unloading it's possible to end up an busy loop in fcloop_exit, because the remote port is found in the list and thus we will never progress. The kernel log will be spammed with nvme_fcloop: fcloop_exit: Failed deleting remote port nvme_fcloop: fcloop_exit: Failed deleting target port Signed-off-by: Daniel Wagner --- drivers/nvme/target/fcloop.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c index 5c16372f3b53..1e53c8fe4b95 100644 --- a/drivers/nvme/target/fcloop.c +++ b/drivers/nvme/target/fcloop.c @@ -1352,6 +1352,8 @@ __unlink_remote_port(struct fcloop_nport *nport) nport->tport->remoteport = NULL; nport->rport = NULL; + list_del(&nport->nport_list); + return rport; }